Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1304075 > unrolled thread

Re: [RESEND PATCH v2 01/16] clk: remove unused first argument of __clk_init()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RESEND PATCH v2 01/16] clk: remove unused first argument of  __clk_init() Vladimir Zapolskiy <vz@mleia.com> - 2016-01-08 01:50 +0100
    Re: [RESEND PATCH v2 01/16] clk: remove unused first argument of __clk_init() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-08 05:00 +0100

#1304075 — Re: [RESEND PATCH v2 01/16] clk: remove unused first argument of __clk_init()

Hi,

the whole series looks very good, also I haven't found any regressions
(tested on imx6q and lpc32xx).

Please feel free to add

Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>

On 28.12.2015 12:22, Masahiro Yamada wrote:
> The "struct device *dev" is not used at all in this function.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
> Changes in v2: None
> 
>  drivers/clk/clk.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 3fba5ac..897e5ae 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2286,13 +2286,12 @@ static inline void clk_debug_unregister(struct clk_core *core)
>  
>  /**
>   * __clk_init - initialize the data structures in a struct clk
> - * @dev:	device initializing this clk, placeholder for now
>   * @clk:	clk being initialized
>   *
>   * Initializes the lists in struct clk_core, queries the hardware for the
>   * parent and rate and sets them both.
>   */
> -static int __clk_init(struct device *dev, struct clk *clk_user)
> +static int __clk_init(struct clk *clk_user)
>  {
>  	int i, ret = 0;
>  	struct clk_core *orphan;
> @@ -2575,7 +2574,7 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw)
>  		goto fail_parent_names_copy;
>  	}
>  
> -	ret = __clk_init(dev, hw->clk);
> +	ret = __clk_init(hw->clk);
>  	if (!ret)
>  		return hw->clk;
>  
> 

--
With best wishes,
Vladimir

[toc] | [next] | [standalone]

#1304160 — Re: [RESEND PATCH v2 01/16] clk: remove unused first argument of __clk_init()

Hi Vladimir,

2016-01-08 9:44 GMT+09:00 Vladimir Zapolskiy <vz@mleia.com>:
> Hi,
>
> the whole series looks very good, also I haven't found any regressions
> (tested on imx6q and lpc32xx).
>
> Please feel free to add
>
> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>


It is very good to hear.

Thanks for your review and test!



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web