Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303896 > unrolled thread

Re: [PATCH v2 5/5] selftests: firmware: add empty string and async tests

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 5/5] selftests: firmware: add empty string and async  tests Shuah Khan <shuahkh@osg.samsung.com> - 2016-01-07 22:00 +0100
    Re: [PATCH v2 5/5] selftests: firmware: add empty string and async  tests Shuah Khan <shuahkh@osg.samsung.com> - 2016-01-07 22:50 +0100
    Re: [PATCH v2 5/5] selftests: firmware: add empty string and async  tests Brian Norris <computersforpeace@gmail.com> - 2016-01-07 22:50 +0100

#1303896 — Re: [PATCH v2 5/5] selftests: firmware: add empty string and async tests

On 12/09/2015 03:50 PM, Brian Norris wrote:
> Now that we've added a 'trigger_async_request' knob to test the
> request_firmware_nowait() API, let's use it. Also add tests for the
> empty ("") string, since there have been a couple errors in that
> handling already.
> 
> Since we now have real ways that the sysfs write might fail, let's add
> the appropriate check on the 'echo' lines too.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Acked-by: Kees Cook <keescook@chromium.org>

Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

[toc] | [next] | [standalone]

#1303930

On 01/07/2016 02:39 PM, Brian Norris wrote:
> Hi Shuah,
> 
> On Thu, Jan 07, 2016 at 01:57:26PM -0700, Shuah Khan wrote:
>> On 12/09/2015 03:50 PM, Brian Norris wrote:
>>> Now that we've added a 'trigger_async_request' knob to test the
>>> request_firmware_nowait() API, let's use it. Also add tests for the
>>> empty ("") string, since there have been a couple errors in that
>>> handling already.
>>>
>>> Since we now have real ways that the sysfs write might fail, let's add
>>> the appropriate check on the 'echo' lines too.
>>>
>>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>>> Acked-by: Kees Cook <keescook@chromium.org>
>>
>> Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1.
> 
> Great! Perhaps I'm missing something: I see patches 1-4, but not this
> patch (patch 5) in:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git +next
> 

Should show up in a bit. Looks like I applied to my local
and didn't do a push. Thanks for double checking.

-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

[toc] | [prev] | [next] | [standalone]

#1303932

Hi Shuah,

On Thu, Jan 07, 2016 at 01:57:26PM -0700, Shuah Khan wrote:
> On 12/09/2015 03:50 PM, Brian Norris wrote:
> > Now that we've added a 'trigger_async_request' knob to test the
> > request_firmware_nowait() API, let's use it. Also add tests for the
> > empty ("") string, since there have been a couple errors in that
> > handling already.
> > 
> > Since we now have real ways that the sysfs write might fail, let's add
> > the appropriate check on the 'echo' lines too.
> > 
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Acked-by: Kees Cook <keescook@chromium.org>
> 
> Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1.

Great! Perhaps I'm missing something: I see patches 1-4, but not this
patch (patch 5) in:

  git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git +next

Regards,
Brian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web