Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303324 > unrolled thread

Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-01-07 08:00 +0100
    Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-07 17:10 +0100
    Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-07 21:50 +0100
      Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-07 22:30 +0100
        Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-08 03:00 +0100
        Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Jiri Olsa <jolsa@redhat.com> - 2016-01-08 17:00 +0100
      Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-01-08 06:50 +0100
        Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-08 14:00 +0100
          Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-08 14:40 +0100
            Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-08 14:50 +0100
              Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Fengguang Wu <fengguang.wu@intel.com> - 2016-01-09 03:10 +0100

#1303324 — Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu:
> > On 2015/12/17 09:29AM, Wang Nan wrote:
> > > The whole thread is:
> > > 
> > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf:
> > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangnan0@huawei.com
> > > 
> > > [PATCH v3 1/3] perf tools: Fix PowerPC native building
> > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangnan0@huawei.com
> > > 
> > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts
> > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangnan0@huawei.com
> > > 
> > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf
> > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangnan0@huawei.com
> > > 
> > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and
> 	     ^^
> > You mean v4 here.
> 
> > Anyway, now that you've sent v4, it should be much clearer.
> 
> Right, I should've read it more thoroughly, but anyway, I'll process it
> today.

Bump.

Arnaldo,
Can you please push at least the initial 3 patches of this for v4.4?  
Wang Nan has posted v6 here:
http://thread.gmane.org/gmane.linux.kernel/2110626


Thanks,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1303709

Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu:
> > > On 2015/12/17 09:29AM, Wang Nan wrote:
> > > > The whole thread is:
> > > > 
> > > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf:
> > > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangnan0@huawei.com
> > > > 
> > > > [PATCH v3 1/3] perf tools: Fix PowerPC native building
> > > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangnan0@huawei.com
> > > > 
> > > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts
> > > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangnan0@huawei.com
> > > > 
> > > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf
> > > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangnan0@huawei.com
> > > > 
> > > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and
> > 	     ^^
> > > You mean v4 here.
> > 
> > > Anyway, now that you've sent v4, it should be much clearer.
> > 
> > Right, I should've read it more thoroughly, but anyway, I'll process it
> > today.
> 
> Bump.
> 
> Arnaldo,
> Can you please push at least the initial 3 patches of this for v4.4?  

Sure, I'll try to do that now.

> Wang Nan has posted v6 here:
> http://thread.gmane.org/gmane.linux.kernel/2110626

And process the other patches in this series, in perf/core.

> 
> 
> Thanks,
> Naveen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1303881

Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu:
> > > On 2015/12/17 09:29AM, Wang Nan wrote:
> > > > The whole thread is:
> > > > 
> > > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf:
> > > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangnan0@huawei.com
> > > > 
> > > > [PATCH v3 1/3] perf tools: Fix PowerPC native building
> > > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangnan0@huawei.com
> > > > 
> > > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts
> > > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangnan0@huawei.com
> > > > 
> > > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf
> > > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangnan0@huawei.com
> > > > 
> > > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and
> > 	     ^^
> > > You mean v4 here.
> > 
> > > Anyway, now that you've sent v4, it should be much clearer.
> > 
> > Right, I should've read it more thoroughly, but anyway, I'll process it
> > today.
> 
> Bump.
> 
> Arnaldo,
> Can you please push at least the initial 3 patches of this for v4.4?  
> Wang Nan has posted v6 here:
> http://thread.gmane.org/gmane.linux.kernel/2110626

So I tried it again today, from the v6, the latest patch with that
subject line in my inbox, and I get this, after applying the first three
patches:

[acme@zoo linux]$ make -C tools clean > /dev/null
[acme@zoo linux]$ make -C tools/perf build-test
make: Entering directory '/home/git/linux/tools/perf'
Testing Makefile
tests/make:15: /scripts/Makefile.arch: No such file or directory
make[2]: *** No rule to make target '/scripts/Makefile.arch'.  Stop.
tests/make:5: recipe for target 'all' failed
make[1]: *** [all] Error 2
Makefile:81: recipe for target 'build-test' failed
make: *** [build-test] Error 2
make: Leaving directory '/home/git/linux/tools/perf'
[acme@zoo linux]$

[acme@zoo linux]$ git log --oneline | head -10
a1f721fa8b82 perf bpf: Fix build breakage due to libbpf
41020638ceb2 tools: Move Makefile.arch from perf/config to tools/scripts
abf316e348da perf tools: Fix PowerPC native building
12ca6ad2e3a8 perf: Fix race in swevent hash
c12744994465 perf: Fix race in perf_event_exec()
2d2e7ac14a1f Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
fb202539e61b perf list: Robustify event printing routine
d643b5aba848 perf list: Add support for PERF_COUNT_SW_BPF_OUT
03fba21adb19 Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
4938cf0c7a62 perf hists browser: Fix segfault if use symbol filter in cmdline
[acme@zoo linux]$

Trying to figure this out...

- Arnaldo

[toc] | [prev] | [next] | [standalone]

#1303920

Em Thu, Jan 07, 2016 at 05:39:57PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> > Can you please push at least the initial 3 patches of this for v4.4?  
> > Wang Nan has posted v6 here:
> > http://thread.gmane.org/gmane.linux.kernel/2110626
 
> So I tried it again today, from the v6, the latest patch with that
> subject line in my inbox, and I get this, after applying the first three
> patches:
 
> [acme@zoo linux]$ make -C tools clean > /dev/null
> [acme@zoo linux]$ make -C tools/perf build-test
> make: Entering directory '/home/git/linux/tools/perf'
> Testing Makefile
> tests/make:15: /scripts/Makefile.arch: No such file or directory
> make[2]: *** No rule to make target '/scripts/Makefile.arch'.  Stop.
> tests/make:5: recipe for target 'all' failed
> make[1]: *** [all] Error 2
> Makefile:81: recipe for target 'build-test' failed
> make: *** [build-test] Error 2
> make: Leaving directory '/home/git/linux/tools/perf'
> [acme@zoo linux]$

> Trying to figure this out...

So, this doesn't seem to have been tessted, this part, specifically:

diff --git a/tools/perf/tests/make b/tools/perf/tests/make
index 8ea3dffc5065..cd9c3ce1a5c2 100644
--- a/tools/perf/tests/make
+++ b/tools/perf/tests/make
@@ -12,7 +12,7 @@ endif
 else
 PERF := .
 
-include config/Makefile.arch
+include $(srctree)/scripts/Makefile.arch
 
 # FIXME looks like x86 is the only arch running tests ;-)
 # we need some IS_(32/64) flag to make this generic


----------------------------------------------------

Because $(srctree) is not set at that point, I copied the needed bits from
tools/perf/Makefile.perf and got the patch below, which makes:L

  make -C tools/perf build-test

Work for me again.

This should wrap up the day nicely, making me think of Jens Axboe recent
cool reaction to an untested patch:

http://lkml.kernel.org/r/5661C2BC.9030007@kernel.dk

:-)

Jiri, are you ok with the patch below, on top of the second patch in
Wang's series, that you acked?

- Arnaldo

diff --git a/tools/perf/tests/make b/tools/perf/tests/make
index cd9c3ce1a5c2..377654f862ec 100644
--- a/tools/perf/tests/make
+++ b/tools/perf/tests/make
@@ -1,3 +1,5 @@
+include ../scripts/Makefile.include
+
 ifndef MK
 ifeq ($(MAKECMDGOALS),)
 # no target specified, trigger the whole suite
@@ -12,7 +14,19 @@ endif
 else
 PERF := .
 
-include $(srctree)/scripts/Makefile.arch
+# As per kernel Makefile, avoid funny character set dependencies
+unexport LC_ALL
+LC_COLLATE=C
+LC_NUMERIC=C
+export LC_COLLATE LC_NUMERIC
+
+ifeq ($(srctree),)
+srctree := $(patsubst %/,%,$(dir $(shell pwd)))
+srctree := $(patsubst %/,%,$(dir $(srctree)))
+#$(info Determined 'srctree' to be $(srctree))
+endif
+
+include $(srctree)/tools/scripts/Makefile.arch
 
 # FIXME looks like x86 is the only arch running tests ;-)
 # we need some IS_(32/64) flag to make this generic

[toc] | [prev] | [next] | [standalone]

#1304112

On 2016/1/8 5:23, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 07, 2016 at 05:39:57PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
>>> Can you please push at least the initial 3 patches of this for v4.4?
>>> Wang Nan has posted v6 here:
>>> http://thread.gmane.org/gmane.linux.kernel/2110626
>   
>> So I tried it again today, from the v6, the latest patch with that
>> subject line in my inbox, and I get this, after applying the first three
>> patches:
>   
>> [acme@zoo linux]$ make -C tools clean > /dev/null
>> [acme@zoo linux]$ make -C tools/perf build-test
>> make: Entering directory '/home/git/linux/tools/perf'
>> Testing Makefile
>> tests/make:15: /scripts/Makefile.arch: No such file or directory
>> make[2]: *** No rule to make target '/scripts/Makefile.arch'.  Stop.
>> tests/make:5: recipe for target 'all' failed
>> make[1]: *** [all] Error 2
>> Makefile:81: recipe for target 'build-test' failed
>> make: *** [build-test] Error 2
>> make: Leaving directory '/home/git/linux/tools/perf'
>> [acme@zoo linux]$
>> Trying to figure this out...
> So, this doesn't seem to have been tessted, this part, specifically:
>
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index 8ea3dffc5065..cd9c3ce1a5c2 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -12,7 +12,7 @@ endif
>   else
>   PERF := .
>   
> -include config/Makefile.arch
> +include $(srctree)/scripts/Makefile.arch
>   
>   # FIXME looks like x86 is the only arch running tests ;-)
>   # we need some IS_(32/64) flag to make this generic
>
>
> ----------------------------------------------------
>
> Because $(srctree) is not set at that point, I copied the needed bits from
> tools/perf/Makefile.perf and got the patch below, which makes:L
>
>    make -C tools/perf build-test
>
> Work for me again.
>
> This should wrap up the day nicely, making me think of Jens Axboe recent
> cool reaction to an untested patch:
>
> http://lkml.kernel.org/r/5661C2BC.9030007@kernel.dk
>
> :-)
>

Sorry. I though I have tested my patch by building perf, but didn't
realize perf/tests/make is not used in normal building. Doing build-test
takes too long, so I always forget it. Also, in my environment it can fail:

   LD 
/opt/wangnan/yocto_build/tmp-eglibc/work/generic_x86_64-oe-linux/perf/1.0-r8/perf-1.0/perf-in.o
   LINK 
/opt/wangnan/yocto_build/tmp-eglibc/work/generic_x86_64-oe-linux/perf/1.0-r8/perf-1.0/perf
   test: test -x ./perf
make[2]: *** [make_no_newt] Error 1
make[1]: *** [all] Error 2
make: *** [build-test] Error 2

since I'm in a yocto building environment. I'll look into this problem 
and give a patch on it.

Thank you.

[toc] | [prev] | [next] | [standalone]

#1304674

On Thu, Jan 07, 2016 at 06:23:03PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 07, 2016 at 05:39:57PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> > > Can you please push at least the initial 3 patches of this for v4.4?  
> > > Wang Nan has posted v6 here:
> > > http://thread.gmane.org/gmane.linux.kernel/2110626
>  
> > So I tried it again today, from the v6, the latest patch with that
> > subject line in my inbox, and I get this, after applying the first three
> > patches:
>  
> > [acme@zoo linux]$ make -C tools clean > /dev/null
> > [acme@zoo linux]$ make -C tools/perf build-test
> > make: Entering directory '/home/git/linux/tools/perf'
> > Testing Makefile
> > tests/make:15: /scripts/Makefile.arch: No such file or directory
> > make[2]: *** No rule to make target '/scripts/Makefile.arch'.  Stop.
> > tests/make:5: recipe for target 'all' failed
> > make[1]: *** [all] Error 2
> > Makefile:81: recipe for target 'build-test' failed
> > make: *** [build-test] Error 2
> > make: Leaving directory '/home/git/linux/tools/perf'
> > [acme@zoo linux]$
> 
> > Trying to figure this out...
> 
> So, this doesn't seem to have been tessted, this part, specifically:
> 
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index 8ea3dffc5065..cd9c3ce1a5c2 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -12,7 +12,7 @@ endif
>  else
>  PERF := .
>  
> -include config/Makefile.arch
> +include $(srctree)/scripts/Makefile.arch
>  
>  # FIXME looks like x86 is the only arch running tests ;-)
>  # we need some IS_(32/64) flag to make this generic
> 
> 
> ----------------------------------------------------
> 
> Because $(srctree) is not set at that point, I copied the needed bits from
> tools/perf/Makefile.perf and got the patch below, which makes:L
> 
>   make -C tools/perf build-test
> 
> Work for me again.
> 
> This should wrap up the day nicely, making me think of Jens Axboe recent
> cool reaction to an untested patch:
> 
> http://lkml.kernel.org/r/5661C2BC.9030007@kernel.dk
> 
> :-)
> 
> Jiri, are you ok with the patch below, on top of the second patch in
> Wang's series, that you acked?

yep, looks good to me

thanks,
jirka

[toc] | [prev] | [next] | [standalone]

#1304197

On 2016/01/07 05:39PM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> > On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu:
> > > > On 2015/12/17 09:29AM, Wang Nan wrote:
> > > > > The whole thread is:
> > > > > 
> > > > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf:
> > > > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangnan0@huawei.com
> > > > > 
> > > > > [PATCH v3 1/3] perf tools: Fix PowerPC native building
> > > > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangnan0@huawei.com
> > > > > 
> > > > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts
> > > > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangnan0@huawei.com
> > > > > 
> > > > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf
> > > > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangnan0@huawei.com
> > > > > 
> > > > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and
> > > 	     ^^
> > > > You mean v4 here.
> > > 
> > > > Anyway, now that you've sent v4, it should be much clearer.
> > > 
> > > Right, I should've read it more thoroughly, but anyway, I'll process it
> > > today.
> > 
> > Bump.
> > 
> > Arnaldo,
> > Can you please push at least the initial 3 patches of this for v4.4?  
> > Wang Nan has posted v6 here:
> > http://thread.gmane.org/gmane.linux.kernel/2110626
> 
> So I tried it again today, from the v6, the latest patch with that
> subject line in my inbox, and I get this, after applying the first three
> patches:
> 
> [acme@zoo linux]$ make -C tools clean > /dev/null
> [acme@zoo linux]$ make -C tools/perf build-test

Thanks, and sorry for the slip-up there - I should've caught that.

> make: Entering directory '/home/git/linux/tools/perf'
> Testing Makefile
> tests/make:15: /scripts/Makefile.arch: No such file or directory
> make[2]: *** No rule to make target '/scripts/Makefile.arch'.  Stop.
> tests/make:5: recipe for target 'all' failed
> make[1]: *** [all] Error 2
> Makefile:81: recipe for target 'build-test' failed
> make: *** [build-test] Error 2
> make: Leaving directory '/home/git/linux/tools/perf'
> [acme@zoo linux]$
> 
> [acme@zoo linux]$ git log --oneline | head -10

FWIW, git log --oneline -10 works too :-)


Regards,
Naveen

[toc] | [prev] | [next] | [standalone]

#1304509

Em Fri, Jan 08, 2016 at 11:09:35AM +0530, Naveen N. Rao escreveu:
> On 2016/01/07 05:39PM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> > > On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote:
> > > > Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu:
> > > > > On 2015/12/17 09:29AM, Wang Nan wrote:
> > > > > > The whole thread is:
> > > > > > 
> > > > > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf:
> > > > > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangnan0@huawei.com
> > > > > > 
> > > > > > [PATCH v3 1/3] perf tools: Fix PowerPC native building
> > > > > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangnan0@huawei.com
> > > > > > 
> > > > > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts
> > > > > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangnan0@huawei.com
> > > > > > 
> > > > > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf
> > > > > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangnan0@huawei.com
> > > > > > 
> > > > > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and
> > > > 	     ^^
> > > > > You mean v4 here.
> > > > 
> > > > > Anyway, now that you've sent v4, it should be much clearer.
> > > > 
> > > > Right, I should've read it more thoroughly, but anyway, I'll process it
> > > > today.
> > > 
> > > Bump.
> > > 
> > > Arnaldo,
> > > Can you please push at least the initial 3 patches of this for v4.4?  
> > > Wang Nan has posted v6 here:
> > > http://thread.gmane.org/gmane.linux.kernel/2110626
> > 
> > So I tried it again today, from the v6, the latest patch with that
> > subject line in my inbox, and I get this, after applying the first three
> > patches:
> > 
> > [acme@zoo linux]$ make -C tools clean > /dev/null
> > [acme@zoo linux]$ make -C tools/perf build-test
> 
> Thanks, and sorry for the slip-up there - I should've caught that.

The important thing is that it gets caught before getting to Ingo, let
alone Linus, but if you get it before me, I'd appreciate as well 8-)

- Arnaldo
 
> > make: Entering directory '/home/git/linux/tools/perf'
> > Testing Makefile
> > tests/make:15: /scripts/Makefile.arch: No such file or directory
> > make[2]: *** No rule to make target '/scripts/Makefile.arch'.  Stop.
> > tests/make:5: recipe for target 'all' failed
> > make[1]: *** [all] Error 2
> > Makefile:81: recipe for target 'build-test' failed
> > make: *** [build-test] Error 2
> > make: Leaving directory '/home/git/linux/tools/perf'
> > [acme@zoo linux]$
> > 
> > [acme@zoo linux]$ git log --oneline | head -10
> 
> FWIW, git log --oneline -10 works too :-)

Thanks! perf also has this syndrom of wanting to do a lot of things 8-)

[toc] | [prev] | [next] | [standalone]

#1304544

On 2016/1/8 20:51, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 08, 2016 at 11:09:35AM +0530, Naveen N. Rao escreveu:
>> On 2016/01/07 05:39PM, Arnaldo Carvalho de Melo wrote:
>>> Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
>>>> On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote:
>>>>> Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu:
>>>>>> On 2015/12/17 09:29AM, Wang Nan wrote:
>>>>>>> The whole thread is:
>>>>>>>
>>>>>>> [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf:
>>>>>>> http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangnan0@huawei.com
>>>>>>>
>>>>>>> [PATCH v3 1/3] perf tools: Fix PowerPC native building
>>>>>>> http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangnan0@huawei.com
>>>>>>>
>>>>>>> [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts
>>>>>>> http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangnan0@huawei.com
>>>>>>>
>>>>>>> [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf
>>>>>>> http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangnan0@huawei.com
>>>>>>>
>>>>>>> and [PATCH v3 3/3] breaks local building because the usage of "srctree", and
>>>>> 	     ^^
>>>>>> You mean v4 here.
>>>>>> Anyway, now that you've sent v4, it should be much clearer.
>>>>> Right, I should've read it more thoroughly, but anyway, I'll process it
>>>>> today.
>>>> Bump.
>>>>
>>>> Arnaldo,
>>>> Can you please push at least the initial 3 patches of this for v4.4?
>>>> Wang Nan has posted v6 here:
>>>> http://thread.gmane.org/gmane.linux.kernel/2110626
>>> So I tried it again today, from the v6, the latest patch with that
>>> subject line in my inbox, and I get this, after applying the first three
>>> patches:
>>>
>>> [acme@zoo linux]$ make -C tools clean > /dev/null
>>> [acme@zoo linux]$ make -C tools/perf build-test
>> Thanks, and sorry for the slip-up there - I should've caught that.
> The important thing is that it gets caught before getting to Ingo, let
> alone Linus, but if you get it before me, I'd appreciate as well 8-)
>
> - Arnaldo

Is it possible to ask Fengguang Wu to help us adding perf building test
in his kbuild testing system?

Add Fengguang Wu into cc list.

Thank you.

[toc] | [prev] | [next] | [standalone]

#1304550

Em Fri, Jan 08, 2016 at 09:31:46PM +0800, Wangnan (F) escreveu:
> On 2016/1/8 20:51, Arnaldo Carvalho de Melo wrote:
> >Em Fri, Jan 08, 2016 at 11:09:35AM +0530, Naveen N. Rao escreveu:
> >>On 2016/01/07 05:39PM, Arnaldo Carvalho de Melo wrote:
> >>>Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> >>>>On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote:
> >>>>>Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu:
> >>>>Arnaldo,
> >>>>Can you please push at least the initial 3 patches of this for v4.4?
> >>>>Wang Nan has posted v6 here:
> >>>>http://thread.gmane.org/gmane.linux.kernel/2110626
> >>>So I tried it again today, from the v6, the latest patch with that
> >>>subject line in my inbox, and I get this, after applying the first three
> >>>patches:

> >>>$ make -C tools clean > /dev/null
> >>>$ make -C tools/perf build-test
> >>Thanks, and sorry for the slip-up there - I should've caught that.
> >The important thing is that it gets caught before getting to Ingo, let
> >alone Linus, but if you get it before me, I'd appreciate as well 8-)
 
> Is it possible to ask Fengguang Wu to help us adding perf building test
> in his kbuild testing system?

I was thinking about this yesterday, when, IIRC, a change made by Kan
Liang (IIRC) to a kernel/events/ file, in the kernel proper, triggered a
warning about some casts and I got a warning, since I was in the commig
log CC list.

Since perf is in the kernel sources, and since we have the 'make -C
tools/perf build-test' harness, that would be really great to have it
hooked into the 0day bot...
 
> Add Fengguang Wu into cc list.
> 
> Thank you.

Thanks!

- Arnaldo

[toc] | [prev] | [next] | [standalone]

#1305139

Hi Arnaldo,

On Fri, Jan 08, 2016 at 10:46:08AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 08, 2016 at 09:31:46PM +0800, Wangnan (F) escreveu:
> > On 2016/1/8 20:51, Arnaldo Carvalho de Melo wrote:
> > >Em Fri, Jan 08, 2016 at 11:09:35AM +0530, Naveen N. Rao escreveu:
> > >>On 2016/01/07 05:39PM, Arnaldo Carvalho de Melo wrote:
> > >>>Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
> > >>>>On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote:
> > >>>>>Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu:
> > >>>>Arnaldo,
> > >>>>Can you please push at least the initial 3 patches of this for v4.4?
> > >>>>Wang Nan has posted v6 here:
> > >>>>http://thread.gmane.org/gmane.linux.kernel/2110626
> > >>>So I tried it again today, from the v6, the latest patch with that
> > >>>subject line in my inbox, and I get this, after applying the first three
> > >>>patches:
> 
> > >>>$ make -C tools clean > /dev/null
> > >>>$ make -C tools/perf build-test
> > >>Thanks, and sorry for the slip-up there - I should've caught that.
> > >The important thing is that it gets caught before getting to Ingo, let
> > >alone Linus, but if you get it before me, I'd appreciate as well 8-)
>  
> > Is it possible to ask Fengguang Wu to help us adding perf building test
> > in his kbuild testing system?
> 
> I was thinking about this yesterday, when, IIRC, a change made by Kan
> Liang (IIRC) to a kernel/events/ file, in the kernel proper, triggered a
> warning about some casts and I got a warning, since I was in the commig
> log CC list.
> 
> Since perf is in the kernel sources, and since we have the 'make -C
> tools/perf build-test' harness, that would be really great to have it
> hooked into the 0day bot...

Yes it should be handy to do so.
CC Philip, he's now maintaining the 0day system.

Thanks,
Fengguang

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web