Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1303792 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-01-07 19:30 +0100 |
| Last post | 2016-01-11 03:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-07 19:30 +0100
Re: [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-07 21:00 +0100
Re: [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-01-11 03:00 +0100
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-01-07 19:30 +0100 |
| Subject | [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc |
| Message-ID | <qOntW-3ug-61@gated-at.bofh.it> |
The v4l2_of_parse_endpoint function kernel-doc says that the return value is always 0. But that is not true since the function can fail and a error negative code is returned on failure. So correct the kernel-doc to match. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/media/v4l2-core/v4l2-of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-of.c b/drivers/media/v4l2-core/v4l2-of.c index b27cbb1f5afe..93b33681776c 100644 --- a/drivers/media/v4l2-core/v4l2-of.c +++ b/drivers/media/v4l2-core/v4l2-of.c @@ -146,7 +146,7 @@ static void v4l2_of_parse_parallel_bus(const struct device_node *node, * variable without a low fixed limit. Please use * v4l2_of_alloc_parse_endpoint() in new drivers instead. * - * Return: 0. + * Return: 0 on success or a negative error code on failure. */ int v4l2_of_parse_endpoint(const struct device_node *node, struct v4l2_of_endpoint *endpoint) -- 2.4.3
[toc] | [next] | [standalone]
| From | Sakari Ailus <sakari.ailus@iki.fi> |
|---|---|
| Date | 2016-01-07 21:00 +0100 |
| Subject | Re: [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc |
| Message-ID | <qOoSZ-4ij-7@gated-at.bofh.it> |
| In reply to | #1303792 |
On Thu, Jan 07, 2016 at 03:27:15PM -0300, Javier Martinez Canillas wrote: > The v4l2_of_parse_endpoint function kernel-doc says that the return value > is always 0. But that is not true since the function can fail and a error > negative code is returned on failure. So correct the kernel-doc to match. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > drivers/media/v4l2-core/v4l2-of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-of.c b/drivers/media/v4l2-core/v4l2-of.c > index b27cbb1f5afe..93b33681776c 100644 > --- a/drivers/media/v4l2-core/v4l2-of.c > +++ b/drivers/media/v4l2-core/v4l2-of.c > @@ -146,7 +146,7 @@ static void v4l2_of_parse_parallel_bus(const struct device_node *node, > * variable without a low fixed limit. Please use > * v4l2_of_alloc_parse_endpoint() in new drivers instead. > * > - * Return: 0. > + * Return: 0 on success or a negative error code on failure. > */ > int v4l2_of_parse_endpoint(const struct device_node *node, > struct v4l2_of_endpoint *endpoint) Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
[toc] | [prev] | [next] | [standalone]
| From | Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
|---|---|
| Date | 2016-01-11 03:00 +0100 |
| Message-ID | <qPzW2-3VY-11@gated-at.bofh.it> |
| In reply to | #1303792 |
Hi Javier, Thank you for the patch. On Thursday 07 January 2016 15:27:15 Javier Martinez Canillas wrote: > The v4l2_of_parse_endpoint function kernel-doc says that the return value > is always 0. But that is not true since the function can fail and a error > negative code is returned on failure. So correct the kernel-doc to match. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > drivers/media/v4l2-core/v4l2-of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-of.c > b/drivers/media/v4l2-core/v4l2-of.c index b27cbb1f5afe..93b33681776c 100644 > --- a/drivers/media/v4l2-core/v4l2-of.c > +++ b/drivers/media/v4l2-core/v4l2-of.c > @@ -146,7 +146,7 @@ static void v4l2_of_parse_parallel_bus(const struct > device_node *node, * variable without a low fixed limit. Please use > * v4l2_of_alloc_parse_endpoint() in new drivers instead. > * > - * Return: 0. > + * Return: 0 on success or a negative error code on failure. > */ > int v4l2_of_parse_endpoint(const struct device_node *node, > struct v4l2_of_endpoint *endpoint) -- Regards, Laurent Pinchart
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web