Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1303781 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-01-07 19:30 +0100 |
| Last post | 2016-01-11 03:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 8/8] [media] omap3isp: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-07 19:30 +0100
Re: [PATCH 8/8] [media] omap3isp: Check v4l2_of_parse_endpoint() return value Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-01-11 03:00 +0100
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-01-07 19:30 +0100 |
| Subject | [PATCH 8/8] [media] omap3isp: Check v4l2_of_parse_endpoint() return value |
| Message-ID | <qOntU-3ug-1@gated-at.bofh.it> |
The v4l2_of_parse_endpoint() function can fail so check the return value. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/media/platform/omap3isp/isp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 79a0b953bba3..891e54394a1c 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2235,8 +2235,11 @@ static int isp_of_parse_node(struct device *dev, struct device_node *node, struct isp_bus_cfg *buscfg = &isd->bus; struct v4l2_of_endpoint vep; unsigned int i; + int ret; - v4l2_of_parse_endpoint(node, &vep); + ret = v4l2_of_parse_endpoint(node, &vep); + if (ret) + return ret; dev_dbg(dev, "parsing endpoint %s, interface %u\n", node->full_name, vep.base.port); -- 2.4.3
[toc] | [next] | [standalone]
| From | Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
|---|---|
| Date | 2016-01-11 03:00 +0100 |
| Message-ID | <qPzW2-3VY-13@gated-at.bofh.it> |
| In reply to | #1303781 |
Hi Javier, Thank you for the patch. On Thursday 07 January 2016 15:27:22 Javier Martinez Canillas wrote: > The v4l2_of_parse_endpoint() function can fail so check the return value. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > drivers/media/platform/omap3isp/isp.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index 79a0b953bba3..891e54394a1c > 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2235,8 +2235,11 @@ static int isp_of_parse_node(struct device *dev, > struct device_node *node, struct isp_bus_cfg *buscfg = &isd->bus; > struct v4l2_of_endpoint vep; > unsigned int i; > + int ret; > > - v4l2_of_parse_endpoint(node, &vep); > + ret = v4l2_of_parse_endpoint(node, &vep); > + if (ret) > + return ret; > > dev_dbg(dev, "parsing endpoint %s, interface %u\n", node->full_name, > vep.base.port); -- Regards, Laurent Pinchart
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web