Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303542 > unrolled thread

Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max  banks and counters Joerg Roedel <joro@8bytes.org> - 2016-01-07 13:40 +0100
    Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max  banks and counters Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-01-07 16:30 +0100

#1303542 — Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters

On Fri, Jan 01, 2016 at 12:13:36PM -0600, Suravee Suthikulpanit wrote:
> Currently, amd_iommu_pc_get_max_[banks|counters]() require devid,
> which should not be the case. Also, these don't properly support
> multi-IOMMU system.
> 
> Current and future AMD systems with IOMMU that support perf counter
> would likely contain homogeneous IOMMUs where multiple IOMMUs are
> availalbe. So, this patch modifies these function to iterate all IOMMU
> to check the max banks and counters reported by the hardware.
> 
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> ---
>  arch/x86/kernel/cpu/perf_event_amd_iommu.c | 17 +++++++----------
>  drivers/iommu/amd_iommu_init.c             | 20 ++++++++++++--------
>  include/linux/perf/perf_event_amd_iommu.h  |  7 ++-----
>  3 files changed, 21 insertions(+), 23 deletions(-)

Reviewed-by: Joerg Roedel <jroedel@suse.de>

This looks like the fix for the CZ issue, right? If true, it is
probably v4.5 material.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1303655

On 01/07/2016 06:34 AM, Joerg Roedel wrote:
> On Fri, Jan 01, 2016 at 12:13:36PM -0600, Suravee Suthikulpanit wrote:
>> Currently, amd_iommu_pc_get_max_[banks|counters]() require devid,
>> which should not be the case. Also, these don't properly support
>> multi-IOMMU system.
>>
>> Current and future AMD systems with IOMMU that support perf counter
>> would likely contain homogeneous IOMMUs where multiple IOMMUs are
>> availalbe. So, this patch modifies these function to iterate all IOMMU
>> to check the max banks and counters reported by the hardware.
>>
>> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>> ---
>>   arch/x86/kernel/cpu/perf_event_amd_iommu.c | 17 +++++++----------
>>   drivers/iommu/amd_iommu_init.c             | 20 ++++++++++++--------
>>   include/linux/perf/perf_event_amd_iommu.h  |  7 ++-----
>>   3 files changed, 21 insertions(+), 23 deletions(-)
>
> Reviewed-by: Joerg Roedel <jroedel@suse.de>
>
> This looks like the fix for the CZ issue, right? If true, it is
> probably v4.5 material.

Yes in deed :)

Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web