Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1303119 > unrolled thread
| Started by | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| First post | 2016-01-07 00:00 +0100 |
| Last post | 2016-01-07 11:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: rohm_bu21023 - fix handling of retrying firmware update Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-07 00:00 +0100
Re: [PATCH] Input: rohm_bu21023 - fix handling of retrying firmware update Yuasa Yoichi <yuasa@linux-mips.org> - 2016-01-07 11:20 +0100
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-01-07 00:00 +0100 |
| Subject | [PATCH] Input: rohm_bu21023 - fix handling of retrying firmware update |
| Message-ID | <qO5dE-7rK-1@gated-at.bofh.it> |
Because of the wrong condition we'd never retry firmware update. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/touchscreen/rohm_bu21023.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/rohm_bu21023.c b/drivers/input/touchscreen/rohm_bu21023.c index ba6024f..611156a 100644 --- a/drivers/input/touchscreen/rohm_bu21023.c +++ b/drivers/input/touchscreen/rohm_bu21023.c @@ -725,7 +725,7 @@ static int rohm_ts_load_firmware(struct i2c_client *client, break; error = -EIO; - } while (++retry >= FIRMWARE_RETRY_MAX); + } while (++retry <= FIRMWARE_RETRY_MAX); out: error2 = i2c_smbus_write_byte_data(client, INT_MASK, INT_ALL); -- 2.6.0.rc2.230.g3dd15c0 -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Yuasa Yoichi <yuasa@linux-mips.org> |
|---|---|
| Date | 2016-01-07 11:20 +0100 |
| Subject | Re: [PATCH] Input: rohm_bu21023 - fix handling of retrying firmware update |
| Message-ID | <qOfPH-6JB-15@gated-at.bofh.it> |
| In reply to | #1303119 |
Hi Dmitry, Thank you for fixing it. Acked-by:Yoichi Yuasa <yuasa@linux-mips.org> 2016-01-07 7:51 GMT+09:00 Dmitry Torokhov <dmitry.torokhov@gmail.com>: > Because of the wrong condition we'd never retry firmware update. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/input/touchscreen/rohm_bu21023.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/rohm_bu21023.c b/drivers/input/touchscreen/rohm_bu21023.c > index ba6024f..611156a 100644 > --- a/drivers/input/touchscreen/rohm_bu21023.c > +++ b/drivers/input/touchscreen/rohm_bu21023.c > @@ -725,7 +725,7 @@ static int rohm_ts_load_firmware(struct i2c_client *client, > break; > > error = -EIO; > - } while (++retry >= FIRMWARE_RETRY_MAX); > + } while (++retry <= FIRMWARE_RETRY_MAX); > > out: > error2 = i2c_smbus_write_byte_data(client, INT_MASK, INT_ALL); > -- > 2.6.0.rc2.230.g3dd15c0 > > > -- > Dmitry > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web