Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1301666 > unrolled thread
| Started by | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| First post | 2016-01-05 17:20 +0100 |
| Last post | 2016-01-07 09:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] s390: drop smp_mb in vdso_init "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-05 17:20 +0100
Re: [PATCH] s390: drop smp_mb in vdso_init Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-07 09:50 +0100
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2016-01-05 17:20 +0100 |
| Subject | [PATCH] s390: drop smp_mb in vdso_init |
| Message-ID | <qNCv1-5eI-21@gated-at.bofh.it> |
The initial s390 vdso code is heavily influenced by the powerpc version which does have a smp_wmb in vdso_init right before the vdso_ready=1 assignment. s390 has no need for that. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- Untested. arch/s390/kernel/vdso.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c index 59eddb0..a1cfd37 100644 --- a/arch/s390/kernel/vdso.c +++ b/arch/s390/kernel/vdso.c @@ -299,8 +299,6 @@ static int __init vdso_init(void) get_page(virt_to_page(vdso_data)); - smp_mb(); - return 0; } early_initcall(vdso_init); -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Christian Borntraeger <borntraeger@de.ibm.com> |
|---|---|
| Date | 2016-01-07 09:50 +0100 |
| Message-ID | <qOeqC-5Ek-3@gated-at.bofh.it> |
| In reply to | #1301666 |
On 01/05/2016 05:17 PM, Michael S. Tsirkin wrote: > The initial s390 vdso code is heavily influenced by the powerpc version > which does have a smp_wmb in vdso_init right before the vdso_ready=1 > assignment. s390 has no need for that. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > > Untested. > > arch/s390/kernel/vdso.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c > index 59eddb0..a1cfd37 100644 > --- a/arch/s390/kernel/vdso.c > +++ b/arch/s390/kernel/vdso.c > @@ -299,8 +299,6 @@ static int __init vdso_init(void) > > get_page(virt_to_page(vdso_data)); > > - smp_mb(); > - > return 0; > } > early_initcall(vdso_init); > applied to the s390 tree. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web