Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305214 > unrolled thread

[PATCH] rcu/tree: use true/false to set rdp->core_needs_qs

Back to article view | Back to linux.kernel

Contents

  [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs nimisolo <nimisolo@gmail.com> - 2016-01-09 12:30 +0100
    Re: [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-01-09 17:50 +0100

#1305214 — [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs

Maybe it's better to set rdp->core_needs_qs with true/false

Signed-off-by: nimisolo <nimisolo@gmail.com>
---
 kernel/rcu/tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index f07343b..0c0d09d 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -2377,7 +2377,7 @@ rcu_report_qs_rdp(int cpu, struct rcu_state *rsp, struct rcu_data *rdp)
 	if ((rnp->qsmask & mask) == 0) {
 		raw_spin_unlock_irqrestore(&rnp->lock, flags);
 	} else {
-		rdp->core_needs_qs = 0;
+		rdp->core_needs_qs = false;
 
 		/*
 		 * This GP can't end until cpu checks in, so all of our
-- 
2.5.0

[toc] | [next] | [standalone]

#1305318

On Sat, Jan 09, 2016 at 06:23:04AM -0500, nimisolo wrote:
> Maybe it's better to set rdp->core_needs_qs with true/false
> 
> Signed-off-by: nimisolo <nimisolo@gmail.com>

Good catch, but someone beat you by about a month.

To check for future changes, please see branch rcu/dev of:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git

							Thanx, Paul

> ---
>  kernel/rcu/tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index f07343b..0c0d09d 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2377,7 +2377,7 @@ rcu_report_qs_rdp(int cpu, struct rcu_state *rsp, struct rcu_data *rdp)
>  	if ((rnp->qsmask & mask) == 0) {
>  		raw_spin_unlock_irqrestore(&rnp->lock, flags);
>  	} else {
> -		rdp->core_needs_qs = 0;
> +		rdp->core_needs_qs = false;
> 
>  		/*
>  		 * This GP can't end until cpu checks in, so all of our
> -- 
> 2.5.0
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web