Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1300883 > unrolled thread
| Started by | Tim Sander <tim@krieglstein.org> |
|---|---|
| First post | 2016-01-04 18:00 +0100 |
| Last post | 2016-01-08 22:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express Tim Sander <tim@krieglstein.org> - 2016-01-04 18:00 +0100
Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express Bjorn Helgaas <helgaas@kernel.org> - 2016-01-08 21:50 +0100
Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express Alex Williamson <alex.williamson@redhat.com> - 2016-01-08 22:20 +0100
| From | Tim Sander <tim@krieglstein.org> |
|---|---|
| Date | 2016-01-04 18:00 +0100 |
| Subject | [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express |
| Message-ID | <qNgEa-609-5@gated-at.bofh.it> |
Hi
Please consider this patch for the next release. It won't recognize my Plextor
M6e PCIE disk without it. Please cc as i am not on the list.
Signed-off-by: Tim Sander <tim@krieglstein.org>
PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)
---
drivers/pci/quirks.c | 4 ++++
include/linux/pci_ids.h | 3 +++
2 files changed, 7 insertions(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 7e32730..93ec5a02 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
PCI_DEVICE_ID_JMICRON_JMB388_ESD,
quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
+ PCI_DEVICE_ID_PLEXTOR_M6E,
+ quirk_dma_func1_alias);
/*
* Some devices DMA with the wrong devfn, not just the wrong function.
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index d9ba49c..01d8041 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2501,6 +2501,9 @@
#define PCI_VENDOR_ID_ASMEDIA 0x1b21
+#define PCI_VENDOR_ID_LITE_ON 0x1c28
+#define PCI_DEVICE_ID_PLEXTOR_M6E 0x0122
+
#define PCI_VENDOR_ID_CIRCUITCO 0x1cc8
#define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2016-01-08 21:50 +0100 |
| Subject | Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express |
| Message-ID | <qOM8W-3B5-7@gated-at.bofh.it> |
| In reply to | #1300883 |
[+cc Alex] On Mon, Jan 04, 2016 at 05:47:14PM +0100, Tim Sander wrote: > Hi > > Please consider this patch for the next release. It won't recognize my Plextor > M6e PCIE disk without it. Please cc as i am not on the list. > > Signed-off-by: Tim Sander <tim@krieglstein.org> > > PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14) Alex? Please use a subject line that matches the other similar commits: 247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120 c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint RocketRaid 642L cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell devices > --- > drivers/pci/quirks.c | 4 ++++ > include/linux/pci_ids.h | 3 +++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 7e32730..93ec5a02 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642, > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON, > PCI_DEVICE_ID_JMICRON_JMB388_ESD, > quirk_dma_func1_alias); > +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */ Thanks for the link. There are 126 comments on that bugzilla so far, so it'd be nice to have a more specific pointer. I'm guessing 117 might be the relevant one, so: https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117 > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON, > + PCI_DEVICE_ID_PLEXTOR_M6E, > + quirk_dma_func1_alias); > > /* > * Some devices DMA with the wrong devfn, not just the wrong function. > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index d9ba49c..01d8041 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2501,6 +2501,9 @@ > > #define PCI_VENDOR_ID_ASMEDIA 0x1b21 > > +#define PCI_VENDOR_ID_LITE_ON 0x1c28 > +#define PCI_DEVICE_ID_PLEXTOR_M6E 0x0122 Since these constants are only used in one place, don't add them to pci_ids.h (see comment at the top of this file). Just use the hex constants directly in the quirk and include the vendor/device names in the comment. > #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8 > #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001 > > -- > 1.9.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Alex Williamson <alex.williamson@redhat.com> |
|---|---|
| Date | 2016-01-08 22:20 +0100 |
| Subject | Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express |
| Message-ID | <qOMBY-42d-17@gated-at.bofh.it> |
| In reply to | #1305005 |
On Fri, 2016-01-08 at 14:49 -0600, Bjorn Helgaas wrote: > [+cc Alex] > > On Mon, Jan 04, 2016 at 05:47:14PM +0100, Tim Sander wrote: > > Hi > > > > Please consider this patch for the next release. It won't recognize > > my Plextor > > M6e PCIE disk without it. Please cc as i am not on the list. > > > > Signed-off-by: Tim Sander <tim@krieglstein.org> > > > > PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD > > [Marvell 88SS9183] (rev 14) > > Alex? Aside from the style issues you've already commented on, I'll give a thumbs up to quirking this device. Thanks, Alex > Please use a subject line that matches the other similar commits: > > 247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120 > c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint > RocketRaid 642L > cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell > devices > > > --- > > drivers/pci/quirks.c | 4 ++++ > > include/linux/pci_ids.h | 3 +++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index 7e32730..93ec5a02 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, > > 0x0642, > > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON, > > PCI_DEVICE_ID_JMICRON_JMB388_ESD, > > quirk_dma_func1_alias); > > +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */ > > Thanks for the link. There are 126 comments on that bugzilla so far, > so it'd be nice to have a more specific pointer. I'm guessing 117 > might be the relevant one, so: > > https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117 > > > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON, > > + PCI_DEVICE_ID_PLEXTOR_M6E, > > + quirk_dma_func1_alias); > > > > /* > > * Some devices DMA with the wrong devfn, not just the wrong > > function. > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index d9ba49c..01d8041 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2501,6 +2501,9 @@ > > > > #define PCI_VENDOR_ID_ASMEDIA 0x1b21 > > > > +#define PCI_VENDOR_ID_LITE_ON 0x1c28 > > +#define PCI_DEVICE_ID_PLEXTOR_M6E 0x0122 > > Since these constants are only used in one place, don't add them to > pci_ids.h (see comment at the top of this file). Just use the hex > constants directly in the quirk and include the vendor/device names > in > the comment. > > > #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8 > > #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001 > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web