Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301001 > unrolled thread

Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version Wolfram Sang <wsa@the-dreams.de> - 2016-01-04 20:50 +0100
    Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version "David.Wu" <wdc@rock-chips.com> - 2016-01-08 14:20 +0100

#1301001 — Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version

[Multipart message — attachments visible in raw view] — view raw

> >> +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long
> >> scl_rate,
> >> +                                unsigned long scl_rise_ns,
> >> +                                unsigned long scl_fall_ns,
> >> +                                unsigned long sda_fall_ns,
> 
> Wolfram did some sturct to assign the parameters from device properties.
> It might be re-used here.

Yes, I think it makes sense to convert the driver first to use
the new i2c_parse_fw_timings() function and see if it fits (or if we need
to extend it perhaps).

David, does this make sense to you?

[toc] | [next] | [standalone]

#1304521

Hi Wolfram, Andy

Thanks for your suggestion.
I will  use i2c_parse_fw_timings() function to replace it.

在 2016/1/5 3:40, Wolfram Sang 写道:
>>>> +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long
>>>> scl_rate,
>>>> +                                unsigned long scl_rise_ns,
>>>> +                                unsigned long scl_fall_ns,
>>>> +                                unsigned long sda_fall_ns,
>> Wolfram did some sturct to assign the parameters from device properties.
>> It might be re-used here.
> Yes, I think it makes sense to convert the driver first to use
> the new i2c_parse_fw_timings() function and see if it fits (or if we need
> to extend it perhaps).
>
> David, does this make sense to you?
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web