Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1304380 > unrolled thread

[patch] cxgbi: typo in MODULE_PARM_DESC

Started byDan Carpenter <dan.carpenter@oracle.com>
First post2016-01-08 12:10 +0100
Last post2016-01-08 19:00 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [patch] cxgbi: typo in MODULE_PARM_DESC Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-08 12:10 +0100
    Re: [patch] cxgbi: typo in MODULE_PARM_DESC "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com> - 2016-01-08 17:40 +0100
    Re: [patch] cxgbi: typo in MODULE_PARM_DESC "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-08 19:00 +0100

#1304380 — [patch] cxgbi: typo in MODULE_PARM_DESC

FromDan Carpenter <dan.carpenter@oracle.com>
Date2016-01-08 12:10 +0100
Subject[patch] cxgbi: typo in MODULE_PARM_DESC
Message-ID<qOD5E-5Ri-23@gated-at.bofh.it>
The module_param is "cxgb3i_rx_credit_thres" so the MODULE_PARM_DESC()
should match that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
index 0e2bee9..e22a268 100644
--- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
+++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
@@ -57,7 +57,7 @@ MODULE_PARM_DESC(cxgb3i_snd_win, "TCP send window in bytes (default=128KB)");
 
 static int cxgb3i_rx_credit_thres = 10 * 1024;
 module_param(cxgb3i_rx_credit_thres, int, 0644);
-MODULE_PARM_DESC(rx_credit_thres,
+MODULE_PARM_DESC(cxgb3i_rx_credit_thres,
 		 "RX credits return threshold in bytes (default=10KB)");
 
 static unsigned int cxgb3i_max_connect = 8 * 1024;

[toc] | [next] | [standalone]

#1304714

From"Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
Date2016-01-08 17:40 +0100
Message-ID<qOIf0-Qw-15@gated-at.bofh.it>
In reply to#1304380
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>

[toc] | [prev] | [next] | [standalone]

#1304781

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2016-01-08 19:00 +0100
Message-ID<qOJur-1Gl-21@gated-at.bofh.it>
In reply to#1304380
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:

Dan> The module_param is "cxgb3i_rx_credit_thres" so the
Dan> MODULE_PARM_DESC() should match that.

Applied to 4.5/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web