Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1304354 > unrolled thread

Re: [lkp] [mm, vmstat] 373ccbe592: BUG: unable to handle kernel

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [lkp] [mm, vmstat] 373ccbe592: BUG: unable to handle kernel Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-01-08 11:40 +0100

#1304354 — Re: [lkp] [mm, vmstat] 373ccbe592: BUG: unable to handle kernel

Ying Huang wrote:
> FYI, we noticed the below changes on
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> commit 373ccbe5927034b55bdc80b0f8b54d6e13fe8d12 ("mm, vmstat: allow WQ concurrency to discover memory reclaim doesn't make any progress")
> 
> 
> +------------------------------------------+------------+------------+
> |                                          | 475a2f905d | 373ccbe592 |
> +------------------------------------------+------------+------------+
> | boot_successes                           | 303        | 265        |
> | boot_failures                            | 0          | 39         |
> | BUG:unable_to_handle_kernel              | 0          | 39         |
> | Oops                                     | 0          | 39         |
> | EIP_is_at__queue_work                    | 0          | 39         |
> | Kernel_panic-not_syncing:Fatal_exception | 0          | 39         |
> | backtrace:vmstat_shepherd                | 0          | 39         |
> +------------------------------------------+------------+------------+
> 
Thank you. I think that start_shepherd_timer() started shepherd item
and vmstat_shepherd() is called before vmstat_wq = alloc_workqueue() is
called. We are sometimes too late to allocate vmstat_wq workqueue.
Please try below one.

----------
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 4ebc17d..6478929 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1545,12 +1545,12 @@ static struct notifier_block vmstat_notifier =
 static int __init setup_vmstat(void)
 {
 #ifdef CONFIG_SMP
+	vmstat_wq = alloc_workqueue("vmstat", WQ_FREEZABLE|WQ_MEM_RECLAIM, 0);
 	cpu_notifier_register_begin();
 	__register_cpu_notifier(&vmstat_notifier);
 
 	start_shepherd_timer();
 	cpu_notifier_register_done();
-	vmstat_wq = alloc_workqueue("vmstat", WQ_FREEZABLE|WQ_MEM_RECLAIM, 0);
 #endif
 #ifdef CONFIG_PROC_FS
 	proc_create("buddyinfo", S_IRUGO, NULL, &fragmentation_file_operations);
----------

We need to backport this fix to stable since this commit already went to 3.2.75.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web