Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303250 > unrolled thread

Re: linux-next: build failure after merge of the drm tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2016-01-07 03:50 +0100
Last post2016-01-12 09:30 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: linux-next: build failure after merge of the drm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-01-07 03:50 +0100
    Re: linux-next: build failure after merge of the drm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-01-12 00:00 +0100
      Re: linux-next: build failure after merge of the drm tree Dave Airlie <airlied@linux.ie> - 2016-01-12 01:40 +0100
        Re: linux-next: build failure after merge of the drm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-01-12 05:40 +0100
          RE: linux-next: build failure after merge of the drm tree "Zhu, Rex" <Rex.Zhu@amd.com> - 2016-01-12 09:30 +0100

#1303250 — Re: linux-next: build failure after merge of the drm tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2016-01-07 03:50 +0100
SubjectRe: linux-next: build failure after merge of the drm tree
Message-ID<qO8Od-1AB-13@gated-at.bofh.it>
Hi all,

On Thu, 31 Dec 2015 21:31:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_thermal.c: In function 'tonga_fan_ctrl_get_fan_speed_percent':
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_thermal.c:84:2: error: implicit declaration of function 'do_div' [-Werror=implicit-function-declaration]
>   do_div(tmp64, duty100);
>   ^
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/fiji_thermal.c: In function 'fiji_fan_ctrl_get_fan_speed_percent':
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/fiji_thermal.c:78:2: error: implicit declaration of function 'do_div' [-Werror=implicit-function-declaration]
>   do_div(tmp64, duty100);
>   ^
> 
> Caused by commit
> 
>   1e4854e96c35 ("drm/amdgpu/powerplay: implement thermal control for tonga.")
> 
> [I notice that that commit does not have a Signed-off-by from its
> committer (Alex)]
> 
> I applied the following fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 31 Dec 2015 21:20:20 +1100
> Subject: [PATCH] drm/amdgpu/powerplay: include asm/div64.h for do_div()
> 
> Fixes: 1e4854e96c35 ("drm/amdgpu/powerplay: implement thermal control for tonga.")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c  | 2 +-
>  drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c
> index def57d0675ed..e76a7de9aa32 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c
> @@ -20,7 +20,7 @@
>   * OTHER DEALINGS IN THE SOFTWARE.
>   *
>   */
> -
> +#include <asm/div64.h>
>  #include "fiji_thermal.h"
>  #include "fiji_hwmgr.h"
>  #include "fiji_smumgr.h"
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c
> index 2e159b003e71..a188174747c9 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c
> @@ -20,7 +20,7 @@
>   * OTHER DEALINGS IN THE SOFTWARE.
>   *
>   */
> -
> +#include <asm/div64.h>
>  #include "tonga_thermal.h"
>  #include "tonga_hwmgr.h"
>  #include "tonga_smumgr.h"
> -- 
> 2.6.4

Ping?  I am still applying that patch ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1306798

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2016-01-12 00:00 +0100
Message-ID<qPTBo-vZ-7@gated-at.bofh.it>
In reply to#1303250
Hi Dave,

On Thu, 7 Jan 2016 13:44:03 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 31 Dec 2015 21:31:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the drm tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_thermal.c: In function 'tonga_fan_ctrl_get_fan_speed_percent':
> > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_thermal.c:84:2: error: implicit declaration of function 'do_div' [-Werror=implicit-function-declaration]
> >   do_div(tmp64, duty100);
> >   ^
> > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/fiji_thermal.c: In function 'fiji_fan_ctrl_get_fan_speed_percent':
> > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/fiji_thermal.c:78:2: error: implicit declaration of function 'do_div' [-Werror=implicit-function-declaration]
> >   do_div(tmp64, duty100);
> >   ^
> > 
> > Caused by commit
> > 
> >   1e4854e96c35 ("drm/amdgpu/powerplay: implement thermal control for tonga.")
> > 
> > [I notice that that commit does not have a Signed-off-by from its
> > committer (Alex)]
> > 
> > I applied the following fix patch for today:
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Thu, 31 Dec 2015 21:20:20 +1100
> > Subject: [PATCH] drm/amdgpu/powerplay: include asm/div64.h for do_div()
> > 
> > Fixes: 1e4854e96c35 ("drm/amdgpu/powerplay: implement thermal control for tonga.")
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c  | 2 +-
> >  drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c
> > index def57d0675ed..e76a7de9aa32 100644
> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c
> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c
> > @@ -20,7 +20,7 @@
> >   * OTHER DEALINGS IN THE SOFTWARE.
> >   *
> >   */
> > -
> > +#include <asm/div64.h>
> >  #include "fiji_thermal.h"
> >  #include "fiji_hwmgr.h"
> >  #include "fiji_smumgr.h"
> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c
> > index 2e159b003e71..a188174747c9 100644
> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c
> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_thermal.c
> > @@ -20,7 +20,7 @@
> >   * OTHER DEALINGS IN THE SOFTWARE.
> >   *
> >   */
> > -
> > +#include <asm/div64.h>
> >  #include "tonga_thermal.h"
> >  #include "tonga_hwmgr.h"
> >  #include "tonga_smumgr.h"
> > -- 
> > 2.6.4  
> 
> Ping?  I am still applying that patch ...

Did this get fixed in some non-obvious way?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[toc] | [prev] | [next] | [standalone]

#1306859

FromDave Airlie <airlied@linux.ie>
Date2016-01-12 01:40 +0100
Message-ID<qPVaa-1En-9@gated-at.bofh.it>
In reply to#1306798
> 
> Did this get fixed in some non-obvious way?
> 

I don't think so, I just applied it as is.

Thanks,
Dave.

[toc] | [prev] | [next] | [standalone]

#1306983

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2016-01-12 05:40 +0100
Message-ID<qPYUq-4hz-11@gated-at.bofh.it>
In reply to#1306859
Hi Dave,

[This time keeping cc's]

On Tue, 12 Jan 2016 00:31:17 +0000 (GMT) Dave Airlie <airlied@linux.ie> wrote:
>
> > 
> > Did this get fixed in some non-obvious way?
> >   
> 
> I don't think so, I just applied it as is.

/me refetches the drm tree

Ah, there it is! :-)

Thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[toc] | [prev] | [next] | [standalone]

#1307090

From"Zhu, Rex" <Rex.Zhu@amd.com>
Date2016-01-12 09:30 +0100
Message-ID<qQ2v1-6Gt-19@gated-at.bofh.it>
In reply to#1306983
Hi,

In my end, this declaration of function 'do_div'  can be founded.

In file included from ./arch/x86/include/asm/div64.h:63:0,
                 from include/linux/math64.h:5,
                 from ./arch/x86/include/asm/processor.h:30,
                 from ./arch/x86/include/asm/atomic.h:6,
                 from include/linux/atomic.h:4,
                 from include/linux/mutex.h:18,
                 from include/linux/seq_file.h:7,
                 from drivers/gpu/drm/amd/powerplay/inc/hwmgr.h:26,
                 from drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_thermal.h:27,
                 from drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_thermal.c:24:
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_thermal.c: In function 'tonga_fan_ctrl_get_fan_speed_info'


So I will add  "#include <asm/div64.h>" to fix the warning.


Best Regards
Rex
-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: Tuesday, January 12, 2016 12:35 PM
To: Dave Airlie
Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Zhu, Rex; Deucher, Alexander
Subject: Re: linux-next: build failure after merge of the drm tree

Hi Dave,

[This time keeping cc's]

On Tue, 12 Jan 2016 00:31:17 +0000 (GMT) Dave Airlie <airlied@linux.ie> wrote:
>
> > 
> > Did this get fixed in some non-obvious way?
> >   
> 
> I don't think so, I just applied it as is.

/me refetches the drm tree

Ah, there it is! :-)

Thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web