Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301407 > unrolled thread

Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and  no-cmd23 quirks for sdhci-arasan4.9a Rameshwar Sahu <rsahu@apm.com> - 2016-01-05 11:30 +0100
    Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and  no-cmd23 quirks for sdhci-arasan4.9a Jaehoon Chung <jh80.chung@samsung.com> - 2016-01-07 02:40 +0100
      Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and  no-cmd23 quirks for sdhci-arasan4.9a Rameshwar Sahu <rsahu@apm.com> - 2016-01-07 13:40 +0100

#1301407 — Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a

Hi Ulf,

On Wed, Dec 23, 2015 at 6:59 PM, Rameshswar Prasad Sahu <rsahu@apm.com> wrote:
> From: Rameshwar Prasad Sahu <rsahu@apm.com>
>
> The Arason SD host controller supports set block count command (cmd23)
> and high speed mode. This patch re-enable both of these features that
> was disabled. For device that doesn't support high speed, it should
> configure its capability register accordingly instead disables it
> explicitly.
>
> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
> ---
>  drivers/mmc/host/sdhci-of-arasan.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 75379cb..5d9fdb3 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>                 goto clk_disable_all;
>         }
>
> -       if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
> -               host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
> -               host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> -       }
> -
>         sdhci_get_of_property(pdev);
>         pltfm_host = sdhci_priv(host);
>         pltfm_host->priv = sdhci_arasan;
> --
> 1.7.1
>

Any comment on this patch ??
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1303228

Hi,

On 01/05/2016 07:25 PM, Rameshwar Sahu wrote:
> Hi Ulf,
> 
> On Wed, Dec 23, 2015 at 6:59 PM, Rameshswar Prasad Sahu <rsahu@apm.com> wrote:
>> From: Rameshwar Prasad Sahu <rsahu@apm.com>
>>
>> The Arason SD host controller supports set block count command (cmd23)
>> and high speed mode. This patch re-enable both of these features that
>> was disabled. For device that doesn't support high speed, it should
>> configure its capability register accordingly instead disables it
>> explicitly.
>>
>> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
>> ---
>>  drivers/mmc/host/sdhci-of-arasan.c |    5 -----
>>  1 files changed, 0 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index 75379cb..5d9fdb3 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>>                 goto clk_disable_all;
>>         }
>>
>> -       if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
>> -               host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
>> -               host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;

I'm not sure what's correct since i didn't have any information for arasan.
But in case of exynos, SDHCI_QUIRK_NO_HISPD_BIT is used because that bit is used as other purpose.
If your SoC is not used anymore, i think this patch looks good.

Best Regards,
Jaehoon Chung

>> -       }
>> -
>>         sdhci_get_of_property(pdev);
>>         pltfm_host = sdhci_priv(host);
>>         pltfm_host->priv = sdhci_arasan;
>> --
>> 1.7.1
>>
> 
> Any comment on this patch ??
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1303544

Hi Jaehoon,

On Thu, Jan 7, 2016 at 7:03 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi,
>
> On 01/05/2016 07:25 PM, Rameshwar Sahu wrote:
>> Hi Ulf,
>>
>> On Wed, Dec 23, 2015 at 6:59 PM, Rameshswar Prasad Sahu <rsahu@apm.com> wrote:
>>> From: Rameshwar Prasad Sahu <rsahu@apm.com>
>>>
>>> The Arason SD host controller supports set block count command (cmd23)
>>> and high speed mode. This patch re-enable both of these features that
>>> was disabled. For device that doesn't support high speed, it should
>>> configure its capability register accordingly instead disables it
>>> explicitly.
>>>
>>> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
>>> ---
>>>  drivers/mmc/host/sdhci-of-arasan.c |    5 -----
>>>  1 files changed, 0 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>>> index 75379cb..5d9fdb3 100644
>>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>>> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>>>                 goto clk_disable_all;
>>>         }
>>>
>>> -       if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
>>> -               host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
>>> -               host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
>
> I'm not sure what's correct since i didn't have any information for arasan.
> But in case of exynos, SDHCI_QUIRK_NO_HISPD_BIT is used because that bit is used as other purpose.
> If your SoC is not used anymore, i think this patch looks good.

Our SoC doesn't need that bit, that's why we are going to remove it.

>
> Best Regards,
> Jaehoon Chung
>
>>> -       }
>>> -
>>>         sdhci_get_of_property(pdev);
>>>         pltfm_host = sdhci_priv(host);
>>>         pltfm_host->priv = sdhci_arasan;
>>> --
>>> 1.7.1
>>>
>>
>> Any comment on this patch ??
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web