Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1302459 > unrolled thread

Re: [PATCH v3 1/4] mtd: spi-nor: fsl-quadspi: add big-endian support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 1/4] mtd: spi-nor: fsl-quadspi: add big-endian support Yao Yuan <yao.yuan@nxp.com> - 2016-01-06 09:30 +0100
    Re: [PATCH v3 1/4] mtd: spi-nor: fsl-quadspi: add big-endian support Brian Norris <computersforpeace@gmail.com> - 2016-01-07 00:10 +0100

#1302459 — Re: [PATCH v3 1/4] mtd: spi-nor: fsl-quadspi: add big-endian support

On Tue, Jan 05, 2015 at 04:58AM, Han Xu wrote:
> On Thu, Dec 24, 2015 at 07:00:18PM +0800, Yuan Yao wrote:
> > Add R/W functions for big- or little-endian registers:
> > The qSPI controller's endian is independent of the CPU core's endian.
> > So far, the qSPI have two versions for big-endian and little-endian.
> >
> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> > ---
> > Changed in v3:
> > Update my email to <yao.yuan@nxp.com>
> >
> > Changed in v2:
> > Rebase to the lastest code.
> > ---
> >  drivers/mtd/spi-nor/fsl-quadspi.c | 157 +++++++++++++++++++++++---------------
> >  1 file changed, 97 insertions(+), 60 deletions(-)
> >
> > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> > index 54640f1..04e8a93 100644
> > --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> > @@ -275,6 +275,7 @@ struct fsl_qspi {
> >       u32 clk_rate;
> >       unsigned int chip_base_addr; /* We may support two chips. */
> >       bool has_second_chip;
> > +     bool big_endian;
> >       struct mutex lock;
> >       struct pm_qos_request pm_qos_req;
> >  };
> > @@ -300,6 +301,28 @@ static inline int needs_wakeup_wait_mode(struct fsl_qspi *q)
> >  }
> >
> > 
> > @@ -954,6 +990,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
> >       if (IS_ERR(q->iobase))
> >               return PTR_ERR(q->iobase);
> >
> > +     q->big_endian = of_property_read_bool(np, "big-endian");

> once again, please document the new property.

Thanks for your review.
I have already send the patch named "Documentation: fsl-quadspi: Add optional properties" to community on Dec 24.
Sorry for forget to send this patch to you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1303122

On Wed, Jan 06, 2016 at 07:52:31AM +0000, Yao Yuan wrote:
> On Tue, Jan 05, 2015 at 04:58AM, Han Xu wrote:
> > once again, please document the new property.
> 
> Thanks for your review.
> I have already send the patch named "Documentation: fsl-quadspi: Add optional properties" to community on Dec 24.
> Sorry for forget to send this patch to you.

You also forgot to send it to anyone who could apply it. Like me, and
linux-mtd.

Please resend your series with all parties CC'd, after rereading
Documentation/devicetree/bindings/submitting-patches.txt.

Regards,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web