Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1301161 > unrolled thread
| Started by | David Miller <davem@davemloft.net> |
|---|---|
| First post | 2016-01-04 23:30 +0100 |
| Last post | 2016-01-05 22:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused David Miller <davem@davemloft.net> - 2016-01-04 23:30 +0100
[PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-01-05 10:20 +0100
Re: [PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused David Miller <davem@davemloft.net> - 2016-01-05 22:50 +0100
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-01-04 23:30 +0100 |
| Subject | Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused |
| Message-ID | <qNlNx-189-33@gated-at.bofh.it> |
From: Heinrich Schuchardt <xypron.glpk@gmx.de> Date: Tue, 29 Dec 2015 23:22:02 +0100 > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Please enhance your commit log message to include the analysis you provided in your reply to Michael Kerrisk. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| Date | 2016-01-05 10:20 +0100 |
| Subject | [PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused |
| Message-ID | <qNvWx-8rN-3@gated-at.bofh.it> |
| In reply to | #1301161 |
IOCTL SIOCRTMSG does nothing but return EINVAL. So comment it as unused. SIOCRTMSG is only used in: * net/ipv4/af_inet.c * include/uapi/linux/sockios.h inet_ioctl calls ip_rt_ioctl. ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL otherwise. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- include/uapi/linux/sockios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h index e888b1a..8e7890b 100644 --- a/include/uapi/linux/sockios.h +++ b/include/uapi/linux/sockios.h @@ -27,7 +27,7 @@ /* Routing table calls. */ #define SIOCADDRT 0x890B /* add routing table entry */ #define SIOCDELRT 0x890C /* delete routing table entry */ -#define SIOCRTMSG 0x890D /* call to routing system */ +#define SIOCRTMSG 0x890D /* unused */ /* Socket configuration controls. */ #define SIOCGIFNAME 0x8910 /* get iface name */ -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-01-05 22:50 +0100 |
| Subject | Re: [PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused |
| Message-ID | <qNHEm-cI-13@gated-at.bofh.it> |
| In reply to | #1301345 |
From: Heinrich Schuchardt <xypron.glpk@gmx.de> Date: Tue, 5 Jan 2016 10:12:49 +0100 > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. > > SIOCRTMSG is only used in: > * net/ipv4/af_inet.c > * include/uapi/linux/sockios.h > > inet_ioctl calls ip_rt_ioctl. > ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL > otherwise. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web