Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1300126 > unrolled thread

Re: [PATCH] DT: i2c: Update vendor prefix for 24c00

Started byWolfram Sang <wsa@the-dreams.de>
First post2016-01-02 22:30 +0100
Last post2016-01-06 10:00 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] DT: i2c: Update vendor prefix for 24c00 Wolfram Sang <wsa@the-dreams.de> - 2016-01-02 22:30 +0100
    Re: [PATCH] DT: i2c: Update vendor prefix for 24c00 Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-04 19:30 +0100
      Re: [PATCH] DT: i2c: Update vendor prefix for 24c00 Wolfram Sang <wsa@the-dreams.de> - 2016-01-06 10:00 +0100

#1300126 — Re: [PATCH] DT: i2c: Update vendor prefix for 24c00

FromWolfram Sang <wsa@the-dreams.de>
Date2016-01-02 22:30 +0100
SubjectRe: [PATCH] DT: i2c: Update vendor prefix for 24c00
Message-ID<qMBUm-4Rd-5@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> > "at" is not a valid vendor prefix, correcting the same to "atmel"
> >
> 
> I'm afraid you can't just do this change alone as it's used in some
> DTS. Though you may deprecated it along with update of current users.

Well, in Linux, I2C core currently strips the vendor anyhow. This will
probably be changed somewhen (tm), but for now, the impact for Linux
should be extremly close to 0.


> 
> > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > index c50cf13..c4a01c0 100644
> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > @@ -20,11 +20,11 @@ adi,adt7476         +/-1C TDM Extended Temp Range I.C
> >  adi,adt7490            +/-1C TDM Extended Temp Range I.C
> >  adi,adxl345            Three-Axis Digital Accelerometer
> >  adi,adxl346            Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
> > -at,24c08               i2c serial eeprom  (24cxx)
> >  atmel,24c00            i2c serial eeprom  (24cxx)
> >  atmel,24c01            i2c serial eeprom  (24cxx)
> >  atmel,24c02            i2c serial eeprom  (24cxx)
> >  atmel,24c04            i2c serial eeprom  (24cxx)
> > +atmel,24c08            i2c serial eeprom  (24cxx)
> >  atmel,24c16            i2c serial eeprom  (24cxx)
> >  atmel,24c32            i2c serial eeprom  (24cxx)
> >  atmel,24c64            i2c serial eeprom  (24cxx)
> > --
> > 2.6.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko

[toc] | [next] | [standalone]


#1300935

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2016-01-04 19:30 +0100
Message-ID<qNi3g-76n-13@gated-at.bofh.it>
In reply to#1300126
On Sat, Jan 2, 2016 at 11:21 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote:
>> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
>> > "at" is not a valid vendor prefix, correcting the same to "atmel"
>> >
>>
>> I'm afraid you can't just do this change alone as it's used in some
>> DTS. Though you may deprecated it along with update of current users.
>
> Well, in Linux, I2C core currently strips the vendor anyhow. This will
> probably be changed somewhen (tm), but for now, the impact for Linux
> should be extremly close to 0.

Okay, no objections to the original patch then.

>
>
>>
>> > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
>> > ---
>> >  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > index c50cf13..c4a01c0 100644
>> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > @@ -20,11 +20,11 @@ adi,adt7476         +/-1C TDM Extended Temp Range I.C
>> >  adi,adt7490            +/-1C TDM Extended Temp Range I.C
>> >  adi,adxl345            Three-Axis Digital Accelerometer
>> >  adi,adxl346            Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
>> > -at,24c08               i2c serial eeprom  (24cxx)
>> >  atmel,24c00            i2c serial eeprom  (24cxx)
>> >  atmel,24c01            i2c serial eeprom  (24cxx)
>> >  atmel,24c02            i2c serial eeprom  (24cxx)
>> >  atmel,24c04            i2c serial eeprom  (24cxx)
>> > +atmel,24c08            i2c serial eeprom  (24cxx)
>> >  atmel,24c16            i2c serial eeprom  (24cxx)
>> >  atmel,24c32            i2c serial eeprom  (24cxx)
>> >  atmel,24c64            i2c serial eeprom  (24cxx)
>> > --
>> > 2.6.3
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> > Please read the FAQ at  http://www.tux.org/lkml/
>>
>>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1302481

FromWolfram Sang <wsa@the-dreams.de>
Date2016-01-06 10:00 +0100
Message-ID<qNS6K-7dw-9@gated-at.bofh.it>
In reply to#1300935

[Multipart message — attachments visible in raw view] — view raw

On Mon, Jan 04, 2016 at 08:22:33PM +0200, Andy Shevchenko wrote:
> On Sat, Jan 2, 2016 at 11:21 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote:
> >> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> >> > "at" is not a valid vendor prefix, correcting the same to "atmel"
> >> >
> >>
> >> I'm afraid you can't just do this change alone as it's used in some
> >> DTS. Though you may deprecated it along with update of current users.
> >
> > Well, in Linux, I2C core currently strips the vendor anyhow. This will
> > probably be changed somewhen (tm), but for now, the impact for Linux
> > should be extremly close to 0.
> 
> Okay, no objections to the original patch then.

Heh, I just go reminded that eeproms already have a seperate binding
description (Documentation/devicetree/bindings/eeprom/eeprom.txt).

I will update the eeprom bindings and remove the entries from trivial
devices.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web