Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1302808 > unrolled thread
| Started by | Liang Chen <liangchen.linux@gmail.com> |
|---|---|
| First post | 2016-01-06 15:30 +0100 |
| Last post | 2016-01-06 16:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mm: mempolicy: skip non-migratable VMAs when setting MPOL_MF_LAZY Liang Chen <liangchen.linux@gmail.com> - 2016-01-06 15:30 +0100
Re: [PATCH] mm: mempolicy: skip non-migratable VMAs when setting MPOL_MF_LAZY Rik van Riel <riel@redhat.com> - 2016-01-06 16:40 +0100
| From | Liang Chen <liangchen.linux@gmail.com> |
|---|---|
| Date | 2016-01-06 15:30 +0100 |
| Subject | [PATCH] mm: mempolicy: skip non-migratable VMAs when setting MPOL_MF_LAZY |
| Message-ID | <qNXg6-2iB-11@gated-at.bofh.it> |
MPOL_MF_LAZY is not visible from userspace since 'commit a720094ded8c
("mm: mempolicy: Hide MPOL_NOOP and MPOL_MF_LAZY from userspace for now")'
, but it should still skip non-migratable VMAs.
Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
Signed-off-by: Gavin Guo <gavin.guo@canonical.com>
---
We have been evaluating the enablement of MPOL_MF_LAZY again, and found
this issue. And we decided to push this patch upstream no matter if we
finally determine to propose re-enablement of MPOL_MF_LAZY or not. Since
it can be a potential problem even if MPOL_MF_LAZY is not enabled this
time.
mm/mempolicy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 87a1779..436ff411 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -610,7 +610,8 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
if (flags & MPOL_MF_LAZY) {
/* Similar to task_numa_work, skip inaccessible VMAs */
- if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
+ if (vma_migratable(vma) &&
+ vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
change_prot_numa(vma, start, endvma);
return 1;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Rik van Riel <riel@redhat.com> |
|---|---|
| Date | 2016-01-06 16:40 +0100 |
| Subject | Re: [PATCH] mm: mempolicy: skip non-migratable VMAs when setting MPOL_MF_LAZY |
| Message-ID | <qNYlQ-326-31@gated-at.bofh.it> |
| In reply to | #1302808 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 01/06/2016 09:18 AM, Liang Chen wrote:
> MPOL_MF_LAZY is not visible from userspace since 'commit
> a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and MPOL_MF_LAZY from
> userspace for now")' , but it should still skip non-migratable
> VMAs.
The changelog could use a better description of exactly
what the issue is, and why calling change_prot_numa
on a non-migratable VMA is causing problems.
> Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
> Signed-off-by: Gavin Guo <gavin.guo@canonical.com>
For the code itself:
Acked-by: Rik van Riel <riel@redhat.com>
Please resubmit with a better changelog.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJWjTPwAAoJEM553pKExN6DCncIAKYtabnc7WjsI8/yzc0/qqYR
s92KJjztJ2RiaMhioa6xO1aGh9c00oszHvbZfFlYFJVWn/MsGB83eVQ0KymYLOdx
VyYP59Oe0oWvZagF4bvj7KEZVF35GFuUGOekLfbYihUw6VTgPE38cwAx9stIBTyf
CBm5XT0WdPLWaJrxYl5aJlbdQiJ7BKxQIBx7yyLV8tAgw0KVwEmPpgfftjAI1oIq
ItdrGDIqtOvb6vCc/5DJHT7+6b0ObwcpWWm4rE7QAc7OxyUUXbQydt/OKYXMhbUR
j6wcfHutHW2dcZko5iln7oN9DvBlYnXVSmSa4WJxgavtbL0abTaJGpJLE61pWQQ=
=sCoV
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web