Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301030 > unrolled thread

Re: [PATCH v3 0/4] um: Add seccomp support

Started byKees Cook <keescook@chromium.org>
First post2016-01-04 21:20 +0100
Last post2016-01-06 15:20 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 0/4] um: Add seccomp support Kees Cook <keescook@chromium.org> - 2016-01-04 21:20 +0100
    Re: [PATCH v3 0/4] um: Add seccomp support David Drysdale <drysdale@google.com> - 2016-01-06 15:20 +0100
      Re: [PATCH v3 0/4] um: Add seccomp support Richard Weinberger <richard@nod.at> - 2016-01-06 15:20 +0100

#1301030 — Re: [PATCH v3 0/4] um: Add seccomp support

FromKees Cook <keescook@chromium.org>
Date2016-01-04 21:20 +0100
SubjectRe: [PATCH v3 0/4] um: Add seccomp support
Message-ID<qNjLJ-8i4-19@gated-at.bofh.it>
On Tue, Dec 29, 2015 at 12:35 PM, Mickaël Salaün <mic@digikod.net> wrote:
> This series add seccomp support to User-mode Linux (i386 and x86_64
> subarchitectures) and fix ptrace issues. This apply on v4.4-rc7 and pass all
> the 48 tests from selftest/seccomp plus the UML ptsc test.
>
> Changes since v2:
> * remove get_syscall() from os.h and don't include it in syscall.c [1/4]
> * rebase to v4.4-rc7
>
> Changes since v1; addressed Richard Weinberger's comments:
> * fix a new PTRACE_SETREGS bug on x86_64 [1/4]
> * fix an old PTRACE_SETREGS bug when updating orig_ax on i386 [1/4]

Thanks for working on this!

Acked-by: Kees Cook <keescook@chromium.org>

Feel free to pull this through the uml tree.

Thanks!

-Kees

>
> Regards,
>  Mickaël
>
> Mickaël Salaün (4):
>   um: Fix ptrace GETREGS/SETREGS bugs
>   selftests/seccomp: Remove the need for HAVE_ARCH_TRACEHOOK
>   um: Add full asm/syscall.h support
>   um: Add seccomp support
>
>  .../seccomp/seccomp-filter/arch-support.txt        |   2 +-
>  arch/um/Kconfig.common                             |   1 +
>  arch/um/Kconfig.um                                 |  16 +++
>  arch/um/include/asm/syscall-generic.h              | 138 +++++++++++++++++++++
>  arch/um/include/asm/thread_info.h                  |   2 +
>  arch/um/include/shared/os.h                        |   1 -
>  arch/um/kernel/skas/syscall.c                      |  31 +++--
>  arch/um/os-Linux/skas/process.c                    |   7 --
>  arch/x86/um/asm/syscall.h                          |   1 +
>  arch/x86/um/ptrace_32.c                            |   8 +-
>  tools/testing/selftests/seccomp/seccomp_bpf.c      |  27 +++-
>  11 files changed, 205 insertions(+), 29 deletions(-)
>  create mode 100644 arch/um/include/asm/syscall-generic.h
>
> --
> 2.6.4
>



-- 
Kees Cook
Chrome OS & Brillo Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1302801

FromDavid Drysdale <drysdale@google.com>
Date2016-01-06 15:20 +0100
Message-ID<qNX6q-2fc-13@gated-at.bofh.it>
In reply to#1301030
On Mon, Jan 4, 2016 at 8:13 PM, Kees Cook <keescook@chromium.org> wrote:
> On Tue, Dec 29, 2015 at 12:35 PM, Mickaël Salaün <mic@digikod.net> wrote:
>> This series add seccomp support to User-mode Linux (i386 and x86_64
>> subarchitectures) and fix ptrace issues. This apply on v4.4-rc7 and pass all
>> the 48 tests from selftest/seccomp plus the UML ptsc test.
>>
>> Changes since v2:
>> * remove get_syscall() from os.h and don't include it in syscall.c [1/4]
>> * rebase to v4.4-rc7
>>
>> Changes since v1; addressed Richard Weinberger's comments:
>> * fix a new PTRACE_SETREGS bug on x86_64 [1/4]
>> * fix an old PTRACE_SETREGS bug when updating orig_ax on i386 [1/4]
>
> Thanks for working on this!
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> Feel free to pull this through the uml tree.
>
> Thanks!
>
> -Kees

I also had a version of Meredydd Luff's original patch in my local tree so I
could do UML testing of Capsicum (which uses seccomp for some of its
userspace implementation).  I've replaced my patch with this version, as
it's much more complete, and all my tests still work.  Which I guess is
kind of:

Tested-by: David Drysdale <drysdale@google.com>

Many thanks,
David

>>
>> Regards,
>>  Mickaël
>>
>> Mickaël Salaün (4):
>>   um: Fix ptrace GETREGS/SETREGS bugs
>>   selftests/seccomp: Remove the need for HAVE_ARCH_TRACEHOOK
>>   um: Add full asm/syscall.h support
>>   um: Add seccomp support
>>
>>  .../seccomp/seccomp-filter/arch-support.txt        |   2 +-
>>  arch/um/Kconfig.common                             |   1 +
>>  arch/um/Kconfig.um                                 |  16 +++
>>  arch/um/include/asm/syscall-generic.h              | 138 +++++++++++++++++++++
>>  arch/um/include/asm/thread_info.h                  |   2 +
>>  arch/um/include/shared/os.h                        |   1 -
>>  arch/um/kernel/skas/syscall.c                      |  31 +++--
>>  arch/um/os-Linux/skas/process.c                    |   7 --
>>  arch/x86/um/asm/syscall.h                          |   1 +
>>  arch/x86/um/ptrace_32.c                            |   8 +-
>>  tools/testing/selftests/seccomp/seccomp_bpf.c      |  27 +++-
>>  11 files changed, 205 insertions(+), 29 deletions(-)
>>  create mode 100644 arch/um/include/asm/syscall-generic.h
>>
>> --
>> 2.6.4
>>
>
>
>
> --
> Kees Cook
> Chrome OS & Brillo Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1302802

FromRichard Weinberger <richard@nod.at>
Date2016-01-06 15:20 +0100
Message-ID<qNX6q-2fc-19@gated-at.bofh.it>
In reply to#1302801
Am 06.01.2016 um 15:15 schrieb David Drysdale:
> On Mon, Jan 4, 2016 at 8:13 PM, Kees Cook <keescook@chromium.org> wrote:
>> On Tue, Dec 29, 2015 at 12:35 PM, Mickaël Salaün <mic@digikod.net> wrote:
>>> This series add seccomp support to User-mode Linux (i386 and x86_64
>>> subarchitectures) and fix ptrace issues. This apply on v4.4-rc7 and pass all
>>> the 48 tests from selftest/seccomp plus the UML ptsc test.
>>>
>>> Changes since v2:
>>> * remove get_syscall() from os.h and don't include it in syscall.c [1/4]
>>> * rebase to v4.4-rc7
>>>
>>> Changes since v1; addressed Richard Weinberger's comments:
>>> * fix a new PTRACE_SETREGS bug on x86_64 [1/4]
>>> * fix an old PTRACE_SETREGS bug when updating orig_ax on i386 [1/4]
>>
>> Thanks for working on this!
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
>>
>> Feel free to pull this through the uml tree.
>>
>> Thanks!
>>
>> -Kees
> 
> I also had a version of Meredydd Luff's original patch in my local tree so I
> could do UML testing of Capsicum (which uses seccomp for some of its
> userspace implementation).  I've replaced my patch with this version, as
> it's much more complete, and all my tests still work.  Which I guess is
> kind of:
> 
> Tested-by: David Drysdale <drysdale@google.com>

Thank you guys!
I'm queuing this for 4.5.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web