Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1302325 > unrolled thread

Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI Mark yao <mark.yao@rock-chips.com> - 2016-01-06 02:50 +0100
    Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI Chris Zhong <zyw@rock-chips.com> - 2016-01-06 11:10 +0100

#1302325 — Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI

On 2015年12月23日 11:43, Chris Zhong wrote:
> +static int dw_mipi_dsi_register(struct drm_device *drm,
> +				      struct dw_mipi_dsi *dsi)
> +{
> +	struct drm_encoder *encoder = &dsi->encoder;
> +	struct drm_connector *connector = &dsi->connector;
> +	struct device *dev = dsi->dev;
> +	int ret;
> +
> +	encoder->possible_crtcs = drm_of_find_possible_crtcs(drm,
> +							     dev->of_node);
> +	/*
> +	 * If we failed to find the CRTC(s) which this encoder is
> +	 * supposed to be connected to, it's because the CRTC has
> +	 * not been registered yet.  Defer probing, and hope that
> +	 * the required CRTC is added later.
> +	 */
> +	if (encoder->possible_crtcs == 0)
> +		return -EPROBE_DEFER;
> +
> +	drm_encoder_helper_add(&dsi->encoder,
> +			       &dw_mipi_dsi_encoder_helper_funcs);
> +	ret = drm_encoder_init(drm, &dsi->encoder, &dw_mipi_dsi_encoder_funcs,
> +			 DRM_MODE_ENCODER_DSI);
> +	if (ret) {
> +		dev_err(dev, "Failed to initialize encoder with drm\n");
> +		return ret;
> +	}
> +
> +	drm_connector_helper_add(connector,
> +			&dw_mipi_dsi_connector_helper_funcs);
> +
> +	drm_connector_init(drm, &dsi->connector,
> +			   &dw_mipi_dsi_atomic_connector_funcs,
> +			   DRM_MODE_CONNECTOR_DSI);
> +
Hi Chris

I try to pick your patches, but found following issues:

drivers/gpu/drm/rockchip/dw-mipi-dsi.c: 在函数‘dw_mipi_dsi_register’中:
drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: 错误： 提供给函数 
‘drm_encoder_init’的实参太少
include/drm/drm_crtc.h:2220:5: 附注： 在此声明
make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] 错误 1

Can you rebase to newest Dave's drm-next and fix this problem?

Thanks.

-- 
Ｍark Yao


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1302516

Hi Mark


On 01/06/2016 09:48 AM, Mark yao wrote:
> On 2015年12月23日 11:43, Chris Zhong wrote:
>> +static int dw_mipi_dsi_register(struct drm_device *drm,
>> +                      struct dw_mipi_dsi *dsi)
>> +{
>> +    struct drm_encoder *encoder = &dsi->encoder;
>> +    struct drm_connector *connector = &dsi->connector;
>> +    struct device *dev = dsi->dev;
>> +    int ret;
>> +
>> +    encoder->possible_crtcs = drm_of_find_possible_crtcs(drm,
>> +                                 dev->of_node);
>> +    /*
>> +     * If we failed to find the CRTC(s) which this encoder is
>> +     * supposed to be connected to, it's because the CRTC has
>> +     * not been registered yet.  Defer probing, and hope that
>> +     * the required CRTC is added later.
>> +     */
>> +    if (encoder->possible_crtcs == 0)
>> +        return -EPROBE_DEFER;
>> +
>> +    drm_encoder_helper_add(&dsi->encoder,
>> +                   &dw_mipi_dsi_encoder_helper_funcs);
>> +    ret = drm_encoder_init(drm, &dsi->encoder, 
>> &dw_mipi_dsi_encoder_funcs,
>> +             DRM_MODE_ENCODER_DSI);
>> +    if (ret) {
>> +        dev_err(dev, "Failed to initialize encoder with drm\n");
>> +        return ret;
>> +    }
>> +
>> +    drm_connector_helper_add(connector,
>> +            &dw_mipi_dsi_connector_helper_funcs);
>> +
>> +    drm_connector_init(drm, &dsi->connector,
>> +               &dw_mipi_dsi_atomic_connector_funcs,
>> +               DRM_MODE_CONNECTOR_DSI);
>> +
> Hi Chris
>
> I try to pick your patches, but found following issues:
>
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c: 在函数‘dw_mipi_dsi_register’中:
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: 错误： 提供给函数 
> ‘drm_encoder_init’的实参太少
> include/drm/drm_crtc.h:2220:5: 附注： 在此声明
> make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] 错误 1
>
> Can you rebase to newest Dave's drm-next and fix this problem?
Thanks Mark.
I have post the v7 serial, fix this this compile err and modify the 
config to tristate for modules build
>
> Thanks.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web