Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1300893 > unrolled thread
| Started by | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| First post | 2016-01-04 18:10 +0100 |
| Last post | 2016-01-06 10:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: emux: constify nrpn_conv_table structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-01-04 18:10 +0100
Re: [PATCH] ALSA: emux: constify nrpn_conv_table structures Takashi Iwai <tiwai@suse.de> - 2016-01-06 10:30 +0100
| From | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| Date | 2016-01-04 18:10 +0100 |
| Subject | [PATCH] ALSA: emux: constify nrpn_conv_table structures |
| Message-ID | <qNgNR-6jM-19@gated-at.bofh.it> |
The nrpn_conv_table structures are never modified, so declare them as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/synth/emux/emux_nrpn.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/sound/synth/emux/emux_nrpn.c b/sound/synth/emux/emux_nrpn.c
index 00fc005..9729a15 100644
--- a/sound/synth/emux/emux_nrpn.c
+++ b/sound/synth/emux/emux_nrpn.c
@@ -48,7 +48,8 @@ struct nrpn_conv_table {
* convert NRPN/control values
*/
-static int send_converted_effect(struct nrpn_conv_table *table, int num_tables,
+static int send_converted_effect(const struct nrpn_conv_table *table,
+ int num_tables,
struct snd_emux_port *port,
struct snd_midi_channel *chan,
int type, int val, int mode)
@@ -179,7 +180,7 @@ static int fx_conv_Q(int val)
}
-static struct nrpn_conv_table awe_effects[] =
+static const struct nrpn_conv_table awe_effects[] =
{
{ 0, EMUX_FX_LFO1_DELAY, fx_lfo1_delay},
{ 1, EMUX_FX_LFO1_FREQ, fx_lfo1_freq},
@@ -266,7 +267,7 @@ static int gs_vib_delay(int val)
return -(val - 64) * gs_sense[FX_VIBDELAY] / 50;
}
-static struct nrpn_conv_table gs_effects[] =
+static const struct nrpn_conv_table gs_effects[] =
{
{32, EMUX_FX_CUTOFF, gs_cutoff},
{33, EMUX_FX_FILTERQ, gs_filterQ},
@@ -350,7 +351,7 @@ static int xg_release(int val)
return -(val - 64) * xg_sense[FX_RELEASE] / 64;
}
-static struct nrpn_conv_table xg_effects[] =
+static const struct nrpn_conv_table xg_effects[] =
{
{71, EMUX_FX_CUTOFF, xg_cutoff},
{74, EMUX_FX_FILTERQ, xg_filterQ},
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2016-01-06 10:30 +0100 |
| Message-ID | <qNSzM-7E8-7@gated-at.bofh.it> |
| In reply to | #1300893 |
On Mon, 04 Jan 2016 17:50:47 +0100,
Julia Lawall wrote:
>
> The nrpn_conv_table structures are never modified, so declare them as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks, applied.
Takashi
>
> ---
> sound/synth/emux/emux_nrpn.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/sound/synth/emux/emux_nrpn.c b/sound/synth/emux/emux_nrpn.c
> index 00fc005..9729a15 100644
> --- a/sound/synth/emux/emux_nrpn.c
> +++ b/sound/synth/emux/emux_nrpn.c
> @@ -48,7 +48,8 @@ struct nrpn_conv_table {
> * convert NRPN/control values
> */
>
> -static int send_converted_effect(struct nrpn_conv_table *table, int num_tables,
> +static int send_converted_effect(const struct nrpn_conv_table *table,
> + int num_tables,
> struct snd_emux_port *port,
> struct snd_midi_channel *chan,
> int type, int val, int mode)
> @@ -179,7 +180,7 @@ static int fx_conv_Q(int val)
> }
>
>
> -static struct nrpn_conv_table awe_effects[] =
> +static const struct nrpn_conv_table awe_effects[] =
> {
> { 0, EMUX_FX_LFO1_DELAY, fx_lfo1_delay},
> { 1, EMUX_FX_LFO1_FREQ, fx_lfo1_freq},
> @@ -266,7 +267,7 @@ static int gs_vib_delay(int val)
> return -(val - 64) * gs_sense[FX_VIBDELAY] / 50;
> }
>
> -static struct nrpn_conv_table gs_effects[] =
> +static const struct nrpn_conv_table gs_effects[] =
> {
> {32, EMUX_FX_CUTOFF, gs_cutoff},
> {33, EMUX_FX_FILTERQ, gs_filterQ},
> @@ -350,7 +351,7 @@ static int xg_release(int val)
> return -(val - 64) * xg_sense[FX_RELEASE] / 64;
> }
>
> -static struct nrpn_conv_table xg_effects[] =
> +static const struct nrpn_conv_table xg_effects[] =
> {
> {71, EMUX_FX_CUTOFF, xg_cutoff},
> {74, EMUX_FX_FILTERQ, xg_filterQ},
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web