Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301235 > unrolled thread

Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions  (aliased with Winbond) Brian Norris <computersforpeace@gmail.com> - 2016-01-05 03:30 +0100
    Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions  (aliased with Winbond) Felix Fietkau <nbd@openwrt.org> - 2016-01-06 01:10 +0100
      Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions  (aliased with Winbond) bayi cheng <bayi.cheng@mediatek.com> - 2016-01-06 03:10 +0100
    Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions  (aliased with Winbond) Brian Norris <computersforpeace@gmail.com> - 2016-01-06 01:10 +0100

#1301235 — Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

On Tue, Dec 15, 2015 at 10:48:20AM -0800, Brian Norris wrote:
> Spansion and Winbond have occasionally used the same manufacturer ID,
> and they don't support the same features. Particularly, writing SR=0
> seems to break read access for Spansion's s25fl064k. Unfortunately, we
> don't currently have a way to differentiate these Spansion and Winbond
> parts, so rather than regressing support for these Spansion flash, let's
> drop the new Winbond lock/unlock support for now. We can try to address
> Winbond support during the next release cycle.
> 
> Original discussion:
> 
> http://patchwork.ozlabs.org/patch/549173/
> http://patchwork.ozlabs.org/patch/553683/
> 
> Fixes: 357ca38d4751 ("mtd: spi-nor: support lock/unlock/is_locked for Winbond")
> Fixes: c6fc2171b249 ("mtd: spi-nor: disable protection for Winbond flash at startup")
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Reported-by: Felix Fietkau <nbd@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>

Felix,

Can I get a Tested-by? I'm going to send this for 4.4 still, if
possible.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1302282

On 2016-01-06 01:02, Brian Norris wrote:
> On Mon, Jan 04, 2016 at 06:29:28PM -0800, Brian Norris wrote:
>> On Tue, Dec 15, 2015 at 10:48:20AM -0800, Brian Norris wrote:
>> > Spansion and Winbond have occasionally used the same manufacturer ID,
>> > and they don't support the same features. Particularly, writing SR=0
>> > seems to break read access for Spansion's s25fl064k. Unfortunately, we
>> > don't currently have a way to differentiate these Spansion and Winbond
>> > parts, so rather than regressing support for these Spansion flash, let's
>> > drop the new Winbond lock/unlock support for now. We can try to address
>> > Winbond support during the next release cycle.
>> > 
>> > Original discussion:
>> > 
>> > http://patchwork.ozlabs.org/patch/549173/
>> > http://patchwork.ozlabs.org/patch/553683/
>> > 
>> > Fixes: 357ca38d4751 ("mtd: spi-nor: support lock/unlock/is_locked for Winbond")
>> > Fixes: c6fc2171b249 ("mtd: spi-nor: disable protection for Winbond flash at startup")
>> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>> > Reported-by: Felix Fietkau <nbd@openwrt.org>
>> > Cc: Felix Fietkau <nbd@openwrt.org>
>> 
>> Felix,
>> 
>> Can I get a Tested-by? I'm going to send this for 4.4 still, if
>> possible.
> 
> Despite the lack of response, pushed both to linux-mtd.git, as they are
> obvious responses to the reported regressions/bugs.
Sorry for the delay, I don't have time to test that at the moment. I'll
try to find the time for it soon.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1302336

On Wed, 2016-01-06 at 01:03 +0100, Felix Fietkau wrote:
> On 2016-01-06 01:02, Brian Norris wrote:
> > On Mon, Jan 04, 2016 at 06:29:28PM -0800, Brian Norris wrote:
> >> On Tue, Dec 15, 2015 at 10:48:20AM -0800, Brian Norris wrote:
> >> > Spansion and Winbond have occasionally used the same manufacturer ID,
> >> > and they don't support the same features. Particularly, writing SR=0
> >> > seems to break read access for Spansion's s25fl064k. Unfortunately, we
> >> > don't currently have a way to differentiate these Spansion and Winbond
> >> > parts, so rather than regressing support for these Spansion flash, let's
> >> > drop the new Winbond lock/unlock support for now. We can try to address
> >> > Winbond support during the next release cycle.
> >> > 
> >> > Original discussion:
> >> > 
> >> > http://patchwork.ozlabs.org/patch/549173/
> >> > http://patchwork.ozlabs.org/patch/553683/
> >> > 
> >> > Fixes: 357ca38d4751 ("mtd: spi-nor: support lock/unlock/is_locked for Winbond")
> >> > Fixes: c6fc2171b249 ("mtd: spi-nor: disable protection for Winbond flash at startup")
> >> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> >> > Reported-by: Felix Fietkau <nbd@openwrt.org>
> >> > Cc: Felix Fietkau <nbd@openwrt.org>
> >> 
> >> Felix,
> >> 
> >> Can I get a Tested-by? I'm going to send this for 4.4 still, if
> >> possible.
> > 
> > Despite the lack of response, pushed both to linux-mtd.git, as they are
> > obvious responses to the reported regressions/bugs.
> Sorry for the delay, I don't have time to test that at the moment. I'll
> try to find the time for it soon.
> 
> - Felix

Hi Brain, Sorry for later reply, I have tested these patches. it works
ok on oak-rev4. Although it does not support WP operation for Winbond
nor flash.

Bayi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1302285

On Mon, Jan 04, 2016 at 06:29:28PM -0800, Brian Norris wrote:
> On Tue, Dec 15, 2015 at 10:48:20AM -0800, Brian Norris wrote:
> > Spansion and Winbond have occasionally used the same manufacturer ID,
> > and they don't support the same features. Particularly, writing SR=0
> > seems to break read access for Spansion's s25fl064k. Unfortunately, we
> > don't currently have a way to differentiate these Spansion and Winbond
> > parts, so rather than regressing support for these Spansion flash, let's
> > drop the new Winbond lock/unlock support for now. We can try to address
> > Winbond support during the next release cycle.
> > 
> > Original discussion:
> > 
> > http://patchwork.ozlabs.org/patch/549173/
> > http://patchwork.ozlabs.org/patch/553683/
> > 
> > Fixes: 357ca38d4751 ("mtd: spi-nor: support lock/unlock/is_locked for Winbond")
> > Fixes: c6fc2171b249 ("mtd: spi-nor: disable protection for Winbond flash at startup")
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Reported-by: Felix Fietkau <nbd@openwrt.org>
> > Cc: Felix Fietkau <nbd@openwrt.org>
> 
> Felix,
> 
> Can I get a Tested-by? I'm going to send this for 4.4 still, if
> possible.

Despite the lack of response, pushed both to linux-mtd.git, as they are
obvious responses to the reported regressions/bugs.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web