Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1301527 > unrolled thread
| Started by | "João Paulo Rechi Vita" <jprvita@gmail.com> |
|---|---|
| First post | 2016-01-05 14:30 +0100 |
| Last post | 2016-01-05 18:20 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] Asus Wireless Radio Control driver "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-01-05 14:30 +0100
Re: [PATCH 0/2] Asus Wireless Radio Control driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-05 15:00 +0100
Re: [PATCH 0/2] Asus Wireless Radio Control driver João Paulo Rechi Vita <jprvita@gmail.com> - 2016-01-05 17:20 +0100
Re: [PATCH 0/2] Asus Wireless Radio Control driver Darren Hart <dvhart@infradead.org> - 2016-01-05 18:20 +0100
| From | "João Paulo Rechi Vita" <jprvita@gmail.com> |
|---|---|
| Date | 2016-01-05 14:30 +0100 |
| Subject | [PATCH 0/2] Asus Wireless Radio Control driver |
| Message-ID | <qNzQu-3l3-13@gated-at.bofh.it> |
This series implements the driver for the "Asus Wireless Radio Control" device, as named on the vendor website, which handles notifications from the airplane mode hotkey and drives the airplane mode indicator LED. This device appears in the DSDT as "ASHS". I decided to split the series and move the commits that drive the LED to a separate series, so this part can be merged without waiting for feedback on the new airplane mode RFKill LED trigger. Regards, Joao Paulo João Paulo Rechi Vita (2): platform/x86: Add Asus Wireless Radio Control driver asus-wireless: Add ACPI HID ATK4001 MAINTAINERS | 6 +++ drivers/platform/x86/Kconfig | 15 +++++++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/asus-wireless.c | 84 ++++++++++++++++++++++++++++++++++++ 4 files changed, 106 insertions(+) create mode 100644 drivers/platform/x86/asus-wireless.c -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2016-01-05 15:00 +0100 |
| Message-ID | <qNAjx-3vz-19@gated-at.bofh.it> |
| In reply to | #1301527 |
On Tue, Jan 5, 2016 at 3:25 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote: > This series implements the driver for the "Asus Wireless Radio Control" device, > as named on the vendor website, which handles notifications from the airplane > mode hotkey and drives the airplane mode indicator LED. This device appears in > the DSDT as "ASHS". > > I decided to split the series and move the commits that drive the LED to a > separate series, so this part can be merged without waiting for feedback on the > new airplane mode RFKill LED trigger. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> (I'm fine with current version but please take into consideration comments to the first patch, most important 'default m' thing) > > Regards, > > Joao Paulo > > João Paulo Rechi Vita (2): > platform/x86: Add Asus Wireless Radio Control driver > asus-wireless: Add ACPI HID ATK4001 > > MAINTAINERS | 6 +++ > drivers/platform/x86/Kconfig | 15 +++++++ > drivers/platform/x86/Makefile | 1 + > drivers/platform/x86/asus-wireless.c | 84 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 106 insertions(+) > create mode 100644 drivers/platform/x86/asus-wireless.c > > -- > 2.5.0 > -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | João Paulo Rechi Vita <jprvita@gmail.com> |
|---|---|
| Date | 2016-01-05 17:20 +0100 |
| Message-ID | <qNCv1-5eI-27@gated-at.bofh.it> |
| In reply to | #1301546 |
On 5 January 2016 at 08:58, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Tue, Jan 5, 2016 at 3:25 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote: >> This series implements the driver for the "Asus Wireless Radio Control" device, >> as named on the vendor website, which handles notifications from the airplane >> mode hotkey and drives the airplane mode indicator LED. This device appears in >> the DSDT as "ASHS". >> >> I decided to split the series and move the commits that drive the LED to a >> separate series, so this part can be merged without waiting for feedback on the >> new airplane mode RFKill LED trigger. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > (I'm fine with current version but please take into consideration > comments to the first patch, most important 'default m' thing) > I wasn't really sure about the "default m", so I've followed your suggestions and just sent an updated patch in reply to that one. Thanks for your review, it certainly made the code a lot better. -- João Paulo Rechi Vita http://about.me/jprvita -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2016-01-05 18:20 +0100 |
| Message-ID | <qNDr4-5S2-9@gated-at.bofh.it> |
| In reply to | #1301546 |
On Tue, Jan 05, 2016 at 03:58:46PM +0200, Andy Shevchenko wrote: > On Tue, Jan 5, 2016 at 3:25 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote: > > This series implements the driver for the "Asus Wireless Radio Control" device, > > as named on the vendor website, which handles notifications from the airplane > > mode hotkey and drives the airplane mode indicator LED. This device appears in > > the DSDT as "ASHS". > > > > I decided to split the series and move the commits that drive the LED to a > > separate series, so this part can be merged without waiting for feedback on the > > new airplane mode RFKill LED trigger. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > (I'm fine with current version but please take into consideration > comments to the first patch, most important 'default m' thing) Agreed on the 'default m' thing. Thank you for the review Andy. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web