Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300545 > unrolled thread

Re: [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Thierry Reding <thierry.reding@gmail.com> - 2016-01-04 09:30 +0100

#1300545 — Re: [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM

[Multipart message — attachments visible in raw view] — view raw

On Fri, Jan 01, 2016 at 03:39:17PM +0100, Arnd Bergmann wrote:
> The hdlcd_pm_suspend and hdlcd_pm_resume are intentionally unused
> when CONFIG_PM is not set in this driver, and we get a compiler warning
> for this:
> 
> drivers/gpu/drm/arm/hdlcd_drv.c:521:12: warning: 'hdlcd_pm_suspend' defined but not used [-Wunused-function]
> drivers/gpu/drm/arm/hdlcd_drv.c:536:12: warning: 'hdlcd_pm_resume' defined but not used [-Wunused-function]
> 
> This adds a __maybe_unused annotation for the two functions, to let
> the compiler know this is the intended behavior. This is better than
> an #ifdef as it improves the compile time coverage of the code and it
> looks nicer.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Thierry Reding <treding@nvidia.com>

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web