Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1300014 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-01-02 01:00 +0100 |
| Last post | 2016-01-05 13:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ACPI / SBS: fix inconsistent indenting inside if statement Colin King <colin.king@canonical.com> - 2016-01-02 01:00 +0100
Re: [PATCH] ACPI / SBS: fix inconsistent indenting inside if statement "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-05 13:30 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-01-02 01:00 +0100 |
| Subject | [PATCH] ACPI / SBS: fix inconsistent indenting inside if statement |
| Message-ID | <qMhLX-B4-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The indenting in acpi_battery_set_alarm is inconsistent and has been
so since 2007; commit 94f6c0860139da9219255b8ff45ad42117dda859
("ACPI: SBS: Add support for power_supply class (and sysfs)"). Minor
fix for this, no code functionality change.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/acpi/sbs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index cb3dedb..ad0b13a 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -417,11 +417,11 @@ static int acpi_battery_set_alarm(struct acpi_battery *battery)
if ((value & 0xf000) != sel) {
value &= 0x0fff;
value |= sel;
- ret = acpi_smbus_write(sbs->hc, SMBUS_WRITE_WORD,
+ ret = acpi_smbus_write(sbs->hc, SMBUS_WRITE_WORD,
ACPI_SBS_MANAGER,
0x01, (u8 *)&value, 2);
- if (ret)
- goto end;
+ if (ret)
+ goto end;
}
}
ret = acpi_smbus_write(sbs->hc, SMBUS_WRITE_WORD, ACPI_SBS_BATTERY,
--
2.6.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-01-05 13:30 +0100 |
| Message-ID | <qNyUq-2G0-17@gated-at.bofh.it> |
| In reply to | #1300014 |
On Friday, January 01, 2016 11:53:45 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The indenting in acpi_battery_set_alarm is inconsistent and has been
> so since 2007; commit 94f6c0860139da9219255b8ff45ad42117dda859
> ("ACPI: SBS: Add support for power_supply class (and sysfs)"). Minor
> fix for this, no code functionality change.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks!
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web