Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299913 > unrolled thread

[PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

Started byRoman Volkov <v1ron@mail.ru>
First post2016-01-01 14:50 +0100
Last post2016-01-02 10:20 +0100
Articles 7 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller Roman Volkov <v1ron@mail.ru> - 2016-01-01 14:50 +0100
    [PATCH v3 RESEND 2/2] dts: vt8500: Fix errors in SDHC node for WM8505 Roman Volkov <v1ron@mail.ru> - 2016-01-01 14:50 +0100
    [PATCH v3 RESEND 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650 Roman Volkov <v1ron@mail.ru> - 2016-01-01 14:50 +0100
    Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller Arnd Bergmann <arnd@arndb.de> - 2016-01-01 15:40 +0100
      Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card  controller Roman Volkov <v1ron@mail.ru> - 2016-01-01 18:40 +0100
        Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller Arnd Bergmann <arnd@arndb.de> - 2016-01-01 23:00 +0100
          Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card  controller Roman Volkov <v1ron@mail.ru> - 2016-01-02 10:20 +0100

#1299913 — [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

FromRoman Volkov <v1ron@mail.ru>
Date2016-01-01 14:50 +0100
Subject[PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller
Message-ID<qM8fD-36h-5@gated-at.bofh.it>
From: Roman Volkov <rvolkov@v1ros.org>

This patch set enables SD controller support for WM8650 and
fixes minor errors in WM8505 Device Tree file.

Changes in v3:
1. Add minor fixes for WM8505 SDHC node

Tested on both WM8505 and WM8650.

Roman Volkov (2):
  dts: vt8500: Add SDHC node to DTS file for WM8650
  dts: vt8500: Fix errors in SDHC node for WM8505

 arch/arm/boot/dts/wm8505.dtsi | 4 ++--
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

-- 
Hi maintainers, I see my previous versions were not applied. Could this
little patch set be applied for the linux-next? I don't think this is new
functionality, this must be considered as bugfix for existing Device Tree.

Any other suggestions?

2.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1299914 — [PATCH v3 RESEND 2/2] dts: vt8500: Fix errors in SDHC node for WM8505

FromRoman Volkov <v1ron@mail.ru>
Date2016-01-01 14:50 +0100
Subject[PATCH v3 RESEND 2/2] dts: vt8500: Fix errors in SDHC node for WM8505
Message-ID<qM8fD-36h-3@gated-at.bofh.it>
In reply to#1299913
From: Roman Volkov <rvolkov@v1ros.org>

According to datasheet, the registers space of SDHC controller is 1Kb,
not '0x1000', the correct value should be '0x400'. Bracket interrupt
numbers individually per recommendations.

Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
---
 arch/arm/boot/dts/wm8505.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi
index a1a854b..e9ef539 100644
--- a/arch/arm/boot/dts/wm8505.dtsi
+++ b/arch/arm/boot/dts/wm8505.dtsi
@@ -281,8 +281,8 @@
 
 		sdhc@d800a000 {
 			compatible = "wm,wm8505-sdhc";
-			reg = <0xd800a000 0x1000>;
-			interrupts = <20 21>;
+			reg = <0xd800a000 0x400>;
+			interrupts = <20>, <21>;
 			clocks = <&clksdhc>;
 			bus-width = <4>;
 		};
-- 
2.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299916 — [PATCH v3 RESEND 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650

FromRoman Volkov <v1ron@mail.ru>
Date2016-01-01 14:50 +0100
Subject[PATCH v3 RESEND 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650
Message-ID<qM8fD-36h-15@gated-at.bofh.it>
In reply to#1299913
From: Roman Volkov <rvolkov@v1ros.org>

Since WM8650 has the same 'WMT' SDHC controller as WM8505, and the driver
is already in the kernel, this node enables the controller support for
WM8650

Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
Reviewed-by: Alexey Charkov <alchark@gmail.com>
---
 arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi
index b1c59a7..e12213d 100644
--- a/arch/arm/boot/dts/wm8650.dtsi
+++ b/arch/arm/boot/dts/wm8650.dtsi
@@ -187,6 +187,15 @@
 			interrupts = <43>;
 		};
 
+		sdhc@d800a000 {
+			compatible = "wm,wm8505-sdhc";
+			reg = <0xd800a000 0x400>;
+			interrupts = <20>, <21>;
+			clocks = <&clksdhc>;
+			bus-width = <4>;
+			sdon-inverted;
+		};
+
 		fb: fb@d8050800 {
 			compatible = "wm,wm8505-fb";
 			reg = <0xd8050800 0x200>;
-- 
2.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299930

FromArnd Bergmann <arnd@arndb.de>
Date2016-01-01 15:40 +0100
Message-ID<qM922-3Ch-9@gated-at.bofh.it>
In reply to#1299913
On Friday 01 January 2016 16:38:10 Roman Volkov wrote:
> From: Roman Volkov <rvolkov@v1ros.org>
> 
> This patch set enables SD controller support for WM8650 and
> fixes minor errors in WM8505 Device Tree file.
> 
> Changes in v3:
> 1. Add minor fixes for WM8505 SDHC node
> 
> Tested on both WM8505 and WM8650.
> 
> Roman Volkov (2):
>   dts: vt8500: Add SDHC node to DTS file for WM8650
>   dts: vt8500: Fix errors in SDHC node for WM8505
> 
>  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
>  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> -- 
> Hi maintainers, I see my previous versions were not applied. Could this
> little patch set be applied for the linux-next? I don't think this is new
> functionality, this must be considered as bugfix for existing Device Tree.
> 
> Any other suggestions?
> 

Applied both to next/dt, thanks a lot for following up!

Let me know if you think this should go into stable backports as well,
I did not apply it to the fixes branch as you don't have a
'Cc: stable@vger.kernel.org' tag and it has never worked so far.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299962 — Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

FromRoman Volkov <v1ron@mail.ru>
Date2016-01-01 18:40 +0100
SubjectRe: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller
Message-ID<qMbQe-5ph-9@gated-at.bofh.it>
In reply to#1299930
В Fri, 01 Jan 2016 15:29:29 +0100
Arnd Bergmann <arnd@arndb.de> пишет:

> On Friday 01 January 2016 16:38:10 Roman Volkov wrote:
> > From: Roman Volkov <rvolkov@v1ros.org>
> > 
> > This patch set enables SD controller support for WM8650 and
> > fixes minor errors in WM8505 Device Tree file.
> > 
> > Changes in v3:
> > 1. Add minor fixes for WM8505 SDHC node
> > 
> > Tested on both WM8505 and WM8650.
> > 
> > Roman Volkov (2):
> >   dts: vt8500: Add SDHC node to DTS file for WM8650
> >   dts: vt8500: Fix errors in SDHC node for WM8505
> > 
> >  arch/arm/boot/dts/wm8505.dtsi | 4 ++--
> >  arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> > 
> > -- 
> > Hi maintainers, I see my previous versions were not applied. Could
> > this little patch set be applied for the linux-next? I don't think
> > this is new functionality, this must be considered as bugfix for
> > existing Device Tree.
> > 
> > Any other suggestions?
> >   
> 
> Applied both to next/dt, thanks a lot for following up!
> 
> Let me know if you think this should go into stable backports as well,
> I did not apply it to the fixes branch as you don't have a
> 'Cc: stable@vger.kernel.org' tag and it has never worked so far.

Yes, this must go into the stable too. Let me know if I must change
something or resend.

Thanks,
Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299991

FromArnd Bergmann <arnd@arndb.de>
Date2016-01-01 23:00 +0100
Message-ID<qMfTQ-7Sa-3@gated-at.bofh.it>
In reply to#1299962
On Friday 01 January 2016 20:32:30 Roman Volkov wrote:
> > Applied both to next/dt, thanks a lot for following up!
> > 
> > Let me know if you think this should go into stable backports as well,
> > I did not apply it to the fixes branch as you don't have a
> > 'Cc: stable@vger.kernel.org' tag and it has never worked so far.
> 
> Yes, this must go into the stable too. Let me know if I must change
> something or resend.

I can put them in the fixes branch with the appropriate stable
tag myself, but please clarify whether we need just the first or
both patches there. It looks to me that the second one while
correct only addresses a cosmetic problem and everything works
without it.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1300042 — Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

FromRoman Volkov <v1ron@mail.ru>
Date2016-01-02 10:20 +0100
SubjectRe: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller
Message-ID<qMqvT-6f9-1@gated-at.bofh.it>
In reply to#1299991
В Fri, 01 Jan 2016 22:53:33 +0100
Arnd Bergmann <arnd@arndb.de> пишет:

> On Friday 01 January 2016 20:32:30 Roman Volkov wrote:
> > > Applied both to next/dt, thanks a lot for following up!
> > > 
> > > Let me know if you think this should go into stable backports as
> > > well, I did not apply it to the fixes branch as you don't have a
> > > 'Cc: stable@vger.kernel.org' tag and it has never worked so far.  
> > 
> > Yes, this must go into the stable too. Let me know if I must change
> > something or resend.  
> 
> I can put them in the fixes branch with the appropriate stable
> tag myself, but please clarify whether we need just the first or
> both patches there. It looks to me that the second one while
> correct only addresses a cosmetic problem and everything works
> without it.

Correct, everything works without the second one. One of reviewers
noticed that addresses are different between WM8505 and WM8650 where
the hardware is the same. If such trivial changes are not accepted,
please do not apply.

Happy New Year,
Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web