Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1298827 > unrolled thread

[PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig Timo Sigurdsson <public_timo.s@silentcreek.de> - 2015-12-29 03:10 +0100
    Re: [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig Arnd Bergmann <arnd@arndb.de> - 2015-12-31 16:50 +0100
      Re: [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig Arnd Bergmann <arnd@arndb.de> - 2015-12-31 17:10 +0100
        Re: [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig Arnd Bergmann <arnd@arndb.de> - 2015-12-31 17:20 +0100
      Re: [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in  sunxi_defconfig Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-31 17:10 +0100
        Re: [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig "Timo Sigurdsson" <public_timo.s@silentcreek.de> - 2016-01-01 14:20 +0100
      Re: [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig "Timo Sigurdsson" <public_timo.s@silentcreek.de> - 2016-01-01 14:30 +0100
        Re: [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig Arnd Bergmann <arnd@arndb.de> - 2016-01-01 15:10 +0100
    [PATCH for 4.4-rc8] ARM: Fix broken USB support in multi_v7_defconfig for sunxi devices Timo Sigurdsson <public_timo.s@silentcreek.de> - 2016-01-01 14:50 +0100
      Re: [PATCH for 4.4-rc8] ARM: Fix broken USB support in multi_v7_defconfig for sunxi devices Arnd Bergmann <arnd@arndb.de> - 2016-01-01 15:10 +0100

#1298827 — [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig

Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this   
could make it into 4.4 in order to avoid unpleasent surprises (and
subsequent questions) with builds based on sunxi_defconfig. At the moment,
some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
as a newly added driver is required to power them.

Timo Sigurdsson (1):
  ARM: Fix broken USB support in sunxi_defconfig

 arch/arm/configs/sunxi_defconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1299684

On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
> Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this   
> could make it into 4.4 in order to avoid unpleasent surprises (and
> subsequent questions) with builds based on sunxi_defconfig. At the moment,
> some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
> as a newly added driver is required to power them.

It's a bit confusing to send a patch to so many recipients, that usually
leads to nobody applying it. I can put it into the fixes branch in arm-soc
but need an Ack from the sunxi maintainer(s).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299686

On Thursday 31 December 2015 17:00:49 Maxime Ripard wrote:
> Hi Arnd,
> 
> On Thu, Dec 31, 2015 at 04:46:01PM +0100, Arnd Bergmann wrote:
> > On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
> > > Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this   
> > > could make it into 4.4 in order to avoid unpleasent surprises (and
> > > subsequent questions) with builds based on sunxi_defconfig. At the moment,
> > > some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
> > > as a newly added driver is required to power them.
> > 
> > It's a bit confusing to send a patch to so many recipients, that usually
> > leads to nobody applying it. I can put it into the fixes branch in arm-soc
> > but need an Ack from the sunxi maintainer(s).
> 
> You have mine
> 
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!

> Timo, don't we need the same thing for multi_v7?

Good point.

Timo, please create a patch for that one as well and test it, I can
also apply that on the fixes branch.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299689

On Thursday 31 December 2015 17:03:25 Arnd Bergmann wrote:
> > 
> > You have mine
> > 
> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> Thanks!
> 
> > Timo, don't we need the same thing for multi_v7?
> 
> Good point.
> 
> Timo, please create a patch for that one as well and test it, I can
> also apply that on the fixes branch.
> 

Forgot to mention, I have applied the original patch it on the fixes branch.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299687 — Re: [PATCH 0/1 for 4.4-rc8] ARM: Fix broken USB support in sunxi_defconfig

[Multipart message — attachments visible in raw view] — view raw

Hi Arnd,

On Thu, Dec 31, 2015 at 04:46:01PM +0100, Arnd Bergmann wrote:
> On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
> > Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this   
> > could make it into 4.4 in order to avoid unpleasent surprises (and
> > subsequent questions) with builds based on sunxi_defconfig. At the moment,
> > some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
> > as a newly added driver is required to power them.
> 
> It's a bit confusing to send a patch to so many recipients, that usually
> leads to nobody applying it. I can put it into the fixes branch in arm-soc
> but need an Ack from the sunxi maintainer(s).

You have mine

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Timo, don't we need the same thing for multi_v7?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1299906

Hi Maxime,

Maxime Ripard schrieb am 31.12.2015 17:00:

> Hi Arnd,
> 
> On Thu, Dec 31, 2015 at 04:46:01PM +0100, Arnd Bergmann wrote:
>> On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
>> > Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this   
>> > could make it into 4.4 in order to avoid unpleasent surprises (and
>> > subsequent questions) with builds based on sunxi_defconfig. At the moment,
>> > some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
>> > as a newly added driver is required to power them.
>> 
>> It's a bit confusing to send a patch to so many recipients, that usually
>> leads to nobody applying it. I can put it into the fixes branch in arm-soc
>> but need an Ack from the sunxi maintainer(s).
> 
> You have mine
> 
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> Timo, don't we need the same thing for multi_v7?

Yes, we do. I thought I saw it already in there as a module, but that must
have been on linux-next... Anyway, patch will come right away. I take it
your question implies an ack for the multi_v7 patch, too.


Thanks and Happy New Year,

Timo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299908

Hi Arnd,

Arnd Bergmann schrieb am 31.12.2015 16:46:

> On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
>> Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this   
>> could make it into 4.4 in order to avoid unpleasent surprises (and
>> subsequent questions) with builds based on sunxi_defconfig. At the moment,
>> some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
>> as a newly added driver is required to power them.
> 
> It's a bit confusing to send a patch to so many recipients, that usually
> leads to nobody applying it. I can put it into the fixes branch in arm-soc
> but need an Ack from the sunxi maintainer(s).

Sorry, I didn't know any better. Almost all recipients came from the
get-maintainers script (which I thought were mandatory to include). What's
the recommended way in such cases?

I already prepared and tested a patch for multi_v7_defconfig which I'll
send to the same recipients as before just for the sake of not shutting
out people that were previously addressed in this conversation.

Thanks and Happy New Year,

Timo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299921

On Friday 01 January 2016 14:25:01 Timo Sigurdsson wrote:
> Hi Arnd,
> 
> Arnd Bergmann schrieb am 31.12.2015 16:46:
> 
> > On Tuesday 29 December 2015 02:47:32 Timo Sigurdsson wrote:
> >> Here is a late patch aimed for 4.4-rc8 (or 4.4). It would be nice if this   
> >> could make it into 4.4 in order to avoid unpleasent surprises (and
> >> subsequent questions) with builds based on sunxi_defconfig. At the moment,
> >> some boards (e.g. LeMaker BananaPi) are left with non-functional USB ports
> >> as a newly added driver is required to power them.
> > 
> > It's a bit confusing to send a patch to so many recipients, that usually
> > leads to nobody applying it. I can put it into the fixes branch in arm-soc
> > but need an Ack from the sunxi maintainer(s).
> 
> Sorry, I didn't know any better. Almost all recipients came from the
> get-maintainers script (which I thought were mandatory to include). What's
> the recommended way in such cases?

Just put everyone on Cc, and have the most appropriate recipient (which you
expect to act on the path) as 'To'. Also, address that person in the
cover letter so they know they should act on it, e.g. "Hi Maxime,
can you pick up this patch and forward it to arm-soc?".
 
> I already prepared and tested a patch for multi_v7_defconfig which I'll
> send to the same recipients as before just for the sake of not shutting
> out people that were previously addressed in this conversation.

Ok, thanks.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299917 — [PATCH for 4.4-rc8] ARM: Fix broken USB support in multi_v7_defconfig for sunxi devices

Commit 69fb4dcada77 ("power: Add an axp20x-usb-power driver") introduced a
new driver for the USB power supply used on various Allwinner based SBCs.
However, the driver was not added to multi_v7_defconfig which breaks USB
support for some boards (e.g. LeMaker BananaPi) as the kernel will now
turn off the USB power supply during boot by default if the driver isn't
present. (This was not the case in linux 4.3 or lower where the USB power
was always left on.)

Hence, add the driver to multi_v7_defconfig in order to keep USB support
working on those boards that require it.

Signed-off-by: Timo Sigurdsson <public_timo.s@silentcreek.de>
Tested-by: Timo Sigurdsson <public_timo.s@silentcreek.de>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
Notes:

I chose to add AXP20X_POWER as a module here, since linux-next already
has it this way, see commit 83e9e1f84074 ("ARM: multi_v7_defconfig:
Enable RSB and AXP20X related drivers as modules").
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 69a22fd..cd7b198 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -366,6 +366,7 @@ CONFIG_BATTERY_MAX17042=m
 CONFIG_CHARGER_MAX14577=m
 CONFIG_CHARGER_MAX77693=m
 CONFIG_CHARGER_TPS65090=y
+CONFIG_AXP20X_POWER=m
 CONFIG_POWER_RESET_AS3722=y
 CONFIG_POWER_RESET_GPIO=y
 CONFIG_POWER_RESET_GPIO_RESTART=y
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299922 — Re: [PATCH for 4.4-rc8] ARM: Fix broken USB support in multi_v7_defconfig for sunxi devices

On Friday 01 January 2016 14:38:22 Timo Sigurdsson wrote:
> Commit 69fb4dcada77 ("power: Add an axp20x-usb-power driver") introduced a
> new driver for the USB power supply used on various Allwinner based SBCs.
> However, the driver was not added to multi_v7_defconfig which breaks USB
> support for some boards (e.g. LeMaker BananaPi) as the kernel will now
> turn off the USB power supply during boot by default if the driver isn't
> present. (This was not the case in linux 4.3 or lower where the USB power
> was always left on.)
> 
> Hence, add the driver to multi_v7_defconfig in order to keep USB support
> working on those boards that require it.
> 
> Signed-off-by: Timo Sigurdsson <public_timo.s@silentcreek.de>
> Tested-by: Timo Sigurdsson <public_timo.s@silentcreek.de>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> Notes:
> 
> I chose to add AXP20X_POWER as a module here, since linux-next already
> has it this way, see commit 83e9e1f84074 ("ARM: multi_v7_defconfig:
> Enable RSB and AXP20X related drivers as modules").
> 

Applied to fixes, thanks!

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web