Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1299310 > unrolled thread
| Started by | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| First post | 2015-12-30 12:00 +0100 |
| Last post | 2015-12-30 23:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-30 12:00 +0100
Re: [PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures Takashi Iwai <tiwai@suse.de> - 2015-12-30 23:00 +0100
| From | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| Date | 2015-12-30 12:00 +0100 |
| Subject | [PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures |
| Message-ID | <qLmE2-5wj-5@gated-at.bofh.it> |
The cs5535audio_dma_ops structures are never modified, so declare them as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/pci/cs5535audio/cs5535audio_pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c
index 9c2dc91..27fa57d 100644
--- a/sound/pci/cs5535audio/cs5535audio_pcm.c
+++ b/sound/pci/cs5535audio/cs5535audio_pcm.c
@@ -402,7 +402,7 @@ static struct snd_pcm_ops snd_cs5535audio_capture_ops = {
.pointer = snd_cs5535audio_pcm_pointer,
};
-static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
+static const struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
.type = CS5535AUDIO_DMA_PLAYBACK,
.enable_dma = cs5535audio_playback_enable_dma,
.disable_dma = cs5535audio_playback_disable_dma,
@@ -412,7 +412,7 @@ static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
.read_dma_pntr = cs5535audio_playback_read_dma_pntr,
};
-static struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
+static const struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
.type = CS5535AUDIO_DMA_CAPTURE,
.enable_dma = cs5535audio_capture_enable_dma,
.disable_dma = cs5535audio_capture_disable_dma,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2015-12-30 23:00 +0100 |
| Message-ID | <qLwWJ-3Ft-1@gated-at.bofh.it> |
| In reply to | #1299310 |
On Wed, 30 Dec 2015 11:44:53 +0100,
Julia Lawall wrote:
>
> The cs5535audio_dma_ops structures are never modified, so declare them as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thanks.
Takashi
>
> ---
> sound/pci/cs5535audio/cs5535audio_pcm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c
> index 9c2dc91..27fa57d 100644
> --- a/sound/pci/cs5535audio/cs5535audio_pcm.c
> +++ b/sound/pci/cs5535audio/cs5535audio_pcm.c
> @@ -402,7 +402,7 @@ static struct snd_pcm_ops snd_cs5535audio_capture_ops = {
> .pointer = snd_cs5535audio_pcm_pointer,
> };
>
> -static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
> +static const struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
> .type = CS5535AUDIO_DMA_PLAYBACK,
> .enable_dma = cs5535audio_playback_enable_dma,
> .disable_dma = cs5535audio_playback_disable_dma,
> @@ -412,7 +412,7 @@ static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
> .read_dma_pntr = cs5535audio_playback_read_dma_pntr,
> };
>
> -static struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
> +static const struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
> .type = CS5535AUDIO_DMA_CAPTURE,
> .enable_dma = cs5535audio_capture_enable_dma,
> .disable_dma = cs5535audio_capture_disable_dma,
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web