Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1297818 > unrolled thread
| Started by | Yuan Yao <yao.yuan@freescale.com> |
|---|---|
| First post | 2015-12-24 12:10 +0100 |
| Last post | 2015-12-29 19:40 +0100 |
| Articles | 7 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Yuan Yao <yao.yuan@freescale.com> - 2015-12-24 12:10 +0100
Re: [PATCH v2 2/4] Documentation: fsl-quadspi: Add fsl, ls2080a-qspi compatible string Rob Herring <robh@kernel.org> - 2015-12-29 19:40 +0100
Re: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Rob Herring <robh@kernel.org> - 2015-12-29 19:40 +0100
RE: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Yao Yuan <yao.yuan@nxp.com> - 2015-12-30 06:00 +0100
Re: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Rob Herring <robh@kernel.org> - 2015-12-30 16:20 +0100
RE: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Yao Yuan <yao.yuan@nxp.com> - 2015-12-31 03:40 +0100
Re: [PATCH 4/4] Documentation: fsl-quadspi: Add optional properties Rob Herring <robh@kernel.org> - 2015-12-29 19:40 +0100
| From | Yuan Yao <yao.yuan@freescale.com> |
|---|---|
| Date | 2015-12-24 12:10 +0100 |
| Subject | [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string |
| Message-ID | <qJbWq-5Z3-17@gated-at.bofh.it> |
new compatible string: "fsl,ls2080a-qspi". Signed-off-by: Yuan Yao <yao.yuan@nxp.com> --- Changed in v2: Update my email to <yao.yuan@nxp.com> --- Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt index fa77f87..2fe51d6 100644 --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt @@ -1,7 +1,8 @@ ARM Freescale DSPI controller Required properties: -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi" +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", + "fsl,ls2085a-dspi", "fsl,ls2080a-dspi" - reg : Offset and length of the register set for the device - interrupts : Should contain SPI controller interrupt - clocks: from common clock binding: handle to dspi clock. -- 2.1.0.27.g96db324 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2015-12-29 19:40 +0100 |
| Subject | Re: [PATCH v2 2/4] Documentation: fsl-quadspi: Add fsl, ls2080a-qspi compatible string |
| Message-ID | <qL7lE-49U-21@gated-at.bofh.it> |
| In reply to | #1297818 |
On Thu, Dec 24, 2015 at 07:01:01PM +0800, Yuan Yao wrote: > new compatible string: "fsl,ls2080a-qspi". > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > --- > Changed in v2: > Update my email to <yao.yuan@nxp.com> > --- > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt > index 6585ac7..2bef0dc 100644 > --- a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt > +++ b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt > @@ -3,7 +3,7 @@ > Required properties: > - compatible : Should be "fsl,vf610-qspi", "fsl,imx6sx-qspi", > "fsl,imx7d-qspi", "fsl,imx6ul-qspi", > - "fsl,ls1021-qspi" > + "fsl,ls1021a-qspi", "fsl,ls2080a-qspi" You should explain what combinations of compatible strings are valid. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2015-12-29 19:40 +0100 |
| Subject | Re: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string |
| Message-ID | <qL7lE-49U-17@gated-at.bofh.it> |
| In reply to | #1297818 |
On Thu, Dec 24, 2015 at 07:01:00PM +0800, Yuan Yao wrote: > new compatible string: "fsl,ls2080a-qspi". > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > --- > Changed in v2: > Update my email to <yao.yuan@nxp.com> > --- > Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > index fa77f87..2fe51d6 100644 > --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > @@ -1,7 +1,8 @@ > ARM Freescale DSPI controller > > Required properties: > -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi" > +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", > + "fsl,ls2085a-dspi", "fsl,ls2080a-dspi" You should explain what combinations of compatible strings are valid. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@nxp.com> |
|---|---|
| Date | 2015-12-30 06:00 +0100 |
| Subject | RE: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string |
| Message-ID | <qLh1D-1LR-1@gated-at.bofh.it> |
| In reply to | #1299076 |
Hi Rob, Thanks for your review. So you mean that I should add the commit message for why I add this new compatible? Best Regards, Yuan Yao On Wed, Dec 30, 2015 at 02:35AM, Rob Herring wrote: > On Thu, Dec 24, 2015 at 07:01:00PM +0800, Yuan Yao wrote: > > new compatible string: "fsl,ls2080a-qspi". > > > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > > --- > > Changed in v2: > > Update my email to <yao.yuan@nxp.com> > > --- > > Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > > index fa77f87..2fe51d6 100644 > > --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > > @@ -1,7 +1,8 @@ > > ARM Freescale DSPI controller > > > > Required properties: > > -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi" > > +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", > > + "fsl,ls2085a-dspi", "fsl,ls2080a-dspi" > > You should explain what combinations of compatible strings are valid. > > Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2015-12-30 16:20 +0100 |
| Subject | Re: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string |
| Message-ID | <qLqHF-8io-21@gated-at.bofh.it> |
| In reply to | #1299236 |
On Tue, Dec 29, 2015 at 9:17 PM, Yao Yuan <yao.yuan@nxp.com> wrote: > Hi Rob, > > Thanks for your review. > So you mean that I should add the commit message for why I add this new compatible? Please don't top post on the lists. No, the binding doc should explain what are valid combinations of compatible strings and the order when the dts can have multiple strings. For example, is this valid: compatible = "fsl,vf610-dspi", "fsl,ls2080a-dspi"; In other words, I should be able to check a dts file against what the binding doc says. Rob > On Wed, Dec 30, 2015 at 02:35AM, Rob Herring wrote: >> On Thu, Dec 24, 2015 at 07:01:00PM +0800, Yuan Yao wrote: >> > new compatible string: "fsl,ls2080a-qspi". >> > >> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> >> > --- >> > Changed in v2: >> > Update my email to <yao.yuan@nxp.com> >> > --- >> > Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > index fa77f87..2fe51d6 100644 >> > --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > @@ -1,7 +1,8 @@ >> > ARM Freescale DSPI controller >> > >> > Required properties: >> > -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi" >> > +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", >> > + "fsl,ls2085a-dspi", "fsl,ls2080a-dspi" >> >> You should explain what combinations of compatible strings are valid. >> >> Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@nxp.com> |
|---|---|
| Date | 2015-12-31 03:40 +0100 |
| Subject | RE: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string |
| Message-ID | <qLBjH-6Ik-1@gated-at.bofh.it> |
| In reply to | #1299390 |
T24gV2VkLCBEZWMgMzAsIDIwMTUgYXQgMTE6MjAgUE0sIFJvYiBIZXJyaW5nIHdyb3RlOg0KPiBP biBUdWUsIERlYyAyOSwgMjAxNSBhdCA5OjE3IFBNLCBZYW8gWXVhbiA8eWFvLnl1YW5AbnhwLmNv bT4gd3JvdGU6DQo+ID4gSGkgUm9iLA0KPiA+DQo+ID4gVGhhbmtzIGZvciB5b3VyIHJldmlldy4N Cj4gPiBTbyB5b3UgbWVhbiB0aGF0IEkgc2hvdWxkIGFkZCB0aGUgY29tbWl0IG1lc3NhZ2UgZm9y IHdoeSBJIGFkZCB0aGlzIG5ldw0KPiBjb21wYXRpYmxlPw0KPiANCj4gUGxlYXNlIGRvbid0IHRv cCBwb3N0IG9uIHRoZSBsaXN0cy4NCj4gDQo+IE5vLCB0aGUgYmluZGluZyBkb2Mgc2hvdWxkIGV4 cGxhaW4gd2hhdCBhcmUgdmFsaWQgY29tYmluYXRpb25zIG9mIGNvbXBhdGlibGUNCj4gc3RyaW5n cyBhbmQgdGhlIG9yZGVyIHdoZW4gdGhlIGR0cyBjYW4gaGF2ZSBtdWx0aXBsZSBzdHJpbmdzLiBG b3IgZXhhbXBsZSwgaXMNCj4gdGhpcyB2YWxpZDoNCj4gDQo+IGNvbXBhdGlibGUgPSAiZnNsLHZm NjEwLWRzcGkiLCAiZnNsLGxzMjA4MGEtZHNwaSI7DQo+IA0KPiBJbiBvdGhlciB3b3JkcywgSSBz aG91bGQgYmUgYWJsZSB0byBjaGVjayBhIGR0cyBmaWxlIGFnYWluc3Qgd2hhdCB0aGUgYmluZGlu ZyBkb2MNCj4gc2F5cy4NCj4gDQo+IFJvYg0KDQpPSywgSSBnb3QgaXQuDQpUaGUgImZzbCx2ZjYx MC1kc3BpIiwgImZzbCxsczEwMjFhLXYxLjAtZHNwaSIsICJmc2wsbHMyMDg1YS1kc3BpIiBpcyB2 YWxpZCBhbmQgdXNlZCBpbiBkcml2ZXIuDQpCdXQgImZzbCxsczIwODBhLWRzcGkiIGlzIGp1c3Qg dXNlZCBmb3IgcGxhdGZvcm0gZmxhZy4NCkNvdWxkIHlvdSBoZWxwIHRvIGdpdmUgYW4gZXhhbXBs ZSB0aGF0IGhvdyBjYW4gSSBleHBsYWluIGl0IGluIERvY3VtZW50cz8NCk9yIHNob3VsZCBJIG5v dCB3cml0ZSB0aGlzIGNvbXBhdGlibGUgaW4gRG9jdW1lbnQuDQoNCkkgZmluZCB0aGF0IG1hbnkg Y29tcGF0aWJsZSBzdHJpbmdzIGxpa2UgdGhpcyAobm90IHZhbGlkIGp1c3QgYSBwbGF0Zm9ybSBm bGFnKSBmb3Igb3RoZXIgZHJpdmVyIGFyZSBub3QgcmVjb3JkIGluIGRvY3VtZW50Lg0KDQpUaGFu a3MuDQoNCll1YW4gWWFvDQoNCj4gDQo+ID4gT24gV2VkLCBEZWMgMzAsIDIwMTUgYXQgMDI6MzVB TSwgUm9iIEhlcnJpbmcgd3JvdGU6DQo+ID4+IE9uIFRodSwgRGVjIDI0LCAyMDE1IGF0IDA3OjAx OjAwUE0gKzA4MDAsIFl1YW4gWWFvIHdyb3RlOg0KPiA+PiA+IG5ldyBjb21wYXRpYmxlIHN0cmlu ZzogImZzbCxsczIwODBhLXFzcGkiLg0KPiA+PiA+DQo+ID4+ID4gU2lnbmVkLW9mZi1ieTogWXVh biBZYW8gPHlhby55dWFuQG54cC5jb20+DQo+ID4+ID4gLS0tDQo+ID4+ID4gQ2hhbmdlZCBpbiB2 MjoNCj4gPj4gPiBVcGRhdGUgbXkgZW1haWwgdG8gPHlhby55dWFuQG54cC5jb20+DQo+ID4+ID4g LS0tDQo+ID4+ID4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zcGkvc3BpLWZz bC1kc3BpLnR4dCB8IDMgKystDQo+ID4+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkNCj4gPj4gPg0KPiA+PiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc3BpL3NwaS1mc2wtZHNwaS50eHQNCj4gPj4gYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc3BpL3NwaS1mc2wtZHNwaS50eHQNCj4gPj4g PiBpbmRleCBmYTc3Zjg3Li4yZmU1MWQ2IDEwMDY0NA0KPiA+PiA+IC0tLSBhL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9zcGkvc3BpLWZzbC1kc3BpLnR4dA0KPiA+PiA+ICsrKyBi L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zcGkvc3BpLWZzbC1kc3BpLnR4dA0K PiA+PiA+IEBAIC0xLDcgKzEsOCBAQA0KPiA+PiA+ICBBUk0gRnJlZXNjYWxlIERTUEkgY29udHJv bGxlcg0KPiA+PiA+DQo+ID4+ID4gIFJlcXVpcmVkIHByb3BlcnRpZXM6DQo+ID4+ID4gLS0gY29t cGF0aWJsZSA6ICJmc2wsdmY2MTAtZHNwaSIsICJmc2wsbHMxMDIxYS12MS4wLWRzcGkiLCAiZnNs LGxzMjA4NWEtZHNwaSINCj4gPj4gPiArLSBjb21wYXRpYmxlIDogImZzbCx2ZjYxMC1kc3BpIiwg ImZzbCxsczEwMjFhLXYxLjAtZHNwaSIsDQo+ID4+ID4gKyAgICAgICAgICAgImZzbCxsczIwODVh LWRzcGkiLCAiZnNsLGxzMjA4MGEtZHNwaSINCj4gPj4NCj4gPj4gWW91IHNob3VsZCBleHBsYWlu IHdoYXQgY29tYmluYXRpb25zIG9mIGNvbXBhdGlibGUgc3RyaW5ncyBhcmUgdmFsaWQuDQo+ID4+ DQo+ID4+IFJvYg0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2015-12-29 19:40 +0100 |
| Subject | Re: [PATCH 4/4] Documentation: fsl-quadspi: Add optional properties |
| Message-ID | <qL7lE-49U-35@gated-at.bofh.it> |
| In reply to | #1297818 |
On Thu, Dec 24, 2015 at 07:01:03PM +0800, Yuan Yao wrote: > Add optional properties for QSPI: > big-endian > if the register is big endian on this platform. > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > --- > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web