Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299096 > unrolled thread

[PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args

Back to article view | Back to linux.kernel

Contents

  [PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args Insu Yun <wuninsu@gmail.com> - 2015-12-29 20:30 +0100
    Re: [PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args David Miller <davem@davemloft.net> - 2015-12-29 20:50 +0100

#1299096 — [PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args

Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
index a5f422f..a9a2c33 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
@@ -772,8 +772,10 @@ int qlcnic_82xx_config_intrpt(struct qlcnic_adapter *adapter, u8 op_type)
 	int i, err = 0;
 
 	for (i = 0; i < ahw->num_msix; i++) {
-		qlcnic_alloc_mbx_args(&cmd, adapter,
+		err = qlcnic_alloc_mbx_args(&cmd, adapter,
 				      QLCNIC_CMD_MQ_TX_CONFIG_INTR);
+		if (err)
+			return err;
 		type = op_type ? QLCNIC_INTRPT_ADD : QLCNIC_INTRPT_DEL;
 		val = type | (ahw->intr_tbl[i].type << 4);
 		if (ahw->intr_tbl[i].type == QLCNIC_INTRPT_MSIX)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1299102

From: Insu Yun <wuninsu@gmail.com>
Date: Tue, 29 Dec 2015 14:29:47 -0500

> Signed-off-by: Insu Yun <wuninsu@gmail.com>
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> index a5f422f..a9a2c33 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> @@ -772,8 +772,10 @@ int qlcnic_82xx_config_intrpt(struct qlcnic_adapter *adapter, u8 op_type)
>  	int i, err = 0;
>  
>  	for (i = 0; i < ahw->num_msix; i++) {
> -		qlcnic_alloc_mbx_args(&cmd, adapter,
> +		err = qlcnic_alloc_mbx_args(&cmd, adapter,
>  				      QLCNIC_CMD_MQ_TX_CONFIG_INTR);

You must fix the indentation of the second line of the function call when
you made changes like this.  The first character on the second line of the
call must be exactly at the first column after the openning parenthesis of
the first line.

You must must the appropriate number of TAB and then SPACE characters
necessary to achieve this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web