Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1298533 > unrolled thread

RE: [PATCH] arm: kernel: utilize hrtimer based broadcast

Started byHuan Wang <alison.wang@nxp.com>
First post2015-12-28 08:40 +0100
Last post2015-12-29 15:00 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  RE: [PATCH] arm: kernel: utilize hrtimer based broadcast Huan Wang <alison.wang@nxp.com> - 2015-12-28 08:40 +0100
    Re: [PATCH] arm: kernel: utilize hrtimer based broadcast Arnd Bergmann <arnd@arndb.de> - 2015-12-28 13:00 +0100
      Re: [PATCH] arm: kernel: utilize hrtimer based broadcast Thomas Gleixner <tglx@linutronix.de> - 2015-12-29 15:00 +0100

#1298533 — RE: [PATCH] arm: kernel: utilize hrtimer based broadcast

FromHuan Wang <alison.wang@nxp.com>
Date2015-12-28 08:40 +0100
SubjectRE: [PATCH] arm: kernel: utilize hrtimer based broadcast
Message-ID<qKAzo-7dk-15@gated-at.bofh.it>
Hi, Arnd,

	Could you help to review the following patch? Thanks.


Best Regards,
Alison Wang

> On Fri, Jul 17, 2015 at 10:11:52AM +0100, Alison Wang wrote:
> > Hrtimer based broadcast is used on ARM platform. It can be registered
> > as the tick broadcast device in the absence of a real external clock
> > device.
> >
> > Signed-off-by: Alison Wang <alison.wang@freescale.com>
> 
> This looks sensible to me. FWIW:
> 
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> 
> Thanks,
> Mark.
> 
> > ---
> >  arch/arm/kernel/time.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c index
> > a66e37e..a9bc73c 100644
> > --- a/arch/arm/kernel/time.c
> > +++ b/arch/arm/kernel/time.c
> > @@ -12,6 +12,7 @@
> >   *  reading the RTC at bootup, etc...
> >   */
> >  #include <linux/clk-provider.h>
> > +#include <linux/clockchips.h>
> >  #include <linux/clocksource.h>
> >  #include <linux/errno.h>
> >  #include <linux/export.h>
> > @@ -121,5 +122,7 @@ void __init time_init(void)
> >  		of_clk_init(NULL);
> >  #endif
> >  		clocksource_of_init();
> > +
> > +		tick_setup_hrtimer_broadcast();
> >  	}
> >  }
> > --
> > 2.1.0.27.g96db324
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1298614

FromArnd Bergmann <arnd@arndb.de>
Date2015-12-28 13:00 +0100
Message-ID<qKECZ-1qo-7@gated-at.bofh.it>
In reply to#1298533
On Monday 28 December 2015 07:18:58 Huan Wang wrote:
> Hi, Arnd,
> 
> 	Could you help to review the following patch? Thanks.
> 

Hi Alison,

I'm sorry but I understand very little of this particular area of the kernel.

I've added Daniel Lezcano, John Stultz and Thomas Gleixner to Cc, they all
know this much better than I do and one of them should be able to comment after
their Christmas break.

	Arnd

> > On Fri, Jul 17, 2015 at 10:11:52AM +0100, Alison Wang wrote:
> > > Hrtimer based broadcast is used on ARM platform. It can be registered
> > > as the tick broadcast device in the absence of a real external clock
> > > device.
> > >
> > > Signed-off-by: Alison Wang <alison.wang@freescale.com>
> > 
> > This looks sensible to me. FWIW:
> > 
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > 
> > Thanks,
> > Mark.
> > 
> > > ---
> > >  arch/arm/kernel/time.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c index
> > > a66e37e..a9bc73c 100644
> > > --- a/arch/arm/kernel/time.c
> > > +++ b/arch/arm/kernel/time.c
> > > @@ -12,6 +12,7 @@
> > >   *  reading the RTC at bootup, etc...
> > >   */
> > >  #include <linux/clk-provider.h>
> > > +#include <linux/clockchips.h>
> > >  #include <linux/clocksource.h>
> > >  #include <linux/errno.h>
> > >  #include <linux/export.h>
> > > @@ -121,5 +122,7 @@ void __init time_init(void)
> > >  		of_clk_init(NULL);
> > >  #endif
> > >  		clocksource_of_init();
> > > +
> > > +		tick_setup_hrtimer_broadcast();
> > >  	}
> > >  }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1299002

FromThomas Gleixner <tglx@linutronix.de>
Date2015-12-29 15:00 +0100
Message-ID<qL2YG-1hA-3@gated-at.bofh.it>
In reply to#1298614
On Mon, 28 Dec 2015, Arnd Bergmann wrote:

> On Monday 28 December 2015 07:18:58 Huan Wang wrote:
> > Hi, Arnd,
> > 
> > 	Could you help to review the following patch? Thanks.
> > 
> 
> Hi Alison,
> 
> I'm sorry but I understand very little of this particular area of the kernel.
> 
> I've added Daniel Lezcano, John Stultz and Thomas Gleixner to Cc, they all
> know this much better than I do and one of them should be able to comment after
> their Christmas break.

I have no real opinion about that patch. It does no harm to unconditionally
setup the hrtimer based broadcast even if it's never used.

Up to the arch maintainer to decide. 

Thanks,

	tglx
 
> > > On Fri, Jul 17, 2015 at 10:11:52AM +0100, Alison Wang wrote:
> > > > Hrtimer based broadcast is used on ARM platform. It can be registered
> > > > as the tick broadcast device in the absence of a real external clock
> > > > device.
> > > >
> > > > Signed-off-by: Alison Wang <alison.wang@freescale.com>
> > > 
> > > This looks sensible to me. FWIW:
> > > 
> > > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > > 
> > > Thanks,
> > > Mark.
> > > 
> > > > ---
> > > >  arch/arm/kernel/time.c | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c index
> > > > a66e37e..a9bc73c 100644
> > > > --- a/arch/arm/kernel/time.c
> > > > +++ b/arch/arm/kernel/time.c
> > > > @@ -12,6 +12,7 @@
> > > >   *  reading the RTC at bootup, etc...
> > > >   */
> > > >  #include <linux/clk-provider.h>
> > > > +#include <linux/clockchips.h>
> > > >  #include <linux/clocksource.h>
> > > >  #include <linux/errno.h>
> > > >  #include <linux/export.h>
> > > > @@ -121,5 +122,7 @@ void __init time_init(void)
> > > >  		of_clk_init(NULL);
> > > >  #endif
> > > >  		clocksource_of_init();
> > > > +
> > > > +		tick_setup_hrtimer_broadcast();
> > > >  	}
> > > >  }
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web