Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1297866 > unrolled thread
| Started by | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| First post | 2015-12-24 15:10 +0100 |
| Last post | 2015-12-24 17:00 +0100 |
| Articles | 14 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] OMAP: RX51: save atags data to be exported on /proc/atags Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2015-12-24 15:10 +0100
[PATCH 1/3] ARM: ATAGS: move atags.h to include/asm so it can be included by files outside kernel/ Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2015-12-24 15:10 +0100
Re: [PATCH 1/3] ARM: ATAGS: move atags.h to include/asm so it can be included by files outside kernel/ Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-24 16:40 +0100
[PATCH 0/2] OMAP: RX51: save atags data to be exported on /proc/atags Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2015-12-24 17:50 +0100
[PATCH 2/2] OMAP: RX51: save ATAGS data in the early boot stage Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2015-12-24 17:50 +0100
Re: [PATCH 2/2] OMAP: RX51: save ATAGS data in the early boot stage Pali Rohár <pali.rohar@gmail.com> - 2015-12-24 18:50 +0100
Re: [PATCH 2/2] OMAP: RX51: save ATAGS data in the early boot stage Tony Lindgren <tony@atomide.com> - 2015-12-24 20:00 +0100
Re: [PATCH 2/2] OMAP: RX51: save ATAGS data in the early boot stage Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-01-01 12:50 +0100
[PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2015-12-24 17:50 +0100
Re: [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h Pali Rohár <pali.rohar@gmail.com> - 2015-12-24 18:50 +0100
Re: [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h Tony Lindgren <tony@atomide.com> - 2015-12-24 20:00 +0100
Re: [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2015-12-24 20:10 +0100
[PATCH 3/3] OMAP: RX51: save ATAGS data in the early boot stage Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2015-12-24 15:10 +0100
Re: [PATCH 0/3] OMAP: RX51: save atags data to be exported on /proc/atags Arnd Bergmann <arnd@arndb.de> - 2015-12-24 17:00 +0100
| From | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| Date | 2015-12-24 15:10 +0100 |
| Subject | [PATCH 0/3] OMAP: RX51: save atags data to be exported on /proc/atags |
| Message-ID | <qJeKB-7HG-3@gated-at.bofh.it> |
Nokia N900 legacy userspace needs ATAGS passed by the bootloder to be
available in /proc/atags. With DT booted kernel this information is
no longer availabe. Fix that by saving ATAGS data early in the boot
stage so it can be exported in /proc/atags later
Ivaylo Dimitrov (3):
ARM: ATAGS: move atags.h to include/asm so it can be included by files
outside kernel/
ARM: ATAGS: Fix declaration of function save_atags
OMAP: RX51: save ATAGS data in the early boot stage
arch/arm/include/asm/atags.h | 20 ++++++++++++++++++++
arch/arm/kernel/atags.h | 20 --------------------
arch/arm/kernel/atags_parse.c | 3 +--
arch/arm/kernel/setup.c | 3 +--
arch/arm/mach-omap2/board-generic.c | 12 +++++++++++-
5 files changed, 33 insertions(+), 25 deletions(-)
create mode 100644 arch/arm/include/asm/atags.h
delete mode 100644 arch/arm/kernel/atags.h
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| Date | 2015-12-24 15:10 +0100 |
| Subject | [PATCH 1/3] ARM: ATAGS: move atags.h to include/asm so it can be included by files outside kernel/ |
| Message-ID | <qJeKB-7HG-5@gated-at.bofh.it> |
| In reply to | #1297866 |
This is needed by a follow-up patch that saves atags on RX51 device
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
arch/arm/include/asm/atags.h | 20 ++++++++++++++++++++
arch/arm/kernel/atags.h | 20 --------------------
arch/arm/kernel/atags_parse.c | 3 +--
arch/arm/kernel/setup.c | 3 +--
4 files changed, 22 insertions(+), 24 deletions(-)
create mode 100644 arch/arm/include/asm/atags.h
delete mode 100644 arch/arm/kernel/atags.h
diff --git a/arch/arm/include/asm/atags.h b/arch/arm/include/asm/atags.h
new file mode 100644
index 0000000..ec4164d
--- /dev/null
+++ b/arch/arm/include/asm/atags.h
@@ -0,0 +1,20 @@
+#ifdef CONFIG_ATAGS_PROC
+extern void save_atags(struct tag *tags);
+#else
+static inline void save_atags(struct tag *tags) { }
+#endif
+
+void convert_to_tag_list(struct tag *tags);
+
+#ifdef CONFIG_ATAGS
+const struct machine_desc *setup_machine_tags(phys_addr_t __atags_pointer,
+ unsigned int machine_nr);
+#else
+static inline const struct machine_desc *
+setup_machine_tags(phys_addr_t __atags_pointer, unsigned int machine_nr)
+{
+ early_print("no ATAGS support: can't continue\n");
+ while (true);
+ unreachable();
+}
+#endif
diff --git a/arch/arm/kernel/atags.h b/arch/arm/kernel/atags.h
deleted file mode 100644
index ec4164d..0000000
--- a/arch/arm/kernel/atags.h
+++ /dev/null
@@ -1,20 +0,0 @@
-#ifdef CONFIG_ATAGS_PROC
-extern void save_atags(struct tag *tags);
-#else
-static inline void save_atags(struct tag *tags) { }
-#endif
-
-void convert_to_tag_list(struct tag *tags);
-
-#ifdef CONFIG_ATAGS
-const struct machine_desc *setup_machine_tags(phys_addr_t __atags_pointer,
- unsigned int machine_nr);
-#else
-static inline const struct machine_desc *
-setup_machine_tags(phys_addr_t __atags_pointer, unsigned int machine_nr)
-{
- early_print("no ATAGS support: can't continue\n");
- while (true);
- unreachable();
-}
-#endif
diff --git a/arch/arm/kernel/atags_parse.c b/arch/arm/kernel/atags_parse.c
index 68c6ae0..faac2d1 100644
--- a/arch/arm/kernel/atags_parse.c
+++ b/arch/arm/kernel/atags_parse.c
@@ -28,8 +28,7 @@
#include <asm/system_info.h>
#include <asm/page.h>
#include <asm/mach/arch.h>
-
-#include "atags.h"
+#include <asm/atags.h>
static char default_command_line[COMMAND_LINE_SIZE] __initdata = CONFIG_CMDLINE;
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 20edd34..aa0193a 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -60,8 +60,7 @@
#include <asm/unwind.h>
#include <asm/memblock.h>
#include <asm/virt.h>
-
-#include "atags.h"
+#include <asm/atags.h>
#if defined(CONFIG_FPE_NWFPE) || defined(CONFIG_FPE_FASTFPE)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Russell King - ARM Linux <linux@arm.linux.org.uk> |
|---|---|
| Date | 2015-12-24 16:40 +0100 |
| Subject | Re: [PATCH 1/3] ARM: ATAGS: move atags.h to include/asm so it can be included by files outside kernel/ |
| Message-ID | <qJg9H-8uN-3@gated-at.bofh.it> |
| In reply to | #1297867 |
On Thu, Dec 24, 2015 at 04:00:56PM +0200, Ivaylo Dimitrov wrote:
> This is needed by a follow-up patch that saves atags on RX51 device
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
> arch/arm/include/asm/atags.h | 20 ++++++++++++++++++++
> arch/arm/kernel/atags.h | 20 --------------------
Please generate diffs with -M so that it can detect renames and provide
a more sensible diffstat and patch output (so we can see any changes
through the rename.) However...
> arch/arm/kernel/atags_parse.c | 3 +--
> arch/arm/kernel/setup.c | 3 +--
> 4 files changed, 22 insertions(+), 24 deletions(-)
> create mode 100644 arch/arm/include/asm/atags.h
> delete mode 100644 arch/arm/kernel/atags.h
>
> diff --git a/arch/arm/include/asm/atags.h b/arch/arm/include/asm/atags.h
> new file mode 100644
> index 0000000..ec4164d
> --- /dev/null
> +++ b/arch/arm/include/asm/atags.h
> @@ -0,0 +1,20 @@
> +#ifdef CONFIG_ATAGS_PROC
> +extern void save_atags(struct tag *tags);
> +#else
> +static inline void save_atags(struct tag *tags) { }
> +#endif
> +
> +void convert_to_tag_list(struct tag *tags);
> +
> +#ifdef CONFIG_ATAGS
> +const struct machine_desc *setup_machine_tags(phys_addr_t __atags_pointer,
> + unsigned int machine_nr);
> +#else
> +static inline const struct machine_desc *
> +setup_machine_tags(phys_addr_t __atags_pointer, unsigned int machine_nr)
> +{
> + early_print("no ATAGS support: can't continue\n");
> + while (true);
> + unreachable();
> +}
> +#endif
> diff --git a/arch/arm/kernel/atags.h b/arch/arm/kernel/atags.h
> deleted file mode 100644
> index ec4164d..0000000
> --- a/arch/arm/kernel/atags.h
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -#ifdef CONFIG_ATAGS_PROC
> -extern void save_atags(struct tag *tags);
> -#else
> -static inline void save_atags(struct tag *tags) { }
> -#endif
I'd think I'd prefer moving just the above save_atags declaration to
arch/arm/include/asm/setup.h so we're not allowing the rest of this
to be exposed to anyone who includes asm/atags.h.
Thanks.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| Date | 2015-12-24 17:50 +0100 |
| Subject | [PATCH 0/2] OMAP: RX51: save atags data to be exported on /proc/atags |
| Message-ID | <qJhfr-GU-1@gated-at.bofh.it> |
| In reply to | #1297901 |
Nokia N900 legacy userspace needs ATAGS passed by the bootloder to be
available in /proc/atags. With DT booted kernel this information is
no longer availabe. Fix that by saving ATAGS data early in the boot
stage so it can be exported in /proc/atags later
Ivaylo Dimitrov (2):
ARM: ATAGS: move save_atags() to include/asm
arch/arm/include/asm/setup.h
OMAP: RX51: save ATAGS data in the early boot stage
arch/arm/include/asm/setup.h | 6 ++++++
arch/arm/kernel/atags.h | 6 ------
arch/arm/mach-omap2/board-generic.c | 12 +++++++++++-
3 files changed, 17 insertions(+), 7 deletions(-)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| Date | 2015-12-24 17:50 +0100 |
| Subject | [PATCH 2/2] OMAP: RX51: save ATAGS data in the early boot stage |
| Message-ID | <qJhfr-GU-5@gated-at.bofh.it> |
| In reply to | #1298007 |
Nokia N900 (RX51) legacy userspace needs various ATAGS passed by the
bootloader (boot reason, device serial, boot mode, various GPIO swithes,
etc). Save that data early enough in the boot process, so it can be
exported later in /proc/atags
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
arch/arm/mach-omap2/board-generic.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
index 04a56cc..8098272 100644
--- a/arch/arm/mach-omap2/board-generic.c
+++ b/arch/arm/mach-omap2/board-generic.c
@@ -16,6 +16,7 @@
#include <linux/of_platform.h>
#include <linux/irqdomain.h>
+#include <asm/setup.h>
#include <asm/mach/arch.h>
#include "common.h"
@@ -76,8 +77,17 @@ static const char *const n900_boards_compat[] __initconst = {
NULL,
};
+/* Legacy userspace on Nokia N900 needs ATAGS exported in /proc/atags,
+ * save them while the data is still not overwritten
+ */
+static void __init rx51_reserve(void)
+{
+ save_atags((const struct tag *)(PAGE_OFFSET + 0x100));
+ omap_reserve();
+}
+
DT_MACHINE_START(OMAP3_N900_DT, "Nokia RX-51 board")
- .reserve = omap_reserve,
+ .reserve = rx51_reserve,
.map_io = omap3_map_io,
.init_early = omap3430_init_early,
.init_machine = omap_generic_init,
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2015-12-24 18:50 +0100 |
| Subject | Re: [PATCH 2/2] OMAP: RX51: save ATAGS data in the early boot stage |
| Message-ID | <qJibv-1fE-9@gated-at.bofh.it> |
| In reply to | #1298009 |
[Multipart message — attachments visible in raw view] — view raw
On Thursday 24 December 2015 17:37:56 Ivaylo Dimitrov wrote: > Nokia N900 (RX51) legacy userspace needs various ATAGS passed by the > bootloader (boot reason, device serial, boot mode, various GPIO > swithes, etc). Save that data early enough in the boot process, so > it can be exported later in /proc/atags > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Working fine in qemu. Tested-by: Pali Rohár <pali.rohar@gmail.com> -- Pali Rohár pali.rohar@gmail.com
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2015-12-24 20:00 +0100 |
| Subject | Re: [PATCH 2/2] OMAP: RX51: save ATAGS data in the early boot stage |
| Message-ID | <qJjhf-1Rs-9@gated-at.bofh.it> |
| In reply to | #1298014 |
* Pali Rohár <pali.rohar@gmail.com> [151224 09:49]: > On Thursday 24 December 2015 17:37:56 Ivaylo Dimitrov wrote: > > Nokia N900 (RX51) legacy userspace needs various ATAGS passed by the > > bootloader (boot reason, device serial, boot mode, various GPIO > > swithes, etc). Save that data early enough in the boot process, so > > it can be exported later in /proc/atags > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > > Working fine in qemu. > > Tested-by: Pali Rohár <pali.rohar@gmail.com> Maybe update the description to say "This fixes a regression with device tree based booting compared to legacy booting for n900 to make the n900 legacy user space to also work with device tree based booting". It would be nice to get these two in as fixes after -rc1 assuming people have no objections to it. So please upload this one also into Russell's patch system after no more comments: Acked-by: Tony Lindgren <tony@atomide.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| Date | 2016-01-01 12:50 +0100 |
| Subject | Re: [PATCH 2/2] OMAP: RX51: save ATAGS data in the early boot stage |
| Message-ID | <qM6nw-1Vt-5@gated-at.bofh.it> |
| In reply to | #1298026 |
Hi, On 24.12.2015 20:56, Tony Lindgren wrote: > > Maybe update the description to say "This fixes a regression with > device tree based booting compared to legacy booting for n900 to > make the n900 legacy user space to also work with device tree based > booting". > OK, will do. > It would be nice to get these two in as fixes after -rc1 assuming > people have no objections to it. So please upload this one also > into Russell's patch system after no more comments: > Seems there are no more comments (and objections) so I will *try* to upload the patches in Russell's patch system. Will pester you to do it for me if I fail to do so :) > Acked-by: Tony Lindgren <tony@atomide.com> > Thanks, Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| Date | 2015-12-24 17:50 +0100 |
| Subject | [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h |
| Message-ID | <qJhfr-GU-9@gated-at.bofh.it> |
| In reply to | #1298007 |
So it can be used by code outside arch/arm/kernel/. Fix save_atags()
declaration to match its definition while at it.
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
arch/arm/include/asm/setup.h | 6 ++++++
arch/arm/kernel/atags.h | 6 ------
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h
index e0adb9f..3613d7e 100644
--- a/arch/arm/include/asm/setup.h
+++ b/arch/arm/include/asm/setup.h
@@ -25,4 +25,10 @@ extern int arm_add_memory(u64 start, u64 size);
extern void early_print(const char *str, ...);
extern void dump_machine_table(void);
+#ifdef CONFIG_ATAGS_PROC
+extern void save_atags(const struct tag *tags);
+#else
+static inline void save_atags(const struct tag *tags) { }
+#endif
+
#endif
diff --git a/arch/arm/kernel/atags.h b/arch/arm/kernel/atags.h
index ec4164d..edfa226 100644
--- a/arch/arm/kernel/atags.h
+++ b/arch/arm/kernel/atags.h
@@ -1,9 +1,3 @@
-#ifdef CONFIG_ATAGS_PROC
-extern void save_atags(struct tag *tags);
-#else
-static inline void save_atags(struct tag *tags) { }
-#endif
-
void convert_to_tag_list(struct tag *tags);
#ifdef CONFIG_ATAGS
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2015-12-24 18:50 +0100 |
| Subject | Re: [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h |
| Message-ID | <qJibv-1fE-15@gated-at.bofh.it> |
| In reply to | #1298010 |
[Multipart message — attachments visible in raw view] — view raw
On Thursday 24 December 2015 17:37:55 Ivaylo Dimitrov wrote: > So it can be used by code outside arch/arm/kernel/. Fix save_atags() > declaration to match its definition while at it. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Tested-by: Pali Rohár <pali.rohar@gmail.com> -- Pali Rohár pali.rohar@gmail.com
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2015-12-24 20:00 +0100 |
| Subject | Re: [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h |
| Message-ID | <qJjhf-1Rs-3@gated-at.bofh.it> |
| In reply to | #1298019 |
* Pali Rohár <pali.rohar@gmail.com> [151224 09:48]: > On Thursday 24 December 2015 17:37:55 Ivaylo Dimitrov wrote: > > So it can be used by code outside arch/arm/kernel/. Fix save_atags() > > declaration to match its definition while at it. > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > > Tested-by: Pali Rohár <pali.rohar@gmail.com> Nice, please upload both to Russell's patch system after no more comments: Acked-by: Tony Lindgren <tony@atomide.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| Date | 2015-12-24 20:10 +0100 |
| Subject | Re: [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h |
| Message-ID | <qJjqV-29P-3@gated-at.bofh.it> |
| In reply to | #1298025 |
On 24.12.2015 20:53, Tony Lindgren wrote: > * Pali Rohár <pali.rohar@gmail.com> [151224 09:48]: >> On Thursday 24 December 2015 17:37:55 Ivaylo Dimitrov wrote: >>> So it can be used by code outside arch/arm/kernel/. Fix save_atags() >>> declaration to match its definition while at it. >>> >>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> >> >> Tested-by: Pali Rohár <pali.rohar@gmail.com> > > Nice, please upload both to Russell's patch system after no > more comments: > > Acked-by: Tony Lindgren <tony@atomide.com> > Hi Tony, Could you elaborate on that patch system? Where it is and do I need some special account/access? Regards, Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> |
|---|---|
| Date | 2015-12-24 15:10 +0100 |
| Subject | [PATCH 3/3] OMAP: RX51: save ATAGS data in the early boot stage |
| Message-ID | <qJeKC-7HG-11@gated-at.bofh.it> |
| In reply to | #1297866 |
Nokia N900 (RX51) legacy userspace needs various ATAGS passed by the
bootloader (boot reason, device serial, boot mode, various GPIO swithes,
etc). Save that data early enough in the boot process, so it can be
exported later in /proc/atags
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
arch/arm/mach-omap2/board-generic.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
index 04a56cc..594eefe 100644
--- a/arch/arm/mach-omap2/board-generic.c
+++ b/arch/arm/mach-omap2/board-generic.c
@@ -17,6 +17,7 @@
#include <linux/irqdomain.h>
#include <asm/mach/arch.h>
+#include <asm/atags.h>
#include "common.h"
@@ -76,8 +77,17 @@ static const char *const n900_boards_compat[] __initconst = {
NULL,
};
+/* Legacy userspace on Nokia N900 needs ATAGS exported in /proc/atags,
+ * save them while the data is still there
+ */
+static void __init rx51_reserve(void)
+{
+ save_atags((const struct tag *)(PAGE_OFFSET + 0x100));
+ omap_reserve();
+}
+
DT_MACHINE_START(OMAP3_N900_DT, "Nokia RX-51 board")
- .reserve = omap_reserve,
+ .reserve = rx51_reserve,
.map_io = omap3_map_io,
.init_early = omap3430_init_early,
.init_machine = omap_generic_init,
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-12-24 17:00 +0100 |
| Message-ID | <qJgt5-aL-31@gated-at.bofh.it> |
| In reply to | #1297866 |
On Thursday 24 December 2015, Ivaylo Dimitrov wrote: > Nokia N900 legacy userspace needs ATAGS passed by the bootloder to be > available in /proc/atags. With DT booted kernel this information is > no longer availabe. Fix that by saving ATAGS data early in the boot > stage so it can be exported in /proc/atags later Looks ok to me. Acked-by: Arnd Bergmann <arnd@arndb.de> Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web