Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295119 > unrolled thread

[PATCH] usb: gadget: rndis: fix itnull.cocci warnings

Back to article view | Back to linux.kernel

Contents

  [PATCH] usb: gadget: rndis: fix itnull.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2015-12-18 21:10 +0100
    Re: [PATCH] usb: gadget: rndis: fix itnull.cocci warnings Felipe Balbi <balbi@ti.com> - 2015-12-22 19:20 +0100
      Re: [PATCH] usb: gadget: rndis: fix itnull.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2015-12-22 19:20 +0100
        Re: [PATCH] usb: gadget: rndis: fix itnull.cocci warnings Felipe Balbi <balbi@ti.com> - 2015-12-22 19:30 +0100

#1295119 — [PATCH] usb: gadget: rndis: fix itnull.cocci warnings

The index variable of list_for_each_entry_safe is never NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Geliang Tang <geliangtang@163.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

 rndis.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/gadget/function/rndis.c
+++ b/drivers/usb/gadget/function/rndis.c
@@ -1009,7 +1009,7 @@ void rndis_free_response(struct rndis_pa
 	rndis_resp_t *r, *n;
 
 	list_for_each_entry_safe(r, n, &params->resp_queue, list) {
-		if (r && r->buf == buf) {
+		if (r->buf == buf) {
 			list_del(&r->list);
 			kfree(r);
 		}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1296952

[Multipart message — attachments visible in raw view] — view raw

Julia Lawall <julia.lawall@lip6.fr> writes:

> The index variable of list_for_each_entry_safe is never NULL.
>
> Generated by: scripts/coccinelle/iterators/itnull.cocci
>
> CC: Geliang Tang <geliangtang@163.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

doesn't apply. Does this depend on anything ?

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1296959

On Tue, 22 Dec 2015, Felipe Balbi wrote:

> Julia Lawall <julia.lawall@lip6.fr> writes:
>
> > The index variable of list_for_each_entry_safe is never NULL.
> >
> > Generated by: scripts/coccinelle/iterators/itnull.cocci
> >
> > CC: Geliang Tang <geliangtang@163.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>
> doesn't apply. Does this depend on anything ?

It may be derived from a patch posted to a mailing list.  I don't have the
original reference any more.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1296966

[Multipart message — attachments visible in raw view] — view raw

Hi,

Julia Lawall <julia.lawall@lip6.fr> writes:
> On Tue, 22 Dec 2015, Felipe Balbi wrote:
>
>> Julia Lawall <julia.lawall@lip6.fr> writes:
>>
>> > The index variable of list_for_each_entry_safe is never NULL.
>> >
>> > Generated by: scripts/coccinelle/iterators/itnull.cocci
>> >
>> > CC: Geliang Tang <geliangtang@163.com>
>> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>>
>> doesn't apply. Does this depend on anything ?
>
> It may be derived from a patch posted to a mailing list.  I don't have the
> original reference any more.

okay, it could be the big series converting gadgets to
list_for_each_entry_safe(). Thanks

-- 
balbi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web