Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1296567 > unrolled thread

[PATCH] s390: fix build failure

Started bySudip Mukherjee <sudipm.mukherjee@gmail.com>
First post2015-12-22 07:50 +0100
Last post2015-12-22 08:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] s390: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-22 07:50 +0100
    Re: [PATCH] s390: fix build failure Dan Williams <dan.j.williams@intel.com> - 2015-12-22 08:00 +0100

#1296567 — [PATCH] s390: fix build failure

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-12-22 07:50 +0100
Subject[PATCH] s390: fix build failure
Message-ID<qIoVH-qe-3@gated-at.bofh.it>
s390 defconfig fails with the error:
ERROR: "phys_to_pfn_t" [drivers/s390/block/dcssblk.ko] undefined!

We need CONFIG_HAS_IOMEM for phys_to_pfn_t() and for that we need to
have CONFIG_PCI.

Fixes: bfac97e7b361 ("mm, dax, pmem: introduce pfn_t")
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

s390 defconfig with next-20151222 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/98258271

 arch/s390/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/s390/defconfig b/arch/s390/defconfig
index 9256b48..e56b6df 100644
--- a/arch/s390/defconfig
+++ b/arch/s390/defconfig
@@ -207,3 +207,4 @@ CONFIG_CRC7=m
 # CONFIG_XZ_DEC_ARMTHUMB is not set
 # CONFIG_XZ_DEC_SPARC is not set
 CONFIG_CMM=m
+CONFIG_PCI=y
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1296570

FromDan Williams <dan.j.williams@intel.com>
Date2015-12-22 08:00 +0100
Message-ID<qIp5o-ty-3@gated-at.bofh.it>
In reply to#1296567
On Mon, Dec 21, 2015 at 10:40 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> s390 defconfig fails with the error:
> ERROR: "phys_to_pfn_t" [drivers/s390/block/dcssblk.ko] undefined!
>
> We need CONFIG_HAS_IOMEM for phys_to_pfn_t() and for that we need to
> have CONFIG_PCI.
>
> Fixes: bfac97e7b361 ("mm, dax, pmem: introduce pfn_t")
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---

Hi, I fixed this build breakage in v4 of the patch series that
introduces phys_to_pfn_t() [1].  Chnaging the config is not correct
the HAS_IOMEM dependency for the symbol needs to be satisfied.

[1]: https://lists.01.org/pipermail/linux-nvdimm/2015-December/003610.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web