Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297350 > unrolled thread

[PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
    [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
      Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS  GPIO Mark Brown <broonie@kernel.org> - 2015-12-23 12:50 +0100
        Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS  GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 13:00 +0100
          Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS  GPIO Mark Brown <broonie@kernel.org> - 2015-12-23 13:00 +0100
    [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
      Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-23 13:00 +0100
        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 14:00 +0100
        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-24 19:20 +0100
          Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-24 20:40 +0100
            Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-24 21:10 +0100
        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100
          Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 00:00 +0100
            Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-29 01:50 +0100
              Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 12:20 +0100
                Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-30 01:30 +0100
                  Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-30 09:40 +0100
                    Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-30 17:40 +0100
                      Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-30 19:40 +0100
                        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-31 23:00 +0100
                          Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-31 23:20 +0100
                        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-31 23:00 +0100
      Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100
      Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Rob Herring <robh@kernel.org> - 2015-12-29 21:10 +0100
        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 22:30 +0100
          Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Rob Herring <robh@kernel.org> - 2015-12-29 23:00 +0100
    [PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
    [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
      Applied "regulator: lp872x: Get rid of duplicate reference to DVS GPIO" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-12-23 13:20 +0100
      Re: [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to  DVS GPIO Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1299789 — Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

[Multipart message — attachments visible in raw view] — view raw

On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote:

> I understand, thanks for pointing this out. Well, for my use case, there
> is no use in disabling the chip at any point as it powers the external
> mmc.

Presumably someone might decide not to use the MMC in some case (perhaps
only mounting it when explicitly needed in order to save power for
example, or the MMC subsystem might figure out a way to power down an
idle MMC block device).

> Would you agree to have the enable pin handled directly (and by that, I
> mean enabled once, when requested, as I first suggested in the patchset)
> in the driver then?

That's probably fine, or do it via runtime PM (the framework is fairly
simple to use, I'll probably go add support in the core for it in the
next day or two as this seems like a sensible use case).  I can't
remember if this device is a MFD or not and I'm just on my way out the
door.

[toc] | [prev] | [next] | [standalone]

#1299784 — Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

[Multipart message — attachments visible in raw view] — view raw

On Wed, Dec 30, 2015 at 07:37:19PM +0100, Paul Kocialkowski wrote:
> Le mercredi 30 décembre 2015 à 16:33 +0000, Mark Brown a écrit :
> > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote:

> > > In my opinion, it would be more elegant to adapt the core regulator
> > > framework to first enable the GPIO and then call the regulator enable
> > > ops callback instead of handling the GPIO in the driver.

> > Why would we want to actively manage both things at runtime?  It's more
> > work, what do we gain from it?

> Well, I figured that it would be best to disable the EN pin when we're
> not using any of the regulators, since that allows the chip to enter
> standby mode (and thus consume less power).

This doesn't sound like it's anything to do with the regulators, that's
a chip wide power management function which should be implemented via
runtime PM if there's any value in implementing it at all (if the device
is a primary PMIC normally this would be handled by the CPU core when it
enters low power state without any software).  It's not something we
should be considering on a per regulator basis since it's at the chip
level and on a per regulator basis it's not doing anything useful for
the reasons above.

> It also doesn't hurt regulators that only use a GPIO for enable.

It causes problems for any device with an optional GPIO,  it means that
we end up mantaining both GPIO and register which as I've said a couple
of times now defeats the point of having the GPIO.

[toc] | [prev] | [next] | [standalone]

#1298435 — Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

Hi Paul,

Thanks for the patches. Please see my comments below.

On 23/12/15 19:58, Paul Kocialkowski wrote:
> LP872x regulators are made active via the EN pin, which might be hooked to a
> GPIO. This adds support for driving the GPIO high when the driver is in use.

EN pin is used for enabling HW logic like I2C block. It's not regulator 
enable pin. Please check the block diagram in the datasheet.

All regulators of LP8720 and LP8725 are controlled through I2C 
registers. Additionally, LP8725 provides external pin control for LDO3 
and BUCK2. In this case, you can use 'regulator_config.ena_gpio' when a 
regulator is registered.

>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>   .../devicetree/bindings/regulator/lp872x.txt       |  1 +
>   drivers/regulator/lp872x.c                         | 33 ++++++++++++++++++++--
>   include/linux/regulator/lp872x.h                   |  2 ++
>   3 files changed, 33 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
> index 7818318..0559c25 100644
> --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
> +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
> @@ -28,6 +28,7 @@ Optional properties:
>     - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
>     - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
>     - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
> +  - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.

Please use general property, "enable-gpios" instead of "ti,enable-gpio".

>
>     Sub nodes for regulator_init_data
>       LP8720 has maximum 6 nodes. (child name: ldo1 ~ 5 and buck)
> diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
> index 21c49d8..c8855f3 100644
> --- a/drivers/regulator/lp872x.c
> +++ b/drivers/regulator/lp872x.c
> @@ -726,6 +726,27 @@ static struct regulator_desc lp8725_regulator_desc[] = {
>   	},
>   };
>
> +static int lp872x_init_enable(struct lp872x *lp)

lp872x_enable_hw() would be better.

> +{
> +	int ret, gpio;
> +
> +	if (!lp->pdata)
> +		return -EINVAL;
> +
> +	gpio = lp->pdata->enable_gpio;
> +	if (!gpio_is_valid(gpio))
> +		return 0;
> +
> +	/* Always set enable GPIO high. */
> +	ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X EN");
> +	if (ret) {
> +		dev_err(lp->dev, "gpio request err: %d\n", ret);
> +		return ret;
> +	}

LP8720 device needs max 200usec for startup time.
LP8725 also requires enable time about 30ms.
Please use usleep_range() after EN pin control.

> +
> +	return 0;
> +}
> +
>   static int lp872x_init_dvs(struct lp872x *lp)
>   {
>   	int ret, gpio;
> @@ -763,14 +784,18 @@ static int lp872x_config(struct lp872x *lp)
>   	int ret;
>
>   	if (!pdata || !pdata->update_config)
> -		goto init_dvs;
> +		goto init_dvs_enable;
>
>   	ret = lp872x_write_byte(lp, LP872X_GENERAL_CFG, pdata->general_config);
>   	if (ret)
>   		return ret;
>
> -init_dvs:
> -	return lp872x_init_dvs(lp);
> +init_dvs_enable:
> +	ret = lp872x_init_dvs(lp);
> +	if (ret)
> +		return ret;
> +
> +	return lp872x_init_enable(lp);
>   }

Logic should be enabled prior to DVS configuration. And please call 
lp872x_enable_hw() in _probe().

>
>   static struct regulator_init_data
> @@ -875,6 +900,8 @@ static struct lp872x_platform_data
>   	of_property_read_u8(np, "ti,dvs-state", &dvs_state);
>   	pdata->dvs->init_state = dvs_state ? DVS_HIGH : DVS_LOW;
>
> +	pdata->enable_gpio = of_get_named_gpio(np, "ti,enable-gpio", 0);
> +

Please replace "ti,enable-gpio" with "enable-gpios".

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299108 — Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote:
> LP872x regulators are made active via the EN pin, which might be hooked to a
> GPIO. This adds support for driving the GPIO high when the driver is in use.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  .../devicetree/bindings/regulator/lp872x.txt       |  1 +
>  drivers/regulator/lp872x.c                         | 33 ++++++++++++++++++++--
>  include/linux/regulator/lp872x.h                   |  2 ++
>  3 files changed, 33 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
> index 7818318..0559c25 100644
> --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
> +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
> @@ -28,6 +28,7 @@ Optional properties:
>    - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
>    - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
>    - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
> +  - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.

Should be "-gpios" instead of "-gpio".

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1299143 — Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

[Multipart message — attachments visible in raw view] — view raw

Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit :
> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote:
> > LP872x regulators are made active via the EN pin, which might be hooked to a
> > GPIO. This adds support for driving the GPIO high when the driver is in use.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  .../devicetree/bindings/regulator/lp872x.txt       |  1 +
> >  drivers/regulator/lp872x.c                         | 33 ++++++++++++++++++++--
> >  include/linux/regulator/lp872x.h                   |  2 ++
> >  3 files changed, 33 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
> > index 7818318..0559c25 100644
> > --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
> > +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
> > @@ -28,6 +28,7 @@ Optional properties:
> >    - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
> >    - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
> >    - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
> > +  - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.
> 
> Should be "-gpios" instead of "-gpio".

Care to comment why? There is only one GPIO that can be used here, since
there is only one single EN pin. I thought this matched what is done
already with "ti,dvs-gpio".

Thanks!

[toc] | [prev] | [next] | [standalone]

#1299151 — Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

On Tue, Dec 29, 2015 at 3:26 PM, Paul Kocialkowski <contact@paulk.fr> wrote:
> Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit :
>> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote:
>> > LP872x regulators are made active via the EN pin, which might be hooked to a
>> > GPIO. This adds support for driving the GPIO high when the driver is in use.
>> >
>> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>> > ---
>> >  .../devicetree/bindings/regulator/lp872x.txt       |  1 +
>> >  drivers/regulator/lp872x.c                         | 33 ++++++++++++++++++++--
>> >  include/linux/regulator/lp872x.h                   |  2 ++
>> >  3 files changed, 33 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
>> > index 7818318..0559c25 100644
>> > --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
>> > +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
>> > @@ -28,6 +28,7 @@ Optional properties:
>> >    - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
>> >    - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
>> >    - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
>> > +  - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.
>>
>> Should be "-gpios" instead of "-gpio".
>
> Care to comment why? There is only one GPIO that can be used here, since
> there is only one single EN pin. I thought this matched what is done
> already with "ti,dvs-gpio".

To be consistent. We use "clocks" and "interrupts" always whether one
or more for example.

-gpio is documented as deprecated now.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1297362 — [PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support

The LP872x regulator is used in the LG Optimus Black (P970) codename sniper
to supply the external mmc card.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 69a22fd..e2c01f0 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -425,6 +425,7 @@ CONFIG_REGULATOR_RK808=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_MFD_SYSCON=y
 CONFIG_POWER_RESET_SYSCON=y
+CONFIG_REGULATOR_LP872X=y
 CONFIG_REGULATOR_MAX14577=m
 CONFIG_REGULATOR_MAX8907=y
 CONFIG_REGULATOR_MAX8973=y
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1297363 — [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO

The lp872x structure holds a reference to the DVS GPIO, but it is never actually
used anywhere, since a first reference exists from the lp872x_dvs structure.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 drivers/regulator/lp872x.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
index 9412353..19d7584 100644
--- a/drivers/regulator/lp872x.c
+++ b/drivers/regulator/lp872x.c
@@ -108,7 +108,6 @@ struct lp872x {
 	struct lp872x_platform_data *pdata;
 	int num_regulators;
 	enum lp872x_dvs_state dvs_pin;
-	int dvs_gpio;
 };
 
 /* LP8720/LP8725 shared voltage table for LDOs */
@@ -752,7 +751,6 @@ static int lp872x_init_dvs(struct lp872x *lp)
 	}
 
 	lp->dvs_pin = pinstate;
-	lp->dvs_gpio = gpio;
 
 	return 0;
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1297411 — Applied "regulator: lp872x: Get rid of duplicate reference to DVS GPIO" to the regulator tree

The patch

   regulator: lp872x: Get rid of duplicate reference to DVS GPIO

has been applied to the regulator tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 8a99cc6ff5710780e3d9bfc41027c142725089e5 Mon Sep 17 00:00:00 2001
From: Paul Kocialkowski <contact@paulk.fr>
Date: Wed, 23 Dec 2015 11:58:35 +0100
Subject: [PATCH] regulator: lp872x: Get rid of duplicate reference to DVS GPIO

The lp872x structure holds a reference to the DVS GPIO, but it is never actually
used anywhere, since a first reference exists from the lp872x_dvs structure.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/lp872x.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
index 9412353da622..19d758486553 100644
--- a/drivers/regulator/lp872x.c
+++ b/drivers/regulator/lp872x.c
@@ -108,7 +108,6 @@ struct lp872x {
 	struct lp872x_platform_data *pdata;
 	int num_regulators;
 	enum lp872x_dvs_state dvs_pin;
-	int dvs_gpio;
 };
 
 /* LP8720/LP8725 shared voltage table for LDOs */
@@ -752,7 +751,6 @@ static int lp872x_init_dvs(struct lp872x *lp)
 	}
 
 	lp->dvs_pin = pinstate;
-	lp->dvs_gpio = gpio;
 
 	return 0;
 
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1298446 — Re: [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO

On 23/12/15 19:58, Paul Kocialkowski wrote:
> The lp872x structure holds a reference to the DVS GPIO, but it is never actually
> used anywhere, since a first reference exists from the lp872x_dvs structure.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>

Acked-by: Milo Kim <milo.kim@ti.com>

> ---
>   drivers/regulator/lp872x.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
> index 9412353..19d7584 100644
> --- a/drivers/regulator/lp872x.c
> +++ b/drivers/regulator/lp872x.c
> @@ -108,7 +108,6 @@ struct lp872x {
>   	struct lp872x_platform_data *pdata;
>   	int num_regulators;
>   	enum lp872x_dvs_state dvs_pin;
> -	int dvs_gpio;
>   };
>
>   /* LP8720/LP8725 shared voltage table for LDOs */
> @@ -752,7 +751,6 @@ static int lp872x_init_dvs(struct lp872x *lp)
>   	}
>
>   	lp->dvs_pin = pinstate;
> -	lp->dvs_gpio = gpio;
>
>   	return 0;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web