Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292053 > unrolled thread

[PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()

Back to article view | Back to linux.kernel

Contents

  [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() Sudeep Holla <sudeep.holla@arm.com> - 2015-12-15 12:20 +0100
    Re: [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() Sudeep Holla <sudeep.holla@arm.com> - 2015-12-23 12:30 +0100
      Re: [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-24 02:20 +0100
        Re: [PATCH] cpufreq: scpi-cpufreq: signedness bug in  scpi_get_dvfs_info() Sudeep Holla <sudeep.holla@arm.com> - 2015-12-24 11:00 +0100

#1292053 — [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()

From: Dan Carpenter <dan.carpenter@oracle.com>

The "domain" variable needs to be signed for the error handling to work.

Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/cpufreq/scpi-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Rafael,

This patch seem to have slipped through the cracks somehow. I don't see
in patchwork too. So I am resending so that you can pick for your next
rc fix if you plan to send one else for -next

Regards,
Sudeep

diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 2c3b16fd3a01..de5e89b2eaaa 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;

 static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
 {
-	u8 domain = topology_physical_package_id(cpu_dev->id);
+	int domain = topology_physical_package_id(cpu_dev->id);

 	if (domain < 0)
 		return ERR_PTR(-EINVAL);
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1297379

Hi Rafael,

On Tue, Dec 15, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> The "domain" variable needs to be signed for the error handling to work.
>
> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/cpufreq/scpi-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Rafael,
>
> This patch seem to have slipped through the cracks somehow. I don't see
> in patchwork too. So I am resending so that you can pick for your next
> rc fix if you plan to send one else for -next
>

This got missed again, can you please ensure to pull this for your next -rc.
If you have none planned, please pull this for-next.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1297711

On Wednesday, December 23, 2015 11:20:04 AM Sudeep Holla wrote:
> Hi Rafael,
> 
> On Tue, Dec 15, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > The "domain" variable needs to be signed for the error handling to work.
> >
> > Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> >  drivers/cpufreq/scpi-cpufreq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Hi Rafael,
> >
> > This patch seem to have slipped through the cracks somehow. I don't see
> > in patchwork too. So I am resending so that you can pick for your next
> > rc fix if you plan to send one else for -next
> >
> 
> This got missed again, can you please ensure to pull this for your next -rc.
> If you have none planned, please pull this for-next.

Applied now, thanks!

I'm going to push it for -rc7.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1297799 — Re: [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()

On 24/12/15 01:45, Rafael J. Wysocki wrote:
> On Wednesday, December 23, 2015 11:20:04 AM Sudeep Holla wrote:
>> Hi Rafael,
>>
>> On Tue, Dec 15, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>> From: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>> The "domain" variable needs to be signed for the error handling to work.
>>>
>>> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>>> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>>> ---
>>>   drivers/cpufreq/scpi-cpufreq.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> Hi Rafael,
>>>
>>> This patch seem to have slipped through the cracks somehow. I don't see
>>> in patchwork too. So I am resending so that you can pick for your next
>>> rc fix if you plan to send one else for -next
>>>
>>
>> This got missed again, can you please ensure to pull this for your next -rc.
>> If you have none planned, please pull this for-next.
>
> Applied now, thanks!
>
> I'm going to push it for -rc7.
>

Thanks, sorry for the nags.

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web