Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297377 > unrolled thread

[PATCH 0/3] clockevents/arm: Implement ->set_state_oneshot_stopped()

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] clockevents/arm: Implement ->set_state_oneshot_stopped() Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-23 12:30 +0100
    [PATCH 1/3] clockevents/arm_arch_timer: Implement ->set_state_oneshot_stopped() Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-23 12:30 +0100

#1297377 — [PATCH 0/3] clockevents/arm: Implement ->set_state_oneshot_stopped()

Hi Daniel/Thomas,

ONESHOT-STOPPED state was merged into mainline sometime back and doesn't
have any users until now.

This series implements the set_state_oneshot_stopped() callback for few
ARM clkevt drivers.

Which other clkevt drivers will you advice to update, if any?

Tested on ARM Exynos 5250 dual A15 board (1/3 and 3/3, 2/3 is compile
tested only but is changed as many ARM SoCs use it).
Rebased on v4.4-rc6.

Viresh Kumar (3):
  clockevents/arm_arch_timer: Implement ->set_state_oneshot_stopped()
  clockevents/arm_global_timer: Implement ->set_state_oneshot_stopped()
  clockevents/exynos_mct: Implement ->set_state_oneshot_stopped()

 drivers/clocksource/arm_arch_timer.c   | 4 ++++
 drivers/clocksource/arm_global_timer.c | 1 +
 drivers/clocksource/exynos_mct.c       | 2 ++
 3 files changed, 7 insertions(+)

-- 
2.7.0.rc1.186.g94414c4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1297378 — [PATCH 1/3] clockevents/arm_arch_timer: Implement ->set_state_oneshot_stopped()

set_state_oneshot_stopped() is called by the clkevt core, when the next
event is required at an expiry time of 'KTIME_MAX'. This normally
happens with NO_HZ_{IDLE|FULL} in both LOWRES/HIGHRES modes.

This patch makes the clockevent device to stop on such an event, to
avoid spurious interrupts, as explained by: commit 8fff52fd5093
("clockevents: Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state").

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/clocksource/arm_arch_timer.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index c64d543d64bf..c816823888c0 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -266,10 +266,12 @@ static void __arch_timer_setup(unsigned type,
 		if (arch_timer_use_virtual) {
 			clk->irq = arch_timer_ppi[VIRT_PPI];
 			clk->set_state_shutdown = arch_timer_shutdown_virt;
+			clk->set_state_oneshot_stopped = arch_timer_shutdown_virt;
 			clk->set_next_event = arch_timer_set_next_event_virt;
 		} else {
 			clk->irq = arch_timer_ppi[PHYS_SECURE_PPI];
 			clk->set_state_shutdown = arch_timer_shutdown_phys;
+			clk->set_state_oneshot_stopped = arch_timer_shutdown_phys;
 			clk->set_next_event = arch_timer_set_next_event_phys;
 		}
 	} else {
@@ -279,10 +281,12 @@ static void __arch_timer_setup(unsigned type,
 		clk->cpumask = cpu_all_mask;
 		if (arch_timer_mem_use_virtual) {
 			clk->set_state_shutdown = arch_timer_shutdown_virt_mem;
+			clk->set_state_oneshot_stopped = arch_timer_shutdown_virt_mem;
 			clk->set_next_event =
 				arch_timer_set_next_event_virt_mem;
 		} else {
 			clk->set_state_shutdown = arch_timer_shutdown_phys_mem;
+			clk->set_state_oneshot_stopped = arch_timer_shutdown_phys_mem;
 			clk->set_next_event =
 				arch_timer_set_next_event_phys_mem;
 		}
-- 
2.7.0.rc1.186.g94414c4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web