Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1296723 > unrolled thread
| Started by | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| First post | 2015-12-22 12:10 +0100 |
| Last post | 2015-12-23 10:00 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031. Andrew Lunn <andrew@lunn.ch> - 2015-12-22 12:10 +0100
Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031. David Miller <davem@davemloft.net> - 2015-12-22 23:20 +0100
Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031. Henri Roosen <henri.roosen@ginzinger.com> - 2015-12-23 09:30 +0100
Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031. David Miller <davem@davemloft.net> - 2015-12-23 17:40 +0100
Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031. Henri Roosen <henri.roosen@ginzinger.com> - 2015-12-23 10:00 +0100
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2015-12-22 12:10 +0100 |
| Subject | Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031. |
| Message-ID | <qIsZj-3ag-11@gated-at.bofh.it> |
On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote:
> Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC
> node.") only fixes finding PHY properties in MAC node for KSZ9021. This
> commit applies the same fix for KSZ9031.
>
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not the bus' parent.")
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> drivers/net/phy/micrel.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index e13ad6c..fc6c058 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -470,9 +470,18 @@ static int ksz9031_config_init(struct phy_device *phydev)
> "txd2-skew-ps", "txd3-skew-ps"
> };
> static const char *control_skews[2] = {"txen-skew-ps", "rxdv-skew-ps"};
> + const struct device *dev_walker;
>
> - if (!of_node && dev->parent->of_node)
> - of_node = dev->parent->of_node;
> + /* The Micrel driver has a deprecated option to place phy OF
> + * properties in the MAC node. Walk up the tree of devices to
> + * find a device with an OF node.
> + */
> + dev_walker = &phydev->dev;
> + do {
> + of_node = dev_walker->of_node;
> + dev_walker = dev_walker->parent;
> +
> + } while (!of_node && dev_walker);
>
> if (of_node) {
> ksz9031_of_load_skew_values(phydev, of_node,
> --
> 2.1.4
>
>
> ________________________________
>
> Ginzinger electronic systems GmbH
> Gewerbegebiet Pirath 16
> 4952 Weng im Innkreis
> www.ginzinger.com
>
> Firmenbuchnummer: FN 364958d
> Firmenbuchgericht: Ried im Innkreis
> UID-Nr.: ATU66521089
>
> ________________________________
> *** WEIHNACHTSURLAUB VON DONNERSTAG, DEN 24. DEZEMBER 2015 BIS MITTWOCH, DEN 6. JAENNER 2016 ***
> *** CHRISTMAS VACATION FROM THURSDAY, THE 24 DECEMBER 2015 TO WEDNESDAY, 6 JANUARY 2016 ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-12-22 23:20 +0100 |
| Subject | Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031. |
| Message-ID | <qIDrH-1g9-3@gated-at.bofh.it> |
| In reply to | #1296723 |
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 22 Dec 2015 12:06:34 +0100
> On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote:
>> Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC
>> node.") only fixes finding PHY properties in MAC node for KSZ9021. This
>> commit applies the same fix for KSZ9031.
>>
>> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
>
> Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not the bus' parent.")
>
> Acked-by: Andrew Lunn <andrew@lunn.ch>
This does not apply cleanly to any of my trees.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Henri Roosen <henri.roosen@ginzinger.com> |
|---|---|
| Date | 2015-12-23 09:30 +0100 |
| Message-ID | <qIMY2-7ed-1@gated-at.bofh.it> |
| In reply to | #1297094 |
On 12/22/2015 11:14 PM, David Miller wrote:
> From: Andrew Lunn <andrew@lunn.ch>
> Date: Tue, 22 Dec 2015 12:06:34 +0100
>
>> On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote:
>>> Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC
>>> node.") only fixes finding PHY properties in MAC node for KSZ9021. This
>>> commit applies the same fix for KSZ9031.
>>>
>>> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
>>
>> Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not the bus' parent.")
>>
>> Acked-by: Andrew Lunn <andrew@lunn.ch>
>
> This does not apply cleanly to any of my trees.
David, does the original patch not apply cleanly or is your comment only
on the message from Andrew?
Else please let me know what is wrong with the original patch. I've
tested it applies cleanly to v4.4-rc6 and to v4.3.
>
________________________________
Ginzinger electronic systems GmbH
Gewerbegebiet Pirath 16
4952 Weng im Innkreis
www.ginzinger.com
Firmenbuchnummer: FN 364958d
Firmenbuchgericht: Ried im Innkreis
UID-Nr.: ATU66521089
________________________________
*** WEIHNACHTSURLAUB VON DONNERSTAG, DEN 24. DEZEMBER 2015 BIS MITTWOCH, DEN 6. JAENNER 2016 ***
*** CHRISTMAS VACATION FROM THURSDAY, THE 24 DECEMBER 2015 TO WEDNESDAY, 6 JANUARY 2016 ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-12-23 17:40 +0100 |
| Subject | Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031. |
| Message-ID | <qIUCf-3A4-35@gated-at.bofh.it> |
| In reply to | #1297271 |
From: Henri Roosen <henri.roosen@ginzinger.com>
Date: Wed, 23 Dec 2015 09:11:22 +0100
> On 12/22/2015 11:14 PM, David Miller wrote:
>> From: Andrew Lunn <andrew@lunn.ch>
>> Date: Tue, 22 Dec 2015 12:06:34 +0100
>>
>>> On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote:
>>>> Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC
>>>> node.") only fixes finding PHY properties in MAC node for
>>>> KSZ9021. This
>>>> commit applies the same fix for KSZ9031.
>>>>
>>>> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
>>>
>>> Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus,
>>> not the bus' parent.")
>>>
>>> Acked-by: Andrew Lunn <andrew@lunn.ch>
>>
>> This does not apply cleanly to any of my trees.
>
> David, does the original patch not apply cleanly or is your comment
> only
> on the message from Andrew?
>
> Else please let me know what is wrong with the original patch. I've
> tested it applies cleanly to v4.4-rc6 and to v4.3.
Your original patch did not apply cleanly.
All patches must be against either my 'net' or 'net-next' trees. And
you must explicitly state what tree your patch is against and therefore
which tree you expect me to apply it too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Henri Roosen <henri.roosen@ginzinger.com> |
|---|---|
| Date | 2015-12-23 10:00 +0100 |
| Message-ID | <qINr4-7o4-3@gated-at.bofh.it> |
| In reply to | #1297094 |
On 12/22/2015 11:14 PM, David Miller wrote:
> From: Andrew Lunn <andrew@lunn.ch>
> Date: Tue, 22 Dec 2015 12:06:34 +0100
>
>> On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote:
>>> Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC
>>> node.") only fixes finding PHY properties in MAC node for KSZ9021. This
>>> commit applies the same fix for KSZ9031.
>>>
>>> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
>>
>> Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not the bus' parent.")
>>
>> Acked-by: Andrew Lunn <andrew@lunn.ch>
>
> This does not apply cleanly to any of my trees.
Found the problem. It's the mail server. Will send a correct patch later.
>
________________________________
Ginzinger electronic systems GmbH
Gewerbegebiet Pirath 16
4952 Weng im Innkreis
www.ginzinger.com
Firmenbuchnummer: FN 364958d
Firmenbuchgericht: Ried im Innkreis
UID-Nr.: ATU66521089
________________________________
*** WEIHNACHTSURLAUB VON DONNERSTAG, DEN 24. DEZEMBER 2015 BIS MITTWOCH, DEN 6. JAENNER 2016 ***
*** CHRISTMAS VACATION FROM THURSDAY, THE 24 DECEMBER 2015 TO WEDNESDAY, 6 JANUARY 2016 ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web