Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1296749 > unrolled thread
| Started by | Andre Przywara <andre.przywara@arm.com> |
|---|---|
| First post | 2015-12-22 13:30 +0100 |
| Last post | 2015-12-28 03:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH 1/5] drivers: sunxi-rsb: fix error output type Andre Przywara <andre.przywara@arm.com> - 2015-12-22 13:30 +0100
Re: [RFC PATCH 1/5] drivers: sunxi-rsb: fix error output type Arnd Bergmann <arnd@arndb.de> - 2015-12-22 23:10 +0100
Re: [RFC PATCH 1/5] drivers: sunxi-rsb: fix error output type Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-28 03:50 +0100
| From | Andre Przywara <andre.przywara@arm.com> |
|---|---|
| Date | 2015-12-22 13:30 +0100 |
| Subject | [RFC PATCH 1/5] drivers: sunxi-rsb: fix error output type |
| Message-ID | <qIueK-3Tt-1@gated-at.bofh.it> |
"len" is actually a size_t in this function here, so properly annotate the dev_err printf type to allow compilation for 64-bit architectures. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/bus/sunxi-rsb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index 846bc29..7f26bc1d 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -330,7 +330,7 @@ static int sunxi_rsb_read(struct sunxi_rsb *rsb, u8 rtaddr, u8 addr, cmd = RSB_CMD_RD32; break; default: - dev_err(rsb->dev, "Invalid access width: %d\n", len); + dev_err(rsb->dev, "Invalid access width: %zd\n", len); return -EINVAL; } @@ -372,7 +372,7 @@ static int sunxi_rsb_write(struct sunxi_rsb *rsb, u8 rtaddr, u8 addr, cmd = RSB_CMD_WR32; break; default: - dev_err(rsb->dev, "Invalid access width: %d\n", len); + dev_err(rsb->dev, "Invalid access width: %zd\n", len); return -EINVAL; } -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-12-22 23:10 +0100 |
| Message-ID | <qIDi2-1cT-35@gated-at.bofh.it> |
| In reply to | #1296749 |
On Tuesday 22 December 2015, Andre Przywara wrote: > "len" is actually a size_t in this function here, so properly annotate > the dev_err printf type to allow compilation for 64-bit architectures. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2015-12-28 03:50 +0100 |
| Message-ID | <qKw34-3Io-491@gated-at.bofh.it> |
| In reply to | #1296749 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Dec 22, 2015 at 12:27:43PM +0000, Andre Przywara wrote: > "len" is actually a size_t in this function here, so properly annotate > the dev_err printf type to allow compilation for 64-bit architectures. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Queued for 4.6, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web