Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1297078 > unrolled thread

[PATCH] um: Fix build error and kconfig for i386

Started byMickaël Salaün <mic@digikod.net>
First post2015-12-22 22:50 +0100
Last post2015-12-23 14:00 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] um: Fix build error and kconfig for i386 Mickaël Salaün <mic@digikod.net> - 2015-12-22 22:50 +0100
    Re: [PATCH] um: Fix build error and kconfig for i386 Richard Weinberger <richard@nod.at> - 2015-12-22 23:30 +0100
      Re: [PATCH] um: Fix build error and kconfig for i386 Mickaël Salaün <mic@digikod.net> - 2015-12-23 14:00 +0100

#1297078 — [PATCH] um: Fix build error and kconfig for i386

FromMickaël Salaün <mic@digikod.net>
Date2015-12-22 22:50 +0100
Subject[PATCH] um: Fix build error and kconfig for i386
Message-ID<qICYG-QF-39@gated-at.bofh.it>
Fix build error by selecting COREDUMP when X86_32 is selected:

arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
(.text+0x3e62): undefined reference to `dump_emit'
arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
(.text+0x3eef): undefined reference to `dump_emit'

Signed-off-by: Mickaël Salaün <mic@digikod.net>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
---
 arch/x86/um/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
index ed56a1c4ae73..bb7cd8b38043 100644
--- a/arch/x86/um/Kconfig
+++ b/arch/x86/um/Kconfig
@@ -26,6 +26,7 @@ config X86_32
 	select CLONE_BACKWARDS
 	select OLD_SIGSUSPEND3
 	select OLD_SIGACTION
+	select COREDUMP
 
 config X86_64
 	def_bool 64BIT
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1297101

FromRichard Weinberger <richard@nod.at>
Date2015-12-22 23:30 +0100
Message-ID<qIDBo-1jC-11@gated-at.bofh.it>
In reply to#1297078
Am 22.12.2015 um 22:44 schrieb Mickaël Salaün:
> Fix build error by selecting COREDUMP when X86_32 is selected:
> 
> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> (.text+0x3e62): undefined reference to `dump_emit'
> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> (.text+0x3eef): undefined reference to `dump_emit'
> 
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> ---
>  arch/x86/um/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
> index ed56a1c4ae73..bb7cd8b38043 100644
> --- a/arch/x86/um/Kconfig
> +++ b/arch/x86/um/Kconfig
> @@ -26,6 +26,7 @@ config X86_32
>  	select CLONE_BACKWARDS
>  	select OLD_SIGSUSPEND3
>  	select OLD_SIGACTION
> +	select COREDUMP


Do you know since when this is broken?

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1297450

FromMickaël Salaün <mic@digikod.net>
Date2015-12-23 14:00 +0100
Message-ID<qIRbk-1fn-17@gated-at.bofh.it>
In reply to#1297101

[Multipart message — attachments visible in raw view] — view raw

On 22/12/2015 23:28, Richard Weinberger wrote:
> Am 22.12.2015 um 22:44 schrieb Mickaël Salaün:
>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>> (.text+0x3e62): undefined reference to `dump_emit'
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>> (.text+0x3eef): undefined reference to `dump_emit'
>>
>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>> Cc: Jeff Dike <jdike@addtoit.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> ---
>>  arch/x86/um/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
>> index ed56a1c4ae73..bb7cd8b38043 100644
>> --- a/arch/x86/um/Kconfig
>> +++ b/arch/x86/um/Kconfig
>> @@ -26,6 +26,7 @@ config X86_32
>>  	select CLONE_BACKWARDS
>>  	select OLD_SIGSUSPEND3
>>  	select OLD_SIGACTION
>> +	select COREDUMP
> 
> 
> Do you know since when this is broken?


After some bisecting, it's broken since v3.15. I'll send a new patch including this info.

 Mickaël

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web