Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1295797 > unrolled thread

Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support

Started byMark yao <mark.yao@rock-chips.com>
First post2015-12-21 08:40 +0100
Last post2015-12-21 08:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support Mark yao <mark.yao@rock-chips.com> - 2015-12-21 08:40 +0100
    Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI  support Yakir Yang <ykk@rock-chips.com> - 2015-12-21 08:50 +0100

#1295797 — Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support

FromMark yao <mark.yao@rock-chips.com>
Date2015-12-21 08:40 +0100
SubjectRe: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support
Message-ID<qI3ex-3xA-5@gated-at.bofh.it>
On 2015年11月11日 15:46, Yakir Yang wrote:
> +	hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
> +
> +	drm_connector_helper_add(&hdmi->connector,
> +				 &inno_hdmi_connector_helper_funcs);
> +	drm_connector_init(drm, &hdmi->connector, &inno_hdmi_connector_funcs,
> +			   DRM_MODE_CONNECTOR_HDMIA);
> +
> +	hdmi->connector.encoder = encoder;

Pls remove "hdmi->connector.encoder = encoder;"

It would cause a error dump on atomic drm runtime:

WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 
drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200()

This issue can be explained from following thread:
https://lkml.org/lkml/2015/11/16/498

Thanks.

-- 
Mark Yao


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1295802 — Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support

FromYakir Yang <ykk@rock-chips.com>
Date2015-12-21 08:50 +0100
SubjectRe: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support
Message-ID<qI3oe-3AX-1@gated-at.bofh.it>
In reply to#1295797
Hi Mark,

On 12/21/2015 03:31 PM, Mark yao wrote:
> On 2015年11月11日 15:46, Yakir Yang wrote:
>> +    hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
>> +
>> +    drm_connector_helper_add(&hdmi->connector,
>> +                 &inno_hdmi_connector_helper_funcs);
>> +    drm_connector_init(drm, &hdmi->connector, 
>> &inno_hdmi_connector_funcs,
>> +               DRM_MODE_CONNECTOR_HDMIA);
>> +
>> +    hdmi->connector.encoder = encoder;
>
> Pls remove "hdmi->connector.encoder = encoder;"
>
> It would cause a error dump on atomic drm runtime:
>
> WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 
> drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200()
>
> This issue can be explained from following thread:
> https://lkml.org/lkml/2015/11/16/498
>

Done, thanks

- Yakir

> Thanks.
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web