Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1295275 > unrolled thread
| Started by | Minfei Huang <mnfhuang@gmail.com> |
|---|---|
| First post | 2015-12-19 04:00 +0100 |
| Last post | 2015-12-21 05:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ceph: Avoid to propagate the invalid page point Minfei Huang <mnfhuang@gmail.com> - 2015-12-19 04:00 +0100
Re: [PATCH] ceph: Avoid to propagate the invalid page point "Yan, Zheng" <zyan@redhat.com> - 2015-12-21 05:20 +0100
| From | Minfei Huang <mnfhuang@gmail.com> |
|---|---|
| Date | 2015-12-19 04:00 +0100 |
| Subject | [PATCH] ceph: Avoid to propagate the invalid page point |
| Message-ID | <qHfUt-5Gv-1@gated-at.bofh.it> |
The variant pagep will still get the invalid page point, although ceph
fails in function ceph_update_writeable_page.
To fix this issue, Assigne the page to pagep until there is no failure
in function ceph_update_writeable_page.
Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
fs/ceph/addr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index b7d218a..6491079 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1149,7 +1149,6 @@ static int ceph_write_begin(struct file *file, struct address_space *mapping,
page = grab_cache_page_write_begin(mapping, index, 0);
if (!page)
return -ENOMEM;
- *pagep = page;
dout("write_begin file %p inode %p page %p %d~%d\n", file,
inode, page, (int)pos, (int)len);
--
2.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Yan, Zheng" <zyan@redhat.com> |
|---|---|
| Date | 2015-12-21 05:20 +0100 |
| Message-ID | <qI06Z-1DV-3@gated-at.bofh.it> |
| In reply to | #1295275 |
> On Dec 19, 2015, at 10:54, Minfei Huang <mnfhuang@gmail.com> wrote:
>
> The variant pagep will still get the invalid page point, although ceph
> fails in function ceph_update_writeable_page.
>
> To fix this issue, Assigne the page to pagep until there is no failure
> in function ceph_update_writeable_page.
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
> fs/ceph/addr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index b7d218a..6491079 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1149,7 +1149,6 @@ static int ceph_write_begin(struct file *file, struct address_space *mapping,
> page = grab_cache_page_write_begin(mapping, index, 0);
> if (!page)
> return -ENOMEM;
> - *pagep = page;
>
> dout("write_begin file %p inode %p page %p %d~%d\n", file,
> inode, page, (int)pos, (int)len);
applied, thanks
Yan, Zheng
> --
> 2.6.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web