Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1294596 > unrolled thread

[PATCH 1/1] staging: coding style cleanups for staging/panel driver

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] staging: coding style cleanups for staging/panel driver Bijosh T <bijosh.thyks@gmail.com> - 2015-12-18 10:30 +0100
    Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver Willy Tarreau <w@1wt.eu> - 2015-12-18 14:00 +0100
    Re: [PATCH 1/1] staging: coding style cleanups for staging/panel  driver Greg KH <gregkh@linuxfoundation.org> - 2015-12-18 17:10 +0100
      Re: [PATCH 1/1] staging: coding style cleanups for staging/panel  driver Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-19 07:30 +0100
        Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver Willy Tarreau <w@1wt.eu> - 2015-12-19 08:10 +0100

#1294596 — [PATCH 1/1] staging: coding style cleanups for staging/panel driver

From: Bijosh T <bijosh.thyks@gmail.com>

This patch fixes coding style errors for staging/panel driver.

Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>
---
 drivers/staging/panel/panel.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 79ac192..04d86f3 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
 		lcd_send_serial(0x5F);	/* R/W=W, RS=1 */
 		lcd_send_serial(' ' & 0x0F);
 		lcd_send_serial((' ' >> 4) & 0x0F);
-		usleep_range(40, 100);	/* the shortest data takes at least 40 us */
+		/* the shortest data takes at least 40 us */
+		usleep_range(40, 100);
 	}
 	spin_unlock_irq(&pprt_lock);
 
@@ -1788,7 +1789,7 @@ static void phys_scan_contacts(void)
 	gndmask = PNL_PINPUT(r_str(pprt)) & scan_mask_i;
 
 	/* grounded inputs are signals 40-44 */
-	phys_read |= (pmask_t) gndmask << 40;
+	phys_read |= (pmask_t)gndmask << 40;
 
 	if (bitmask != gndmask) {
 		/*
@@ -1804,7 +1805,7 @@ static void phys_scan_contacts(void)
 
 			w_dtr(pprt, oldval & ~bitval);	/* enable this output */
 			bitmask = PNL_PINPUT(r_str(pprt)) & ~gndmask;
-			phys_read |= (pmask_t) bitmask << (5 * bit);
+			phys_read |= (pmask_t)bitmask << (5 * bit);
 		}
 		w_dtr(pprt, oldval);	/* disable all outputs */
 	}
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1294789

On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> From: Bijosh T <bijosh.thyks@gmail.com>
> 
> This patch fixes coding style errors for staging/panel driver.
> 
> Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>

Acked-by: Willy Tarreau <w@1wt.eu>

Thanks Bijosh,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1294994 — Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver

On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> From: Bijosh T <bijosh.thyks@gmail.com>
> 
> This patch fixes coding style errors for staging/panel driver.
> 
> Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>

I need a "full" name here, not just "T" as a last name, as odds are it's
a bit longer than just that one character...

Please fix up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1295315 — Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver

On Fri, Dec 18, 2015 at 08:01:58AM -0800, Greg KH wrote:
> On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> > From: Bijosh T <bijosh.thyks@gmail.com>
> > 
> > This patch fixes coding style errors for staging/panel driver.
> > 
> > Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>
> 
> I need a "full" name here, not just "T" as a last name, as odds are it's
> a bit longer than just that one character...
> 
> Please fix up and resend.

While you are resending please also mention which coding style error you
have fixed.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1295321

On Sat, Dec 19, 2015 at 11:55:13AM +0530, Sudip Mukherjee wrote:
> On Fri, Dec 18, 2015 at 08:01:58AM -0800, Greg KH wrote:
> > On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> > > From: Bijosh T <bijosh.thyks@gmail.com>
> > > 
> > > This patch fixes coding style errors for staging/panel driver.
> > > 
> > > Signed-off-by: Bijosh T <bijosh.thyks@gmail.com>
> > 
> > I need a "full" name here, not just "T" as a last name, as odds are it's
> > a bit longer than just that one character...
> > 
> > Please fix up and resend.
> 
> While you are resending please also mention which coding style error you
> have fixed.

Well, they are so minor (mostly spaces) that anyone interested should
read the patch.

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web