Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1295262 > unrolled thread
| Started by | chunguang qu <quchunguang@gmail.com> |
|---|---|
| First post | 2015-12-19 03:10 +0100 |
| Last post | 2015-12-21 16:20 +0100 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
Indent issus in kernel module development chunguang qu <quchunguang@gmail.com> - 2015-12-19 03:10 +0100
Re: Indent issus in kernel module development Randy Dunlap <rdunlap@infradead.org> - 2015-12-19 03:30 +0100
Re: Indent issus in kernel module development chunguang qu <quchunguang@gmail.com> - 2015-12-19 07:00 +0100
Re: Indent issus in kernel module development Joe Perches <joe@perches.com> - 2015-12-19 07:20 +0100
Re: Indent issus in kernel module development chunguang qu <quchunguang@gmail.com> - 2015-12-20 14:00 +0100
Re: Indent issus in kernel module development "Austin S. Hemmelgarn" <ahferroin7@gmail.com> - 2015-12-21 16:20 +0100
| From | chunguang qu <quchunguang@gmail.com> |
|---|---|
| Date | 2015-12-19 03:10 +0100 |
| Subject | Indent issus in kernel module development |
| Message-ID | <qHf85-5om-7@gated-at.bofh.it> |
`indent -linux` sometimes made my code totally a mess. I know it most likely a bug of GNU INDENT. And this is not a bug report. I only want to know other kernel developers how to deal with this problem. Since GUN INDENT is recommend in kernel's CodingStyle, I think surely someone here encounter this problem either. CMD LANG=C indent -linux FROM http://paste.ubuntu.com/14093393/ TO http://paste.ubuntu.com/14093405/ Thanks. -- [Kevin Q (ChunGuang Qu)](mailto:quchunguang@gmail.com) [public key](http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x5B06DCA77BEF043B) @sdu.edu.cn @gnu.org @mit.edu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2015-12-19 03:30 +0100 |
| Message-ID | <qHfrs-5uX-7@gated-at.bofh.it> |
| In reply to | #1295262 |
On 12/18/15 18:07, chunguang qu wrote: > `indent -linux` sometimes made my code totally a mess. > I know it most likely a bug of GNU INDENT. And this is not a bug report. > I only want to know other kernel developers how to deal with this problem. > Since GUN INDENT is recommend in kernel's CodingStyle, I think surely > someone here encounter this problem either. Huh? CodingStyle says: Now, again, GNU indent has the same brain-dead settings that GNU emacs has, which is why you need to give it a few command line options. It also says try using scripts/Lindent. Have you tried it? It won't be perfect either, AFAI recall, but it might help. or you could try emacs (as indicated in CodingStyle). Good luck with that. > CMD > LANG=C indent -linux > > FROM > http://paste.ubuntu.com/14093393/ > > TO > http://paste.ubuntu.com/14093405/ > > Thanks. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | chunguang qu <quchunguang@gmail.com> |
|---|---|
| Date | 2015-12-19 07:00 +0100 |
| Message-ID | <qHiIG-7zM-7@gated-at.bofh.it> |
| In reply to | #1295268 |
Yes, I just tried `scripts/Lindent` and it has the same problem. I had compared the source of `Lindent` with `-linux` option of `indent` long time ago, there's seems no major difference. So i used `indent -linux <file>` above. Thanks for your advice about `emace`, but `vi` is my only editor for dozens of years. 2015-12-19 10:26 GMT+08:00 Randy Dunlap <rdunlap@infradead.org>: > On 12/18/15 18:07, chunguang qu wrote: >> `indent -linux` sometimes made my code totally a mess. >> I know it most likely a bug of GNU INDENT. And this is not a bug report. >> I only want to know other kernel developers how to deal with this problem. >> Since GUN INDENT is recommend in kernel's CodingStyle, I think surely >> someone here encounter this problem either. > > Huh? > > CodingStyle says: > > Now, again, GNU indent has the same brain-dead settings that GNU emacs > has, which is why you need to give it a few command line options. > > It also says try using scripts/Lindent. Have you tried it? > It won't be perfect either, AFAI recall, but it might help. > > or you could try emacs (as indicated in CodingStyle). Good luck with that. > > > >> CMD >> LANG=C indent -linux >> >> FROM >> http://paste.ubuntu.com/14093393/ >> >> TO >> http://paste.ubuntu.com/14093405/ >> >> Thanks. > > > > > -- > ~Randy -- [Kevin Q (ChunGuang Qu)](mailto:quchunguang@gmail.com) [public key](http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x5B06DCA77BEF043B) @sdu.edu.cn @gnu.org @mit.edu @grazestar.com @jolijolie.cn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-12-19 07:20 +0100 |
| Message-ID | <qHj21-7Wr-5@gated-at.bofh.it> |
| In reply to | #1295313 |
On Sat, 2015-12-19 at 13:50 +0800, chunguang qu wrote: > Yes, I just tried `scripts/Lindent` and it has the same problem. > > I had compared the source of `Lindent` with `-linux` option of > `indent` long time ago, there's seems no major difference. > So i used `indent -linux <file>` above. > > Thanks for your advice about `emace`, but `vi` is my only editor for > dozens of years. Try: $ ./scripts/checkpatch.pl --fix --types=spacing <file> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | chunguang qu <quchunguang@gmail.com> |
|---|---|
| Date | 2015-12-20 14:00 +0100 |
| Message-ID | <qHLKG-Hp-21@gated-at.bofh.it> |
| In reply to | #1295314 |
I tried it. Not worked unfortunately,. ```bash $ ~/share/linux/scripts/checkpatch.pl --fix --types=spacing testcompletion.c total: 0 errors, 0 warnings, 0 lines checked testcompletion.c has no obvious style problems and is ready for submission. NOTE: Used message types: SPACING ``` 2015-12-19 14:16 GMT+08:00 Joe Perches <joe@perches.com>: > On Sat, 2015-12-19 at 13:50 +0800, chunguang qu wrote: >> Yes, I just tried `scripts/Lindent` and it has the same problem. >> >> I had compared the source of `Lindent` with `-linux` option of >> `indent` long time ago, there's seems no major difference. >> So i used `indent -linux <file>` above. >> >> Thanks for your advice about `emace`, but `vi` is my only editor for >> dozens of years. > > Try: > > $ ./scripts/checkpatch.pl --fix --types=spacing <file> > -- [Kevin Q (ChunGuang Qu)](mailto:quchunguang@gmail.com) [public key](http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x5B06DCA77BEF043B) @sdu.edu.cn @gnu.org @mit.edu @grazestar.com @jolijolie.cn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Austin S. Hemmelgarn" <ahferroin7@gmail.com> |
|---|---|
| Date | 2015-12-21 16:20 +0100 |
| Message-ID | <qIapH-88b-3@gated-at.bofh.it> |
| In reply to | #1295588 |
On 2015-12-20 07:52, chunguang qu wrote: > I tried it. Not worked unfortunately,. > > ```bash > $ ~/share/linux/scripts/checkpatch.pl --fix --types=spacing testcompletion.c > total: 0 errors, 0 warnings, 0 lines checked > > testcompletion.c has no obvious style problems and is ready for submission. > > NOTE: Used message types: SPACING > ``` You might try something with clang-format. It doesn't have a built-in style option for the kernel (probably because the kernel can't currently be compiled with Clang/LLVM, but Linux does qualify for the first two criteria for having a new style default added, so if someone wants to actually work on it, they could probably get it included), but something like this for the config should get you pretty close: BasedOnStyle: LLVM IndentWidth: 8 UseTab: Always BreakBeforeBraces: Linux AllowShortIfStatementOnASingleLine: false IndentCaseLabels: false I'm pretty certain that this doesn't cover everything from CodingStyle, but it should cover most things, and most of the other stuff should be relatively easily scriptable using regex based replacements. > > 2015-12-19 14:16 GMT+08:00 Joe Perches <joe@perches.com>: >> On Sat, 2015-12-19 at 13:50 +0800, chunguang qu wrote: >>> Yes, I just tried `scripts/Lindent` and it has the same problem. >>> >>> I had compared the source of `Lindent` with `-linux` option of >>> `indent` long time ago, there's seems no major difference. >>> So i used `indent -linux <file>` above. >>> >>> Thanks for your advice about `emace`, but `vi` is my only editor for >>> dozens of years. >> >> Try: >> >> $ ./scripts/checkpatch.pl --fix --types=spacing <file> >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web