Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1293947 > unrolled thread
| Started by | Tomas Winkler <tomas.winkler@intel.com> |
|---|---|
| First post | 2015-12-17 16:00 +0100 |
| Last post | 2015-12-20 13:00 +0100 |
| Articles | 1 on this page of 21 — 4 participants |
Back to article view | Back to linux.kernel
[char-misc-next v2 0/7] mei: create proper iAMT watchdog driver Tomas Winkler <tomas.winkler@intel.com> - 2015-12-17 16:00 +0100
[char-misc-next v2 2/7] mei: wd: drop the watchdog code from the core mei driver Tomas Winkler <tomas.winkler@intel.com> - 2015-12-17 16:00 +0100
[char-misc-next v2 1/7] mei: drop nfc leftovers from the mei driver Tomas Winkler <tomas.winkler@intel.com> - 2015-12-17 16:00 +0100
[char-misc-next v2 6/7] watchdog: mei_wdt: register wd device only if required Tomas Winkler <tomas.winkler@intel.com> - 2015-12-17 16:00 +0100
Re: [char-misc-next v2 6/7] watchdog: mei_wdt: register wd device only if required Guenter Roeck <linux@roeck-us.net> - 2015-12-18 18:00 +0100
RE: [char-misc-next v2 6/7] watchdog: mei_wdt: register wd device only if required "Winkler, Tomas" <tomas.winkler@intel.com> - 2015-12-20 13:30 +0100
Re: [char-misc-next v2 6/7] watchdog: mei_wdt: register wd device only if required Guenter Roeck <linux@roeck-us.net> - 2015-12-20 19:20 +0100
[char-misc-next v2 7/7] watchdog: mei_wdt: re-register device on event Tomas Winkler <tomas.winkler@intel.com> - 2015-12-17 16:00 +0100
Re: [char-misc-next v2 7/7] watchdog: mei_wdt: re-register device on event Guenter Roeck <linux@roeck-us.net> - 2015-12-18 18:10 +0100
Re: [char-misc-next v2 7/7] watchdog: mei_wdt: re-register device on event One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-18 18:30 +0100
Re: [char-misc-next v2 7/7] watchdog: mei_wdt: re-register device on event Guenter Roeck <linux@roeck-us.net> - 2015-12-18 19:00 +0100
Re: [char-misc-next v2 7/7] watchdog: mei_wdt: re-register device on event One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-18 19:20 +0100
RE: [char-misc-next v2 7/7] watchdog: mei_wdt: re-register device on event "Winkler, Tomas" <tomas.winkler@intel.com> - 2015-12-20 14:00 +0100
[char-misc-next v2 5/7] mei: bus: whitelist the watchdog client Tomas Winkler <tomas.winkler@intel.com> - 2015-12-17 16:00 +0100
[char-misc-next v2 3/7] watchdog: mei_wdt: implement MEI iAMT watchdog driver Tomas Winkler <tomas.winkler@intel.com> - 2015-12-17 16:00 +0100
Re: [char-misc-next v2 3/7] watchdog: mei_wdt: implement MEI iAMT watchdog driver Guenter Roeck <linux@roeck-us.net> - 2015-12-18 17:40 +0100
[char-misc-next 4/7] watchdog: mei_wdt: add status debugfs entry Tomas Winkler <tomas.winkler@intel.com> - 2015-12-17 16:00 +0100
Re: [char-misc-next 4/7] watchdog: mei_wdt: add status debugfs entry Guenter Roeck <linux@roeck-us.net> - 2015-12-18 17:50 +0100
RE: [char-misc-next 4/7] watchdog: mei_wdt: add status debugfs entry "Winkler, Tomas" <tomas.winkler@intel.com> - 2015-12-20 10:50 +0100
Re: [char-misc-next 4/7] watchdog: mei_wdt: add status debugfs entry Guenter Roeck <linux@roeck-us.net> - 2015-12-20 11:50 +0100
RE: [char-misc-next 4/7] watchdog: mei_wdt: add status debugfs entry "Winkler, Tomas" <tomas.winkler@intel.com> - 2015-12-20 13:00 +0100
Page 2 of 2 — ← Prev page 1 [2]
| From | "Winkler, Tomas" <tomas.winkler@intel.com> |
|---|---|
| Date | 2015-12-20 13:00 +0100 |
| Subject | RE: [char-misc-next 4/7] watchdog: mei_wdt: add status debugfs entry |
| Message-ID | <qHKOC-69-7@gated-at.bofh.it> |
| In reply to | #1295554 |
> >>> +#if IS_ENABLED(CONFIG_DEBUG_FS)
> >>> +static const char *mei_wdt_state_str(enum mei_wdt_state state)
> >>> +{
> >>> + switch (state) {
> >>> + case MEI_WDT_IDLE: return "IDLE";
> >>> + case MEI_WDT_START: return "START";
> >>> + case MEI_WDT_RUNNING: return "RUNNING";
> >>> + case MEI_WDT_STOPPING: return "STOPPING";
> >>> + default: return "unknown";
> >>
> >> Doesn't this cause checkpatch warnings ?
> > It doesn't and also checkpatch.pl is just a help tool.
>
> I should have said "Doesn't this violate the single-statement-per-line"
> coding style rule, but I guess then you'd argue that "case xxx:" is not
> a statement.
I believe it is reasonably readable , but I don't have a strong feeling about it, if you do I can change it.
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web