Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1294945 > unrolled thread

[PATCH 1/2] bio: Remove the incorrect test for idx in __bio_clone_fast

Started byMinfei Huang <mnfhuang@gmail.com>
First post2015-12-18 16:10 +0100
Last post2015-12-18 16:40 +0100
Articles 4 — 1 participant

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] bio: Remove the incorrect test for idx in __bio_clone_fast Minfei Huang <mnfhuang@gmail.com> - 2015-12-18 16:10 +0100
    [PATCH 2/2] bio: Free own bvec before assigning the source bio's bvec Minfei Huang <mnfhuang@gmail.com> - 2015-12-18 16:10 +0100
      Re: [PATCH 2/2] bio: Free own bvec before assigning the source bio's  bvec Minfei Huang <mnfhuang@gmail.com> - 2015-12-18 16:30 +0100
    Re: [PATCH 1/2] bio: Remove the incorrect test for idx in  __bio_clone_fast Minfei Huang <mnfhuang@gmail.com> - 2015-12-18 16:40 +0100

#1294945 — [PATCH 1/2] bio: Remove the incorrect test for idx in __bio_clone_fast

FromMinfei Huang <mnfhuang@gmail.com>
Date2015-12-18 16:10 +0100
Subject[PATCH 1/2] bio: Remove the incorrect test for idx in __bio_clone_fast
Message-ID<qH4Po-7gd-17@gated-at.bofh.it>
It is more lucky that kernel crash does not happen, since we test the
bi_pool in function __bio_clone_fast. Now bi_flags is used to flag the
idx, so it is incorrect to test the bi_pool.

For now, the bio in function __bio_clone_fast may have its own bvec, if
the caller is bio_clone_fast.

Removing the test to fix this issue.

Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
 block/bio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/bio.c b/block/bio.c
index 4f184d9..70d9814 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -573,8 +573,6 @@ EXPORT_SYMBOL(bio_phys_segments);
  */
 void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
 {
-	BUG_ON(bio->bi_pool && BIO_POOL_IDX(bio) != BIO_POOL_NONE);
-
 	/*
 	 * most users will be overriding ->bi_bdev with a new target,
 	 * so we don't set nor calculate new physical/hw segment counts here
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1294946 — [PATCH 2/2] bio: Free own bvec before assigning the source bio's bvec

FromMinfei Huang <mnfhuang@gmail.com>
Date2015-12-18 16:10 +0100
Subject[PATCH 2/2] bio: Free own bvec before assigning the source bio's bvec
Message-ID<qH4Po-7gd-19@gated-at.bofh.it>
In reply to#1294945
This is a memory leaking during splitting the bio by the caller
bio_clone_fast.

Clone bio may allocate its own bvec, if demanding bvec is more than
inline bvec in function bio_alloc_bioset.

bi_io_vec is assigned to the source bio's bvec directly without freeing
it firstly in function __bio_clone_fast.

To fix it, freeing the own bvec firstly before assigning the source
bio's bvec.

Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
 block/bio.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/block/bio.c b/block/bio.c
index 70d9814..b24fd6e 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -581,6 +581,10 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
 	bio_set_flag(bio, BIO_CLONED);
 	bio->bi_rw = bio_src->bi_rw;
 	bio->bi_iter = bio_src->bi_iter;
+
+	if (bio_flagged(bio, BIO_OWNS_VEC))
+		bvec_free(bio->bi_pool->bvec_pool,
+				bio->bi_io_vec, BIO_POOL_IDX(bio));
 	bio->bi_io_vec = bio_src->bi_io_vec;
 }
 EXPORT_SYMBOL(__bio_clone_fast);
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1294960 — Re: [PATCH 2/2] bio: Free own bvec before assigning the source bio's bvec

FromMinfei Huang <mnfhuang@gmail.com>
Date2015-12-18 16:30 +0100
SubjectRe: [PATCH 2/2] bio: Free own bvec before assigning the source bio's bvec
Message-ID<qH58J-7n3-11@gated-at.bofh.it>
In reply to#1294946
Sorry to bother you, since I have missed the nr_iovecs in
bio_clone_fast.

Nacked this patch.

Thanks
Minfei

On 12/18/15 at 11:02P, Minfei Huang wrote:
> This is a memory leaking during splitting the bio by the caller
> bio_clone_fast.
> 
> Clone bio may allocate its own bvec, if demanding bvec is more than
> inline bvec in function bio_alloc_bioset.
> 
> bi_io_vec is assigned to the source bio's bvec directly without freeing
> it firstly in function __bio_clone_fast.
> 
> To fix it, freeing the own bvec firstly before assigning the source
> bio's bvec.
> 
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
>  block/bio.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/block/bio.c b/block/bio.c
> index 70d9814..b24fd6e 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -581,6 +581,10 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
>  	bio_set_flag(bio, BIO_CLONED);
>  	bio->bi_rw = bio_src->bi_rw;
>  	bio->bi_iter = bio_src->bi_iter;
> +
> +	if (bio_flagged(bio, BIO_OWNS_VEC))
> +		bvec_free(bio->bi_pool->bvec_pool,
> +				bio->bi_io_vec, BIO_POOL_IDX(bio));
>  	bio->bi_io_vec = bio_src->bi_io_vec;
>  }
>  EXPORT_SYMBOL(__bio_clone_fast);
> -- 
> 2.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1294963 — Re: [PATCH 1/2] bio: Remove the incorrect test for idx in __bio_clone_fast

FromMinfei Huang <mnfhuang@gmail.com>
Date2015-12-18 16:40 +0100
SubjectRe: [PATCH 1/2] bio: Remove the incorrect test for idx in __bio_clone_fast
Message-ID<qH5ip-7rE-9@gated-at.bofh.it>
In reply to#1294945
On 12/18/15 at 11:02P, Minfei Huang wrote:
> It is more lucky that kernel crash does not happen, since we test the
> bi_pool in function __bio_clone_fast. Now bi_flags is used to flag the
> idx, so it is incorrect to test the bi_pool.
> 
> For now, the bio in function __bio_clone_fast may have its own bvec, if
> the caller is bio_clone_fast.
> 
> Removing the test to fix this issue.
> 
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
>  block/bio.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/block/bio.c b/block/bio.c
> index 4f184d9..70d9814 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -573,8 +573,6 @@ EXPORT_SYMBOL(bio_phys_segments);
>   */
>  void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
>  {
> -	BUG_ON(bio->bi_pool && BIO_POOL_IDX(bio) != BIO_POOL_NONE);
> -

Sorry to bother you, since I have missed the nr_iovecs in function
bio_clone_fast.

Will update this patch to make test correct, instead of removing it.

Thanks
Minfei
	
>  	/*
>  	 * most users will be overriding ->bi_bdev with a new target,
>  	 * so we don't set nor calculate new physical/hw segment counts here
> -- 
> 2.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web