Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1294957 > unrolled thread

Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource Arnd Bergmann <arnd@arndb.de> - 2015-12-18 16:30 +0100
    Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource Linus Walleij <linus.walleij@linaro.org> - 2015-12-22 10:00 +0100

#1294957 — Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource

On Monday 30 November 2015 09:47:03 Linus Walleij wrote:
> On Wed, Nov 18, 2015 at 4:21 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > resource_size_t may be defined as 32 or 64 bit depending on configuration,
> > so it cannot be printed using the normal format strings, as gcc correctly
> > warns:
> >
> > pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
> > pinctrl-at91-pio4.c:1003:41: warning: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
> >    dev_dbg(dev, "bank %i: hwirq=%u\n", i, res->start);
> >
> > This changes the format string to use the special "%pr" format
> > string that prints a resource, and changes the arguments so we
> > the resource structure directly.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > v2: don't break ordering of arguments, that part was correct already, unlike
> > what I said in v1.
> 
> Patch applied with Ludovic's review tag.

I don't see this in linux-next, did the commit get lost accidentally?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1296622

On Fri, Dec 18, 2015 at 4:29 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday 30 November 2015 09:47:03 Linus Walleij wrote:
>> On Wed, Nov 18, 2015 at 4:21 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> > resource_size_t may be defined as 32 or 64 bit depending on configuration,
>> > so it cannot be printed using the normal format strings, as gcc correctly
>> > warns:
>> >
>> > pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
>> > pinctrl-at91-pio4.c:1003:41: warning: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>> >    dev_dbg(dev, "bank %i: hwirq=%u\n", i, res->start);
>> >
>> > This changes the format string to use the special "%pr" format
>> > string that prints a resource, and changes the arguments so we
>> > the resource structure directly.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > ---
>> > v2: don't break ordering of arguments, that part was correct already, unlike
>> > what I said in v1.
>>
>> Patch applied with Ludovic's review tag.
>
> I don't see this in linux-next, did the commit get lost accidentally?

No, it's just that I screwed up the next branch so many times and
Stephen has not been able to pull it into linux-next.

Hope it works now...

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web