Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1293621 > unrolled thread

[PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

Started byWang Nan <wangnan0@huawei.com>
First post2015-12-17 06:30 +0100
Last post2015-12-18 15:30 +0100
Articles 3 on this page of 23 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
    [PATCH 01/10] bpf samples: bpf: Fix tracex5_kern.c compiling error Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
    [PATCH 05/10] bpf tools: Support load different type of programs Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
    [PATCH 03/10] bpf tools: Add const decoretor to 'license' and 'insns' for bpf_load_program() Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
    [PATCH 02/10] bpf tools: Define LD and RM in Makefile for 'make -R' Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
    [PATCH 06/10] bpf tools: Support new map operations Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
      Re: [PATCH 06/10] bpf tools: Support new map operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-17 07:10 +0100
      [PATCH v2 06/10] bpf tools: Support new map operations Wang Nan <wangnan0@huawei.com> - 2015-12-17 07:20 +0100
    [PATCH 07/10] bpf tools: Support BPF_OBJ_PIN and BPF_OBJ_GET Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
    [PATCH 09/10] bpf samples: Uses libbpf in tools/lib to deal with BPF operations Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:40 +0100
    Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-17 07:40 +0100
      Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-17 08:00 +0100
        Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-17 08:10 +0100
          Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-17 09:30 +0100
            Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-17 11:20 +0100
              Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-17 14:50 +0100
                Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-18 04:10 +0100
                  Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-18 10:00 +0100
                    [PATCH] tools build: Output more data during feature detection Wang Nan <wangnan0@huawei.com> - 2015-12-18 12:00 +0100
                    Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-18 12:10 +0100
                      Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-18 14:00 +0100
                        Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations pi3orama <pi3orama@163.com> - 2015-12-18 15:20 +0100
                        Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-18 15:30 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1294794 — Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

FromDaniel Wagner <daniel.wagner@bmw-carit.de>
Date2015-12-18 14:00 +0100
SubjectRe: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations
Message-ID<qH2NA-5M6-7@gated-at.bofh.it>
In reply to#1294670
On 12/18/2015 12:03 PM, Wangnan (F) wrote:
> That's good. This is not a magic.

That is what you say! :)

> I guess something in your top makefile
> causes this feature check failure. I sent a patch on feature checker to
> you.
> It will appear as [1] soon. Could you please apply it and try again?

Sure.

> This time you will see test-*.make.output and test-*.make.makeoutput.
> test-*.make.output lists your PATH, PWD and the gcc command you use for
> feature check. test-*.make.makeoutput is the output of 'make' itself. I
> think
> from these information we can find the root cause easier.

$ ls samples/bpf/libbpf/feature.libbpf/*
samples/bpf/libbpf/feature.libbpf/test-all.make.makeoutput
samples/bpf/libbpf/feature.libbpf/test-bpf.make.makeoutput
samples/bpf/libbpf/feature.libbpf/test-libelf-getphdrnum.make.makeoutput
samples/bpf/libbpf/feature.libbpf/test-libelf.make.makeoutput
samples/bpf/libbpf/feature.libbpf/test-libelf-mmap.make.makeoutput

$ cat samples/bpf/libbpf/feature.libbpf/*
make[2]: *** tools/build/feature: No such file or directory.  Stop.
make[2]: *** tools/build/feature: No such file or directory.  Stop.
make[2]: *** tools/build/feature: No such file or directory.  Stop.
make[2]: *** tools/build/feature: No such file or directory.  Stop.
make[2]: *** tools/build/feature: No such file or directory.  Stop.

$ find -name *.make.output
./tools/build/feature/test-gtk2.make.output
./tools/build/feature/test-libpython.make.output
./tools/build/feature/test-libunwind.make.output
./tools/build/feature/test-bionic.make.output
./tools/build/feature/test-libelf-mmap.make.output
./tools/build/feature/test-numa_num_possible_cpus.make.output
./tools/build/feature/test-libaudit.make.output
./tools/build/feature/test-libslang.make.output
./tools/build/feature/test-libdw-dwarf-unwind.make.output
./tools/build/feature/test-libbfd.make.output
./tools/build/feature/test-get_cpuid.make.output
./tools/build/feature/test-zlib.make.output
./tools/build/feature/test-libelf.make.output
./tools/build/feature/test-libperl.make.output
./tools/build/feature/test-bpf.make.output
./tools/build/feature/test-dwarf.make.output
./tools/build/feature/test-libnuma.make.output
./tools/build/feature/test-glibc.make.output
./tools/build/feature/test-cplus-demangle.make.output
./tools/build/feature/test-libelf-getphdrnum.make.output
./tools/build/feature/test-all.make.output
./tools/build/feature/test-lzma.make.output


$ ls -l  tools/build/feature/*.make.output
-rw-rw-r-- 1 wagi wagi 419 Dec 17 14:39 tools/build/feature/test-all.make.output
-rw-rw-r-- 1 wagi wagi 104 Oct 20 09:59 tools/build/feature/test-bionic.make.output
-rw-rw-r-- 1 wagi wagi   0 Dec 17 09:01 tools/build/feature/test-bpf.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-cplus-demangle.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-dwarf.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-get_cpuid.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-glibc.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-gtk2.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libaudit.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libbfd.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libdw-dwarf-unwind.make.output
-rw-rw-r-- 1 wagi wagi   0 Dec 17 09:01 tools/build/feature/test-libelf-getphdrnum.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libelf.make.output
-rw-rw-r-- 1 wagi wagi   0 Dec 17 09:01 tools/build/feature/test-libelf-mmap.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libnuma.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libperl.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libpython.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libslang.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-libunwind.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-lzma.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-numa_num_possible_cpus.make.output
-rw-rw-r-- 1 wagi wagi   0 Oct 20 09:59 tools/build/feature/test-zlib.make.output

$ cat tools/build/feature/test-all.make.output
In file included from /usr/include/Python.h:7:0,
                 from test-libpython.c:1,
                 from test-all.c:13:
/usr/lib64/perl5/CORE/patchlevel.h:135:2: error: ‘NULL’ undeclared here (not in a function)
  NULL
  ^
In file included from test-libpython.c:1:0,
                 from test-all.c:13:
/usr/include/Python.h:8:22: fatal error: pyconfig.h: No such file or directory
compilation terminated.

$ cat tools/build/feature/test-bionic.make.output
test-bionic.c:1:31: fatal error: android/api-level.h: No such file or directory
compilation terminated.


Could it be that $(srcdir) somehow is not correct? I exchanged

	feature_dir := $(srctree)/tools/build/feature
to
	feature_dir := /home/wagi/src/linux/tools/build/feature

and then the feature check worked in this case but still no fun:


$ make samples/bpf/
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CHK include/generated/bounds.h
CHK include/generated/timeconst.h
CHK include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
make -C /home/wagi/src/linux/tools/lib/bpf O=/home/wagi/src/linux/samples/bpf/libbpf CFLAGS= LDFLAGS= V=1 /home/wagi/src/linux/samples/bpf/libbpf/libbpf.a

Auto-detecting system features:
... libelf: [ on ]
... bpf: [ on ]

make -f ./tools/build/Makefile.build dir=. obj=libbpf
make[3]: tools/build/Makefile.build: No such file or directory
make[3]: *** No rule to make target 'tools/build/Makefile.build'. Stop.
Makefile:155: recipe for target '/home/wagi/src/linux/samples/bpf/libbpf/libbpf-in.o' failed
make[2]: *** [/home/wagi/src/linux/samples/bpf/libbpf/libbpf-in.o] Error 2
samples/bpf/Makefile:10: recipe for target 'samples/bpf/libbpf/libbpf.a' failed
make[1]: *** [samples/bpf/libbpf/libbpf.a] Error 2
Makefile:1550: recipe for target 'samples/bpf/' failed
make: *** [samples/bpf/] Error 2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1294837

Frompi3orama <pi3orama@163.com>
Date2015-12-18 15:20 +0100
Message-ID<qH42Z-6Hj-1@gated-at.bofh.it>
In reply to#1294794

发自我的 iPhone

> 在 2015年12月18日，下午8:55，Daniel Wagner <daniel.wagner@bmw-carit.de> 写道：
> 
>> On 12/18/2015 12:03 PM, Wangnan (F) wrote:
>> That's good. This is not a magic.
> 
> That is what you say! :)
> 
>> I guess something in your top makefile
>> causes this feature check failure. I sent a patch on feature checker to
>> you.
>> It will appear as [1] soon. Could you please apply it and try again?
> 
> Sure.
> 
>> This time you will see test-*.make.output and test-*.make.makeoutput.
>> test-*.make.output lists your PATH, PWD and the gcc command you use for
>> feature check. test-*.make.makeoutput is the output of 'make' itself. I
>> think
>> from these information we can find the root cause easier.
> 
> $ ls samples/bpf/libbpf/feature.libbpf/*
> samples/bpf/libbpf/feature.libbpf/test-all.make.makeoutput
> samples/bpf/libbpf/feature.libbpf/test-bpf.make.makeoutput
> samples/bpf/libbpf/feature.libbpf/test-libelf-getphdrnum.make.makeoutput
> samples/bpf/libbpf/feature.libbpf/test-libelf.make.makeoutput
> samples/bpf/libbpf/feature.libbpf/test-libelf-mmap.make.makeoutput
> 
> $ cat samples/bpf/libbpf/feature.libbpf/*
> make[2]: *** tools/build/feature: No such file or directory.  Stop.
> make[2]: *** tools/build/feature: No such file or directory.  Stop.
> make[2]: *** tools/build/feature: No such file or directory.  Stop.
> make[2]: *** tools/build/feature: No such file or directory.  Stop.
> make[2]: *** tools/build/feature: No such file or directory.  Stop.
> 

Thank you for your information.

I think the reason of the failure is the missing of srctree. I skipped a patch [1]
because I think it is independent with this patchset, but I was wrong.

Could you please add the srctree setting code block from [1] to your
tools/lib/bpf/Makefile and try again? You don't need other part of it,
or you have to apply the whole patchset because it moves a file.

[1] http://lkml.kernel.org/g/1450316632-152513-1-git-send-email-wangnan0@huawei.com

Thank you.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1294874 — Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

FromDaniel Wagner <daniel.wagner@bmw-carit.de>
Date2015-12-18 15:30 +0100
SubjectRe: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations
Message-ID<qH4cH-6Lj-49@gated-at.bofh.it>
In reply to#1294794
On 12/18/2015 02:50 PM, pi3orama wrote:
>> Could it be that $(srcdir) somehow is not correct? I exchanged
>>
>>    feature_dir := $(srctree)/tools/build/feature
>> to
>>    feature_dir := /home/wagi/src/linux/tools/build/feature
>>
> 
> Can you remember the patch set I skipped?
> 
> http://lkml.kernel.org/g/1450316632-152513-4-git-send-email-wangnan0@huawei.com
> <http://lkml.kernel.org/g/1450316632-152513-1-git-send-email-wangnan0@huawei.com>

I'll give them a try next week.

> I thought that patch set is independent with this one but I was wrong.
> The reason
> of your problem is the missing of srctree. Could you please add the
> definition of
> srctree and try again? Like this:
> 
> +ifeq ($(srctree),)
> +srctree := $(patsubst %/,%,$(dir $(shell pwd)))
> +srctree := $(patsubst %/,%,$(dir $(srctree)))
> +srctree := $(patsubst %/,%,$(dir $(srctree)))
> +#$(info Determined 'srctree' to be $(srctree))
> +endif
> 
> At the head of tools/lib/bpf/Makefile

I tried that one but it didn't change unfortunately. I saw that code
snipped is already in tools/lib/bpf/Makefile line 62. It exists since

1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature
check")

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web