Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292132 > unrolled thread

[PATCH v3 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core

Started byChen Feng <puck.chen@hisilicon.com>
First post2015-12-15 14:00 +0100
Last post2015-12-22 17:10 +0100
Articles 13 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng <puck.chen@hisilicon.com> - 2015-12-15 14:00 +0100
    [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC Chen Feng <puck.chen@hisilicon.com> - 2015-12-15 14:00 +0100
      Re: [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC Mark Brown <broonie@kernel.org> - 2015-12-16 20:20 +0100
        Re: [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC chenfeng <puck.chen@hisilicon.com> - 2015-12-17 04:20 +0100
    [PATCH v3 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng <puck.chen@hisilicon.com> - 2015-12-15 14:00 +0100
    [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node Chen Feng <puck.chen@hisilicon.com> - 2015-12-15 14:00 +0100
      Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node chenfeng <puck.chen@hisilicon.com> - 2015-12-17 04:40 +0100
        Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node Mark Brown <broonie@kernel.org> - 2015-12-18 19:00 +0100
          Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node chenfeng <puck.chen@hisilicon.com> - 2015-12-21 04:10 +0100
            Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node chenfeng <puck.chen@hisilicon.com> - 2015-12-21 07:40 +0100
              Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node Mark Brown <broonie@kernel.org> - 2015-12-23 01:50 +0100
                Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node chenfeng <puck.chen@hisilicon.com> - 2015-12-24 04:00 +0100
            Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node Mark Brown <broonie@kernel.org> - 2015-12-22 17:10 +0100

#1292132 — [PATCH v3 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core

FromChen Feng <puck.chen@hisilicon.com>
Date2015-12-15 14:00 +0100
Subject[PATCH v3 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core
Message-ID<qFXmW-4ea-5@gated-at.bofh.it>
The patch sets add support for Hi6220 PMIC Hi655x MFD core and its
regulator driver.
  Current testing and support board is Hikey which is one of 96boards.
It is an arm64 open source board. For more information about this board,
please access https://www.96boards.org.

This is hardware layout for access PMIC Hi655x from AP SoC Hi6220.
Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
We can use memory-mapped I/O to communicate.

+----------------+             +-------------+
|                |             |             |
|    Hi6220      |   SSI bus   |   Hi655x    |
|                |-------------|             |
|                |(REGMAP_MMIO)|             |
+----------------+             +-------------+

V2: Code refactoring of regulator

V3: Drop mtcmos from this patch and use regmap-irq

The patch sets are based on 4.4-rc5.

Chen Feng (5):
  doc: bindings: Add document for mfd hi665x PMIC
  doc: bindings: Document for hi655x regulator driver
  mfd: hi655x: Add hi665x pmic driver
  regulator: add regulator driver of hi655x PMIC
  hisilicon/dts: Add hi655x pmic dts node

 .../devicetree/bindings/mfd/hisilicon,hi655x.txt   |  17 ++
 .../regulator/hisilicon,hi655x-regulator.txt       |  43 ++++
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi          | 178 +++++++++++++++
 drivers/mfd/Kconfig                                |   9 +
 drivers/mfd/Makefile                               |   1 +
 drivers/mfd/hi655x-pmic.c                          | 170 ++++++++++++++
 drivers/regulator/Kconfig                          |   8 +
 drivers/regulator/Makefile                         |   1 +
 drivers/regulator/hi655x-regulator.c               | 246 +++++++++++++++++++++
 include/linux/mfd/hi655x-pmic.h                    |  56 +++++
 include/linux/regulator/hi655x-regulator.h         |  41 ++++
 11 files changed, 770 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt
 create mode 100644 drivers/mfd/hi655x-pmic.c
 create mode 100644 drivers/regulator/hi655x-regulator.c
 create mode 100644 include/linux/mfd/hi655x-pmic.h
 create mode 100644 include/linux/regulator/hi655x-regulator.h

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1292134 — [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC

FromChen Feng <puck.chen@hisilicon.com>
Date2015-12-15 14:00 +0100
Subject[PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC
Message-ID<qFXmW-4ea-19@gated-at.bofh.it>
In reply to#1292132
Add driver support for HiSilicon Hi655x voltage regulators.

Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Fei Wang <w.f@huawei.com>
Tested-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
---
 drivers/regulator/Kconfig                  |   8 +
 drivers/regulator/Makefile                 |   1 +
 drivers/regulator/hi655x-regulator.c       | 246 +++++++++++++++++++++++++++++
 include/linux/regulator/hi655x-regulator.h |  41 +++++
 4 files changed, 296 insertions(+)
 create mode 100644 drivers/regulator/hi655x-regulator.c
 create mode 100644 include/linux/regulator/hi655x-regulator.h

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 8df0b0e..c6ecfd7 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -261,6 +261,14 @@ config REGULATOR_HI6421
 	  21 general purpose LDOs, 3 dedicated LDOs, and 5 BUCKs. All
 	  of them come with support to either ECO (idle) or sleep mode.
 
+config REGULATOR_HI655X
+	tristate "Hisilicon HI655X PMIC regulators support"
+	depends on ARCH_HISI
+	depends on MFD_HI655X_PMIC && OF
+	help
+	  This driver provides support for the voltage regulators of the
+	  Hisilicon Hi655x PMIC device.
+
 config REGULATOR_ISL9305
 	tristate "Intersil ISL9305 regulator"
 	depends on I2C
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 0f81749..8e4db96 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -34,6 +34,7 @@ obj-$(CONFIG_REGULATOR_DB8500_PRCMU) += db8500-prcmu.o
 obj-$(CONFIG_REGULATOR_FAN53555) += fan53555.o
 obj-$(CONFIG_REGULATOR_GPIO) += gpio-regulator.o
 obj-$(CONFIG_REGULATOR_HI6421) += hi6421-regulator.o
+obj-$(CONFIG_REGULATOR_HI655X) += hi655x-regulator.o
 obj-$(CONFIG_REGULATOR_ISL6271A) += isl6271a-regulator.o
 obj-$(CONFIG_REGULATOR_ISL9305) += isl9305.o
 obj-$(CONFIG_REGULATOR_LP3971) += lp3971.o
diff --git a/drivers/regulator/hi655x-regulator.c b/drivers/regulator/hi655x-regulator.c
new file mode 100644
index 0000000..e222ee7
--- /dev/null
+++ b/drivers/regulator/hi655x-regulator.c
@@ -0,0 +1,246 @@
+/*
+ * Device driver for regulators in hi655x IC
+ *
+ * Copyright (c) 2015 Hisilicon.
+ *
+ * Chen Feng <puck.chen@hisilicon.com>
+ * Fei  Wang <w.f@huawei.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+#include <linux/slab.h>
+#include <linux/device.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/platform_device.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/of_address.h>
+#include <linux/regmap.h>
+#include <linux/regulator/driver.h>
+#include <linux/regulator/machine.h>
+#include <linux/regulator/of_regulator.h>
+#include <linux/delay.h>
+#include <linux/time.h>
+#include <linux/regulator/hi655x-regulator.h>
+#include <linux/mfd/hi655x-pmic.h>
+#include <linux/regmap.h>
+#include <linux/bitops.h>
+#include <linux/string.h>
+
+static int hi655x_is_enabled(struct regulator_dev *rdev)
+{
+	unsigned int value = 0;
+
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+	struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
+
+	regmap_read(rdev->regmap, ctrl_regs->status_reg, &value);
+	return (value & BIT(regulator->ctrl_mask));
+}
+
+static int hi655x_disable(struct regulator_dev *rdev)
+{
+	int ret = 0;
+
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+	struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
+
+	ret = regmap_write(rdev->regmap, ctrl_regs->disable_reg,
+			   BIT(regulator->ctrl_mask));
+	return ret;
+}
+
+static int hi655x_get_voltage(struct regulator_dev *rdev)
+{
+	unsigned int value = 0;
+
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+
+	regmap_read(rdev->regmap, regulator->vset_reg, &value);
+	value &= regulator->vset_mask;
+
+	return regulator->rdesc.volt_table[value];
+}
+
+static int hi655x_set_voltage(struct regulator_dev *rdev,
+				int min_uV, int max_uV, unsigned *selector)
+{
+	int i = 0;
+	int vol = 0;
+
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+
+	/**
+	 * search the matched vol and get its index
+	 */
+	for (i = 0; i < regulator->rdesc.n_voltages; i++) {
+		vol = regulator->rdesc.volt_table[i];
+		if ((vol >= min_uV) && (vol <= max_uV))
+			break;
+	}
+
+	if (i == regulator->rdesc.n_voltages)
+		return -EINVAL;
+
+	regmap_update_bits(rdev->regmap, regulator->vset_reg,
+			   regulator->vset_mask, i);
+
+	*selector = i;
+
+	return 0;
+}
+
+static struct regulator_ops hi655x_regulator_ops = {
+	.enable = regulator_enable_regmap,
+	.disable = hi655x_disable,
+	.is_enabled = hi655x_is_enabled,
+	.list_voltage = regulator_list_voltage_table,
+	.get_voltage = hi655x_get_voltage,
+	.set_voltage = hi655x_set_voltage,
+};
+
+static const struct of_device_id of_hi655x_regulator_match_tbl[] = {
+	{
+		.compatible = "hisilicon,hi655x-regulator-pmic",
+	},
+};
+MODULE_DEVICE_TABLE(of, of_hi655x_regulator_match_tbl);
+
+/**
+ * get the hi655x specific data from dt node.
+ */
+static int of_get_hi655x_ctr(struct hi655x_regulator *regulator,
+			     struct device *dev, struct device_node *np)
+{
+	int ret;
+	u32 *vset_table;
+	u32 vset_reg;
+	u32 ctrl_mask;
+	u32 vset_mask;
+	u32 vol_numb;
+	struct hi655x_regulator_ctrl_regs ctrl_reg;
+	struct hi655x_regulator_ctrl_regs *t_ctrl;
+
+	ret = of_property_read_u32_array(np, "regulator-ctrl-regs",
+					 (u32 *)&ctrl_reg, 0x3);
+	if (!ret) {
+		t_ctrl = &regulator->ctrl_regs;
+		t_ctrl->enable_reg = HI655X_BUS_ADDR(ctrl_reg.enable_reg);
+		t_ctrl->disable_reg = HI655X_BUS_ADDR(ctrl_reg.disable_reg);
+		t_ctrl->status_reg = HI655X_BUS_ADDR(ctrl_reg.status_reg);
+	} else
+		goto error;
+
+	ret = of_property_read_u32(np, "regulator-ctrl-mask", &ctrl_mask);
+	if (!ret)
+		regulator->ctrl_mask = ctrl_mask;
+	else
+		goto error;
+
+	regulator->rdesc.enable_reg = t_ctrl->enable_reg;
+	regulator->rdesc.enable_val = ctrl_mask;
+	regulator->rdesc.enable_mask = ctrl_mask;
+
+	ret = of_property_read_u32(np, "regulator-vset-regs", &vset_reg);
+	if (!ret)
+		regulator->vset_reg = HI655X_BUS_ADDR(vset_reg);
+	else
+		goto error;
+
+	ret = of_property_read_u32(np, "regulator-vset-mask", &vset_mask);
+	if (!ret)
+		regulator->vset_mask = vset_mask;
+	else
+		goto error;
+
+	ret = of_property_read_u32(np, "regulator-n-vol", &vol_numb);
+	if (!ret)
+		regulator->rdesc.n_voltages = vol_numb;
+	else
+		goto error;
+
+	vset_table = devm_kzalloc(dev, vol_numb * sizeof(int), GFP_KERNEL);
+	if (!vset_table)
+		return -ENOMEM;
+
+	ret = of_property_read_u32_array(np, "regulator-vset-table",
+					 vset_table,
+					 vol_numb);
+
+	if (!ret)
+		regulator->rdesc.volt_table = vset_table;
+
+	return 0;
+error:
+	dev_err(dev, "get from dts node error!\n");
+	return -ENODEV;
+}
+
+static int hi655x_regulator_probe(struct platform_device *pdev)
+{
+	int ret;
+	struct hi655x_regulator *regulator;
+	struct hi655x_pmic *pmic;
+	struct regulator_init_data *init_data;
+	struct regulator_config config = { };
+	struct device_node *np = pdev->dev.of_node;
+	struct device *dev = &pdev->dev;
+
+	pmic = dev_get_drvdata(pdev->dev.parent);
+	if (!pmic) {
+		dev_err(dev, "no pmic in the regulator parent node\n");
+		return -ENODEV;
+	}
+
+	regulator = devm_kzalloc(dev, sizeof(*regulator), GFP_KERNEL);
+	if (!regulator)
+		return -ENOMEM;
+
+	regulator->rdesc.type = REGULATOR_VOLTAGE;
+	regulator->rdesc.owner = THIS_MODULE;
+	regulator->rdesc.ops = &hi655x_regulator_ops;
+	init_data = of_get_regulator_init_data(dev, dev->of_node,
+					       &regulator->rdesc);
+	if (!init_data)
+		return -EINVAL;
+
+	config.dev = &pdev->dev;
+	config.init_data = init_data;
+	config.driver_data = regulator;
+	config.regmap = pmic->regmap;
+	config.of_node = pdev->dev.of_node;
+	regulator->rdesc.name = init_data->constraints.name;
+
+	ret = of_get_hi655x_ctr(regulator, dev, np);
+	if (ret) {
+		dev_err(dev, "get param from dts error!\n");
+		return ret;
+	}
+
+	regulator->regdev = devm_regulator_register(dev,
+						    &regulator->rdesc,
+						    &config);
+	if (IS_ERR(regulator->regdev))
+		return PTR_ERR(regulator->regdev);
+
+	platform_set_drvdata(pdev, regulator);
+
+	return 0;
+}
+
+static struct platform_driver hi655x_regulator_driver = {
+	.driver = {
+		.name	= "hi655x_regulator",
+		.of_match_table = of_hi655x_regulator_match_tbl,
+	},
+	.probe	= hi655x_regulator_probe,
+};
+module_platform_driver(hi655x_regulator_driver);
+
+MODULE_AUTHOR("Chen Feng <puck.chen@hisilicon.com>");
+MODULE_DESCRIPTION("Hisi hi655x PMIC driver");
+MODULE_LICENSE("GPL v2");
diff --git a/include/linux/regulator/hi655x-regulator.h b/include/linux/regulator/hi655x-regulator.h
new file mode 100644
index 0000000..8c76fc5
--- /dev/null
+++ b/include/linux/regulator/hi655x-regulator.h
@@ -0,0 +1,41 @@
+/*
+ * Head file for hi655x regulator
+ *
+ * Copyright (c) 2015 Hisilicon.
+ *
+ * Chen Feng <puck.chen@hisilicon.com>
+ * Fei  Wang <w.f@huawei.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+#ifndef __HISI_HI655X_REGULATOR_H__
+#define __HISI_HI655X_REGULATOR_H__
+
+struct hi655x_regulator_ctrl_regs {
+	u32  enable_reg;
+	u32  disable_reg;
+	u32  status_reg;
+};
+
+struct hi655x_regulator_ctrl_data {
+	int          shift;
+	unsigned int val;
+};
+
+struct hi655x_regulator_vset_data {
+	int          shift;
+	unsigned int mask;
+};
+
+struct hi655x_regulator {
+	struct hi655x_regulator_ctrl_regs ctrl_regs;
+	u32 vset_reg;
+	u32 ctrl_mask;
+	u32 vset_mask;
+	struct regulator_desc rdesc;
+	struct regulator_dev *regdev;
+};
+
+#endif
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1293320 — Re: [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC

FromMark Brown <broonie@kernel.org>
Date2015-12-16 20:20 +0100
SubjectRe: [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC
Message-ID<qGpMe-5PL-19@gated-at.bofh.it>
In reply to#1292134

[Multipart message — attachments visible in raw view] — view raw

On Tue, Dec 15, 2015 at 08:54:15PM +0800, Chen Feng wrote:

> +config REGULATOR_HI655X
> +	tristate "Hisilicon HI655X PMIC regulators support"
> +	depends on ARCH_HISI
> +	depends on MFD_HI655X_PMIC && OF
> +	help
> +	  This driver provides support for the voltage regulators of the
> +	  Hisilicon Hi655x PMIC device.
> +

On the previous version of this patch I said:

| For both of these we should have an || COMPILE_TEST and there's no need
| for either to be bool I can see, they should be tristate.

I see you have made this a tristate which is good but you've not enabled
COMPILE_TEST or indicated why - there may be a very good reason for
doing this but nobody has said what it is.  Please don't ignore review
comments, people are generally making them for a reason and are likely
to have the same concerns if issues remain unaddressed.  Having to
repeat the same comments can get repetitive and make people question the
value of time spent reviewing.  If you disagree with the review comments
that's fine but you need to reply and discuss your concerns so that the
reviewer can understand your decisions.

> +static int hi655x_is_enabled(struct regulator_dev *rdev)
> +{
> +	unsigned int value = 0;
> +
> +	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
> +	struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;

The style here is not what we normally do - normally the struct lookups
would be first, then any other variables and there wouldn't be any blank
lines in the variable declarations.  The same applies to quite a few
functions.

> +static int hi655x_set_voltage(struct regulator_dev *rdev,
> +				int min_uV, int max_uV, unsigned *selector)
> +{

As I commented on the previous version of this driver:

| Use the standard helpers, including one of the map_voltage()s and
| set_voltage_sel_regmap(), don't open code them.

You need to at least split the map and set_voltage_sel operations.

I've stopped reviewing here.

[toc] | [prev] | [next] | [standalone]

#1293583 — Re: [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC

Fromchenfeng <puck.chen@hisilicon.com>
Date2015-12-17 04:20 +0100
SubjectRe: [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC
Message-ID<qGxgJ-2dj-15@gated-at.bofh.it>
In reply to#1293320
Mark,
Thanks very much for your review.

On 2015/12/17 3:16, Mark Brown wrote:
> On Tue, Dec 15, 2015 at 08:54:15PM +0800, Chen Feng wrote:
> 
>> +config REGULATOR_HI655X
>> +	tristate "Hisilicon HI655X PMIC regulators support"
>> +	depends on ARCH_HISI
>> +	depends on MFD_HI655X_PMIC && OF
>> +	help
>> +	  This driver provides support for the voltage regulators of the
>> +	  Hisilicon Hi655x PMIC device.
>> +
> 
> On the previous version of this patch I said:
> 
> | For both of these we should have an || COMPILE_TEST and there's no need
> | for either to be bool I can see, they should be tristate.
> 
> I see you have made this a tristate which is good but you've not enabled
> COMPILE_TEST or indicated why - there may be a very good reason for
> doing this but nobody has said what it is.  Please don't ignore review
> comments, people are generally making them for a reason and are likely
> to have the same concerns if issues remain unaddressed.  Having to
> repeat the same comments can get repetitive and make people question the
> value of time spent reviewing.  If you disagree with the review comments
> that's fine but you need to reply and discuss your concerns so that the
> reviewer can understand your decisions.
> 
Sorry for this,I am busy with other issue these days.

Really appreciate your comments.

I will add the COMPILE_TEST next version.

>> +static int hi655x_is_enabled(struct regulator_dev *rdev)
>> +{
>> +	unsigned int value = 0;
>> +
>> +	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
>> +	struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
> 
> The style here is not what we normally do - normally the struct lookups
> would be first, then any other variables and there wouldn't be any blank
> lines in the variable declarations.  The same applies to quite a few
> functions.
> 

ok, I will fix the style problem.


>> +static int hi655x_set_voltage(struct regulator_dev *rdev,
>> +				int min_uV, int max_uV, unsigned *selector)
>> +{
> 
> As I commented on the previous version of this driver:
> 
> | Use the standard helpers, including one of the map_voltage()s and
> | set_voltage_sel_regmap(), don't open code them.
> 
I change the regulator_enable method to regulator_enable_regmap this version.

But,since the hi655x PMIC use status register to ensure the regulator is okay or not.

Three different register offset in these PMIC series.

enable register.
disable register.
status register.


I can't use regulator_is_enabled_regmap regulator_disable_regmap in helpers.c

int regulator_disable_regmap(struct regulator_dev *rdev)
{
	...
        return regmap_update_bits(rdev->regmap, rdev->desc->enable_reg,
                                  rdev->desc->enable_mask, val);
	...
}
Only enable_reg in the desc struct.

I will change the set voltage to regulator_set_voltage_sel_regmap next version.


Thanks again.


> You need to at least split the map and set_voltage_sel operations.
> 
> I've stopped reviewing here.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1292136 — [PATCH v3 2/5] doc: bindings: Document for hi655x regulator driver

FromChen Feng <puck.chen@hisilicon.com>
Date2015-12-15 14:00 +0100
Subject[PATCH v3 2/5] doc: bindings: Document for hi655x regulator driver
Message-ID<qFXmW-4ea-21@gated-at.bofh.it>
In reply to#1292132
Add Document for hi655x pmic regulator driver

Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Fei Wang <w.f@huawei.com>
Tested-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
---
 .../regulator/hisilicon,hi655x-regulator.txt       | 43 ++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt

diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt
new file mode 100644
index 0000000..2eaebae
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt
@@ -0,0 +1,43 @@
+Hisilicon Hi655x Voltage regulators
+
+Note:
+The hi655x regulator control is managed by hi655x Power IC.
+So the node of this regulator must be child node of hi655x
+pmic node.
+
+The driver uses the regulator core framework, so please also
+take the bindings of regulator.txt for reference.
+
+Required properties:
+- compatible: Must be "hisilicon,hi655x-regulator-pmic";
+- regulator-ctrl-regs: Registers offset of control register,
+  In turn with enable disable and status register offset.
+- regulator-ctrl-mask: The control mask bit of the register.
+- regulator-vset-regs: Voltage set register offset.
+- regulator-vset-mask: voltage set control mask.
+- regulator-n-vol: The num of support voltages.
+- regulator-vset-table: The table of support voltages.
+
+Example:
+        pmic: pmic@f8000000 {
+                compatible = "hisilicon,hi655x-pmic";
+		...
+		ldo7: regulator@a26 {
+			compatible = "hisilicon,hi655x-regulator-pmic";
+			regulator-name = "ldo7";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <3300000>;
+			regulator-valid-modes-mask = <0x0a>;
+			regulator-enable-ramp-delay = <120>;
+			regulator-ctrl-regs = <0x029 0x02a 0x02b>;
+			regulator-ctrl-mask = <0x6>;
+			regulator-vset-regs = <0x078>;
+			regulator-vset-mask = <0x7>;
+			regulator-n-vol = <8>;
+			regulator-vset-table  = <1800000>,<1850000>,
+						<2850000>,<2900000>,
+						<3000000>,<3100000>,
+						<3200000>,<3300000>;
+		};
+		...
+	}
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1292137 — [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

FromChen Feng <puck.chen@hisilicon.com>
Date2015-12-15 14:00 +0100
Subject[PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Message-ID<qFXmX-4ea-27@gated-at.bofh.it>
In reply to#1292132
Add dts node for hi665x MFD and regulator driver

Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Fei Wang <w.f@huawei.com>
Tested-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
---
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 178 ++++++++++++++++++++++++++++++
 1 file changed, 178 insertions(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 82d2488..5f98a72 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -208,5 +208,183 @@
 			clock-names = "uartclk", "apb_pclk";
 			status = "disabled";
 		};
+		pmic: pmic@F8000000 {
+			compatible = "hisilicon,hi655x-pmic";
+			reg = <0x0 0xf8000000 0x0 0x1000>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			pmic-gpios = <&gpio_pmu_irq_n>;
+			status = "okay";
+			ldo2: regulator@a21 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo2";
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <3200000>;
+				regulator-valid-modes-mask = <0x02>;
+				regulator-enable-ramp-delay = <120>;
+				regulator-ctrl-regs = <0x029 0x02a 0x02b>;
+				regulator-ctrl-mask = <0x1>;
+				regulator-vset-regs = <0x072>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <2500000>,<2600000>,
+							<2700000>,<2800000>,
+							<2900000>,<3000000>,
+							<3100000>,<3200000>;
+			};
+			ldo7: regulator@a26 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo7";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-valid-modes-mask = <0x0a>;
+				regulator-enable-ramp-delay = <120>;
+				regulator-ctrl-regs = <0x029 0x02a 0x02b>;
+				regulator-ctrl-mask = <0x6>;
+				regulator-vset-regs = <0x078>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <1800000>,<1850000>,
+							<2850000>,<2900000>,
+							<3000000>,<3100000>,
+							<3200000>,<3300000>;
+			};
+			ldo10: regulator@a29 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo10";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3000000>;
+				regulator-valid-modes-mask = <0x0a>;
+				regulator-enable-ramp-delay = <360>;
+				regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
+				regulator-ctrl-mask = <0x1>;
+				regulator-vset-regs = <0x07b>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <1800000>,<1850000>,
+							<1900000>,<2750000>,
+							<2800000>,<2850000>,
+							<2900000>,<3000000>;
+			};
+			ldo13: regulator@a32 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo13";
+				regulator-min-microvolt = <1600000>;
+				regulator-max-microvolt = <1950000>;
+				regulator-enable-ramp-delay = <120>;
+				regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
+				regulator-ctrl-mask = <0x4>;
+				regulator-vset-regs = <0x07e>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <1600000>,<1650000>,
+							<1700000>,<1750000>,
+							<1800000>,<1850000>,
+							<1900000>,<1950000>;
+			};
+			ldo14: regulator@a33 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo14";
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <3200000>;
+				regulator-enable-ramp-delay = <120>;
+				regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
+				regulator-ctrl-mask = <0x5>;
+				regulator-vset-regs = <0x07f>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <2500000>,<2600000>,
+							<2700000>,<2800000>,
+							<2900000>,<3000000>,
+							<3100000>,<3200000>;
+			};
+			ldo15: regulator@a34 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo15";
+				regulator-min-microvolt = <1600000>;
+				regulator-max-microvolt = <1950000>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-enable-ramp-delay = <120>;
+				regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
+				regulator-ctrl-mask = <0x6>;
+				regulator-vset-regs = <0x080>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <1600000>,<1650000>,
+							<1700000>,<1750000>,
+							<1800000>,<1850000>,
+							<1900000>,<1950000>;
+			};
+			ldo17: regulator@a36 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo17";
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <3200000>;
+				regulator-enable-ramp-delay = <120>;
+				regulator-ctrl-regs = <0x02f 0x030 0x031>;
+				regulator-ctrl-mask = <0x0>;
+				regulator-vset-regs = <0x082>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <2500000>,<2600000>,
+							<2700000>,<2800000>,
+							<2900000>,<3000000>,
+							<3100000>,<3200000>;
+			};
+			ldo19: regulator@a38 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo19";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3000000>;
+				regulator-enable-ramp-delay = <360>;
+				regulator-ctrl-regs = <0x02f 0x030 0x031>;
+				regulator-ctrl-mask = <0x2>;
+				regulator-vset-regs = <0x084>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <1800000>,<1850000>,
+							<1900000>,<2750000>,
+							<2800000>,<2850000>,
+							<2900000>,<3000000>;
+			};
+			ldo21: regulator@a40 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo21";
+				regulator-min-microvolt = <1650000>;
+				regulator-max-microvolt = <2000000>;
+				regulator-always-on;
+				regulator-valid-modes-mask = <0x02>;
+				regulator-enable-ramp-delay = <120>;
+				regulator-ctrl-regs = <0x02f 0x030 0x031>;
+				regulator-ctrl-mask = <0x4>;
+				regulator-vset-regs = <0x086>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <1650000>,<1700000>,
+							<1750000>,<1800000>,
+							<1850000>,<1900000>,
+							<1950000>,<2000000>;
+			};
+			ldo22: regulator@a41 {
+				compatible = "hisilicon,hi655x-regulator-pmic";
+				regulator-name = "ldo22";
+				regulator-min-microvolt = <900000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-valid-modes-mask = <0x02>;
+				regulator-enable-ramp-delay = <120>;
+				regulator-ctrl-regs = <0x02f 0x030 0x031>;
+				regulator-ctrl-mask = <0x5>;
+				regulator-vset-regs = <0x087>;
+				regulator-vset-mask = <0x7>;
+				regulator-n-vol = <8>;
+				regulator-vset-table  = <900000>,<1000000>,
+							<1050000>,<1100000>,
+							<1150000>,<1175000>,
+							<1185000>,<1200000>;
+			       };
+		};
 	};
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1293594 — Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

Fromchenfeng <puck.chen@hisilicon.com>
Date2015-12-17 04:40 +0100
SubjectRe: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Message-ID<qGxA6-2li-11@gated-at.bofh.it>
In reply to#1292137
Mark,
 +- regulator-vset-regs: Voltage set register offset.
 +- regulator-vset-mask: voltage set control mask.
 +- regulator-n-vol: The num of support voltages.
 +- regulator-vset-table: The table of support voltages.

> Why is this in the binding?  This is a binding for a specific device,
> there is no point in putting all these data tables in the DT - it just
> bloats the DT and makes it harder for us to enhance our support for this
> device in the future.

You mentioned in previous version,I I have some questions for it.

This regulator-vset-regs etc are vendor specific describe. The hi655x PMIC
is a series of chips. They all have this value, but the offset may be different.
And we can generate the dts file from excel which is defined by SOC.

I think the dts is designed to distinguish different platform. If we hard code this
in files, it may be also different to use as common in next chip version.

I will appreciate it if you can give me some suggestions.


On 2015/12/15 20:54, Chen Feng wrote:
> Add dts node for hi665x MFD and regulator driver
> 
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Fei Wang <w.f@huawei.com>
> Tested-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 178 ++++++++++++++++++++++++++++++
>  1 file changed, 178 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 82d2488..5f98a72 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -208,5 +208,183 @@
>  			clock-names = "uartclk", "apb_pclk";
>  			status = "disabled";
>  		};
> +		pmic: pmic@F8000000 {
> +			compatible = "hisilicon,hi655x-pmic";
> +			reg = <0x0 0xf8000000 0x0 0x1000>;
> +			#interrupt-cells = <2>;
> +			interrupt-controller;
> +			pmic-gpios = <&gpio_pmu_irq_n>;
> +			status = "okay";
> +			ldo2: regulator@a21 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo2";
> +				regulator-min-microvolt = <2500000>;
> +				regulator-max-microvolt = <3200000>;
> +				regulator-valid-modes-mask = <0x02>;
> +				regulator-enable-ramp-delay = <120>;
> +				regulator-ctrl-regs = <0x029 0x02a 0x02b>;
> +				regulator-ctrl-mask = <0x1>;
> +				regulator-vset-regs = <0x072>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <2500000>,<2600000>,
> +							<2700000>,<2800000>,
> +							<2900000>,<3000000>,
> +							<3100000>,<3200000>;
> +			};
> +			ldo7: regulator@a26 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo7";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-valid-modes-mask = <0x0a>;
> +				regulator-enable-ramp-delay = <120>;
> +				regulator-ctrl-regs = <0x029 0x02a 0x02b>;
> +				regulator-ctrl-mask = <0x6>;
> +				regulator-vset-regs = <0x078>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <1800000>,<1850000>,
> +							<2850000>,<2900000>,
> +							<3000000>,<3100000>,
> +							<3200000>,<3300000>;
> +			};
> +			ldo10: regulator@a29 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo10";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3000000>;
> +				regulator-valid-modes-mask = <0x0a>;
> +				regulator-enable-ramp-delay = <360>;
> +				regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
> +				regulator-ctrl-mask = <0x1>;
> +				regulator-vset-regs = <0x07b>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <1800000>,<1850000>,
> +							<1900000>,<2750000>,
> +							<2800000>,<2850000>,
> +							<2900000>,<3000000>;
> +			};
> +			ldo13: regulator@a32 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo13";
> +				regulator-min-microvolt = <1600000>;
> +				regulator-max-microvolt = <1950000>;
> +				regulator-enable-ramp-delay = <120>;
> +				regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
> +				regulator-ctrl-mask = <0x4>;
> +				regulator-vset-regs = <0x07e>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <1600000>,<1650000>,
> +							<1700000>,<1750000>,
> +							<1800000>,<1850000>,
> +							<1900000>,<1950000>;
> +			};
> +			ldo14: regulator@a33 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo14";
> +				regulator-min-microvolt = <2500000>;
> +				regulator-max-microvolt = <3200000>;
> +				regulator-enable-ramp-delay = <120>;
> +				regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
> +				regulator-ctrl-mask = <0x5>;
> +				regulator-vset-regs = <0x07f>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <2500000>,<2600000>,
> +							<2700000>,<2800000>,
> +							<2900000>,<3000000>,
> +							<3100000>,<3200000>;
> +			};
> +			ldo15: regulator@a34 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo15";
> +				regulator-min-microvolt = <1600000>;
> +				regulator-max-microvolt = <1950000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-enable-ramp-delay = <120>;
> +				regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
> +				regulator-ctrl-mask = <0x6>;
> +				regulator-vset-regs = <0x080>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <1600000>,<1650000>,
> +							<1700000>,<1750000>,
> +							<1800000>,<1850000>,
> +							<1900000>,<1950000>;
> +			};
> +			ldo17: regulator@a36 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo17";
> +				regulator-min-microvolt = <2500000>;
> +				regulator-max-microvolt = <3200000>;
> +				regulator-enable-ramp-delay = <120>;
> +				regulator-ctrl-regs = <0x02f 0x030 0x031>;
> +				regulator-ctrl-mask = <0x0>;
> +				regulator-vset-regs = <0x082>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <2500000>,<2600000>,
> +							<2700000>,<2800000>,
> +							<2900000>,<3000000>,
> +							<3100000>,<3200000>;
> +			};
> +			ldo19: regulator@a38 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo19";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3000000>;
> +				regulator-enable-ramp-delay = <360>;
> +				regulator-ctrl-regs = <0x02f 0x030 0x031>;
> +				regulator-ctrl-mask = <0x2>;
> +				regulator-vset-regs = <0x084>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <1800000>,<1850000>,
> +							<1900000>,<2750000>,
> +							<2800000>,<2850000>,
> +							<2900000>,<3000000>;
> +			};
> +			ldo21: regulator@a40 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo21";
> +				regulator-min-microvolt = <1650000>;
> +				regulator-max-microvolt = <2000000>;
> +				regulator-always-on;
> +				regulator-valid-modes-mask = <0x02>;
> +				regulator-enable-ramp-delay = <120>;
> +				regulator-ctrl-regs = <0x02f 0x030 0x031>;
> +				regulator-ctrl-mask = <0x4>;
> +				regulator-vset-regs = <0x086>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <1650000>,<1700000>,
> +							<1750000>,<1800000>,
> +							<1850000>,<1900000>,
> +							<1950000>,<2000000>;
> +			};
> +			ldo22: regulator@a41 {
> +				compatible = "hisilicon,hi655x-regulator-pmic";
> +				regulator-name = "ldo22";
> +				regulator-min-microvolt = <900000>;
> +				regulator-max-microvolt = <1200000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-valid-modes-mask = <0x02>;
> +				regulator-enable-ramp-delay = <120>;
> +				regulator-ctrl-regs = <0x02f 0x030 0x031>;
> +				regulator-ctrl-mask = <0x5>;
> +				regulator-vset-regs = <0x087>;
> +				regulator-vset-mask = <0x7>;
> +				regulator-n-vol = <8>;
> +				regulator-vset-table  = <900000>,<1000000>,
> +							<1050000>,<1100000>,
> +							<1150000>,<1175000>,
> +							<1185000>,<1200000>;
> +			       };
> +		};
>  	};
>  };
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1295075 — Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

FromMark Brown <broonie@kernel.org>
Date2015-12-18 19:00 +0100
SubjectRe: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Message-ID<qH7tU-iI-9@gated-at.bofh.it>
In reply to#1293594

[Multipart message — attachments visible in raw view] — view raw

On Thu, Dec 17, 2015 at 11:27:27AM +0800, chenfeng wrote:

>  +- regulator-vset-regs: Voltage set register offset.
>  +- regulator-vset-mask: voltage set control mask.
>  +- regulator-n-vol: The num of support voltages.
>  +- regulator-vset-table: The table of support voltages.

> > Why is this in the binding?  This is a binding for a specific device,
> > there is no point in putting all these data tables in the DT - it just
> > bloats the DT and makes it harder for us to enhance our support for this
> > device in the future.

> You mentioned in previous version,I I have some questions for it.

> This regulator-vset-regs etc are vendor specific describe. The hi655x PMIC

There's nothing vendor specific about the way this is written...

> is a series of chips. They all have this value, but the offset may be different.
> And we can generate the dts file from excel which is defined by SOC.

> I think the dts is designed to distinguish different platform. If we hard code this
> in files, it may be also different to use as common in next chip version.

If your tooling can generate DT files it can generate C code just as
well and it seems unlikely you're going to be able to build new boards
without being able to do firmware updates here.  Especially for the
sorts of systems that use DT the set of scenarios where you're able to
update the DT but not the kernel seems like it will be extremely
limited.  I don't really buy the argument that there's any practical
difference in the ability to update the kernel and DT and to the extent
there is one it seems better to keep the ABI we have to support smaller
by having the DT be minimal.

This also allows us to map things more efficiently than we can with just
a table of voltages.  For example a good selection of the regulators in
your example DT appear to be linear ranges and so should be mapped as
such so we can do direct calcuations rather than having to iterate
through a table to map voltages into selectors.  That gets especially
serious for higher resolution regulators like most DCDCs (and modern
LDOs for that matter).

[toc] | [prev] | [next] | [standalone]

#1295753 — Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

Fromchenfeng <puck.chen@hisilicon.com>
Date2015-12-21 04:10 +0100
SubjectRe: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Message-ID<qHZ1f-Uv-5@gated-at.bofh.it>
In reply to#1295075
Mark,

On 2015/12/19 1:58, Mark Brown wrote:
> On Thu, Dec 17, 2015 at 11:27:27AM +0800, chenfeng wrote:
> 
>>  +- regulator-vset-regs: Voltage set register offset.
>>  +- regulator-vset-mask: voltage set control mask.
>>  +- regulator-n-vol: The num of support voltages.
>>  +- regulator-vset-table: The table of support voltages.
> 
>>> Why is this in the binding?  This is a binding for a specific device,
>>> there is no point in putting all these data tables in the DT - it just
>>> bloats the DT and makes it harder for us to enhance our support for this
>>> device in the future.
> 
>> You mentioned in previous version,I I have some questions for it.
> 
>> This regulator-vset-regs etc are vendor specific describe. The hi655x PMIC
> 
> There's nothing vendor specific about the way this is written...
> 
>> is a series of chips. They all have this value, but the offset may be different.
>> And we can generate the dts file from excel which is defined by SOC.
> 
>> I think the dts is designed to distinguish different platform. If we hard code this
>> in files, it may be also different to use as common in next chip version.
> 
> If your tooling can generate DT files it can generate C code just as
> well and it seems unlikely you're going to be able to build new boards
> without being able to do firmware updates here.  Especially for the
> sorts of systems that use DT the set of scenarios where you're able to
> update the DT but not the kernel seems like it will be extremely
> limited.  I don't really buy the argument that there's any practical
> difference in the ability to update the kernel and DT and to the extent
> there is one it seems better to keep the ABI we have to support smaller
> by having the DT be minimal.
> 
> This also allows us to map things more efficiently than we can with just
> a table of voltages.  For example a good selection of the regulators in
> your example DT appear to be linear ranges and so should be mapped as
> such so we can do direct calcuations rather than having to iterate
> through a table to map voltages into selectors.  That gets especially
> serious for higher resolution regulators like most DCDCs (and modern
> LDOs for that matter).
> 
Thanks,
I see, I will change the table of voltages into driver.
like this,
static const unsigned int voltages[] = {
	1500000, 1800000, 2400000, 2500000,
	2600000, 2700000, 2850000, 3000000,
};

And there will be two open-code function for is-enable and disable in the regulator driver.
Since we need use the status and disable register on PM chip. Only enable reg in the regulator desc.

Do you agree with this?




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1295785 — Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

Fromchenfeng <puck.chen@hisilicon.com>
Date2015-12-21 07:40 +0100
SubjectRe: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Message-ID<qI2it-2WU-3@gated-at.bofh.it>
In reply to#1295753

On 2015/12/21 11:01, chenfeng wrote:
> Mark,
> 
> On 2015/12/19 1:58, Mark Brown wrote:
>> On Thu, Dec 17, 2015 at 11:27:27AM +0800, chenfeng wrote:
>>
>>>  +- regulator-vset-regs: Voltage set register offset.
>>>  +- regulator-vset-mask: voltage set control mask.
>>>  +- regulator-n-vol: The num of support voltages.
>>>  +- regulator-vset-table: The table of support voltages.
>>
>>>> Why is this in the binding?  This is a binding for a specific device,
>>>> there is no point in putting all these data tables in the DT - it just
>>>> bloats the DT and makes it harder for us to enhance our support for this
>>>> device in the future.
>>
>>> You mentioned in previous version,I I have some questions for it.
>>
>>> This regulator-vset-regs etc are vendor specific describe. The hi655x PMIC
>>
>> There's nothing vendor specific about the way this is written...
>>
>>> is a series of chips. They all have this value, but the offset may be different.
>>> And we can generate the dts file from excel which is defined by SOC.
>>
>>> I think the dts is designed to distinguish different platform. If we hard code this
>>> in files, it may be also different to use as common in next chip version.
>>
>> If your tooling can generate DT files it can generate C code just as
>> well and it seems unlikely you're going to be able to build new boards
>> without being able to do firmware updates here.  Especially for the
>> sorts of systems that use DT the set of scenarios where you're able to
>> update the DT but not the kernel seems like it will be extremely
>> limited.  I don't really buy the argument that there's any practical
>> difference in the ability to update the kernel and DT and to the extent
>> there is one it seems better to keep the ABI we have to support smaller
>> by having the DT be minimal.
>>
>> This also allows us to map things more efficiently than we can with just
>> a table of voltages.  For example a good selection of the regulators in
>> your example DT appear to be linear ranges and so should be mapped as
>> such so we can do direct calcuations rather than having to iterate
>> through a table to map voltages into selectors.  That gets especially
>> serious for higher resolution regulators like most DCDCs (and modern
>> LDOs for that matter).
>>
> Thanks,
> I see, I will change the table of voltages into driver.
> like this,
> static const unsigned int voltages[] = {
> 	1500000, 1800000, 2400000, 2500000,
> 	2600000, 2700000, 2850000, 3000000,
> };
> 
> And there will be two open-code function for is-enable and disable in the regulator driver.
> Since we need use the status and disable register on PM chip. Only enable reg in the regulator desc.
> 
> Do you agree with this?
> 
While doing this in driver code, I found that it seems all the vendor chip have
the voltage table. So I am wondering can we add this into the regulator framework.

We can add in the function of_get_regulation_constraints to get the vset table.

I am not sure this is right or not.
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1297185 — Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

FromMark Brown <broonie@kernel.org>
Date2015-12-23 01:50 +0100
SubjectRe: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Message-ID<qIFMR-2FA-3@gated-at.bofh.it>
In reply to#1295785

[Multipart message — attachments visible in raw view] — view raw

On Mon, Dec 21, 2015 at 02:20:16PM +0800, chenfeng wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

> While doing this in driver code, I found that it seems all the vendor
> chip have the voltage table. So I am wondering can we add this into
> the regulator framework.

> We can add in the function of_get_regulation_constraints to get the
> vset table.

> I am not sure this is right or not.

I'm just not convinced it's a good pattern to move this data out to DT,
like I said in my other mail it's making the ABI bigger and I'm not sure
I see much upside over putting the data in a table in DT rather than in
C code.  It's more parsing code and more things we really shouldn't
change in future.

[toc] | [prev] | [next] | [standalone]

#1297732 — Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

Fromchenfeng <puck.chen@hisilicon.com>
Date2015-12-24 04:00 +0100
SubjectRe: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Message-ID<qJ4id-106-1@gated-at.bofh.it>
In reply to#1297185

On 2015/12/23 8:46, Mark Brown wrote:
> On Mon, Dec 21, 2015 at 02:20:16PM +0800, chenfeng wrote:
> 
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.
> 
ok, thanks for your advice.
>> While doing this in driver code, I found that it seems all the vendor
>> chip have the voltage table. So I am wondering can we add this into
>> the regulator framework.
> 
>> We can add in the function of_get_regulation_constraints to get the
>> vset table.
> 
>> I am not sure this is right or not.
> 
> I'm just not convinced it's a good pattern to move this data out to DT,
> like I said in my other mail it's making the ABI bigger and I'm not sure
> I see much upside over putting the data in a table in DT rather than in
> C code.  It's more parsing code and more things we really shouldn't
> change in future.
> 
ok. I will send the new version soon.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1296868 — Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

FromMark Brown <broonie@kernel.org>
Date2015-12-22 17:10 +0100
SubjectRe: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Message-ID<qIxFD-694-1@gated-at.bofh.it>
In reply to#1295753

[Multipart message — attachments visible in raw view] — view raw

On Mon, Dec 21, 2015 at 11:01:37AM +0800, chenfeng wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

> I see, I will change the table of voltages into driver.
> like this,
> static const unsigned int voltages[] = {
> 	1500000, 1800000, 2400000, 2500000,
> 	2600000, 2700000, 2850000, 3000000,
> };

> And there will be two open-code function for is-enable and disable in the regulator driver.
> Since we need use the status and disable register on PM chip. Only enable reg in the regulator desc.

> Do you agree with this?

Yes.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web